[Bug 8181] New: Replace DynArch calendar widget with jQueryUI version
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Priority: P5 - low Change sponsored?: --- Bug ID: 8181 Assignee: oleonard@myacpl.org Blocks: 5481 Summary: Replace DynArch calendar widget with jQueryUI version Severity: enhancement Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Templates Depends on: 8143 Product: Koha Currently Koha uses a JavaScript calendar plugin from http://www.dynarch.com/projects/calendar/old/. This older version of the plugin is open source but is now unmaintained. The newer version is not open source. This plugin can be replaced by the jQueryUI datepicker widget: http://jqueryui.com/demos/datepicker/ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 10259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10259&action=edit Bug 8181 - Replace DynArch calendar widget with jQueryUI version All instances of the old DynArch calendar have been replaced with jQueryUI versions and the old library files have been removed. There is now a helper function in staff-global.js for triggering a datepicker prompt on any input field. Just add a "datepicker" class to the input field. If you would like two fields in one from to limit each other (one is date from, one is date to), add these classes to each: "datepickerfrom" and "datepickerto." This will prevent an invalid entry, e.g. a date in the latter which falls before the former. jQueryUI is now upgraded to the latest verision, 1.8.21. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- A couple of notes: This patch re-introduces a couple of image files which are used by the jQueryUI library in general. The datepicker uses some elements of the image sprite. If subsequent jQuery modules don't use other elements of the sprite it might be worth a follow-up to remove it in favor of an alternative style. This patch moves some of the CSS introduced in previous jQueryUI patches out of staff-global.css and into jquery-ui.css in order to make it a more generalized Koha theme. Here is a list of pages modified by this patch: includes/checkouts-table-footer.inc (used by circulation.pl and moremember.pl (renewal due date)) acqui/histsearch.tt acqui/lateorders.tt acqui/parcels.tt admin/aqbudgetperiods.tt admin/aqcontract.tt admin/categorie.tt admin/smart-rules.tt circ/circulation.tt circ/overdue.tt circ/pendingreserves.tt circ/reserveratios.tt labels/search.tt members/memberentrygen.tt members/moremember.tt reports/acquisitions_stats.tt reports/bor_issues_top.tt reports/borrowers_out.tt reports/borrowers_stats.tt reports/cat_issues_top.tt reports/catalogue_stats.tt reports/dictionary.tt reports/guided_reports_start.tt reports/issues_avg_stats.tt reports/issues_by_borrower_category.tt reports/issues_stats.tt reports/reserves_stats.tt reports/stats_screen.tt reserve/request.tt serials/checkexpiration.tt serials/claims.tt serials/subscription-add.tt suggestion/suggestion.tt tags/review.tt tools/cleanborrowers.tt tools/export.tt tools/holidays.tt tools/inventory.tt tools/koha-news.tt tools/modborrowers.tt tools/scheduler.tt tools/viewlog.tt opac-reserve.tt opac-user.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, thx for another big patch to add a shiny new calendar :) Your patch applied cleanly, but I found some smaller problems: 1) In the holidays calendar, the calendar does not display, until I copy a calendar somewhere. So for example, the calendar does not show, when I enter the page. Changing the location on top, does not refresh the page or bring up another calendar. 2) In acquisitions late orders the filters do not respect the dateformat setting. I have metric DD/MM/YYYY but the dates from the datepicker are MM/DD/YYYY. In other places like the holiday calendar the display is correct. (acqui/lateorders.pl) Same problem occurs on: acqui/histsearch.pl acqui/parcels.pl admin/aqbudetperiods.pl admin/aqcontract.pl admin/category.pl (stopping here) 3) The tooltip for the calendar shows up as a black box with '...' in it. It was a bit irritating for me, perhaps you have an idea? 4) The today button does not enter today's date, but does switch back to the correct 'page' of the calendar. Today's date is not very clearly marked there. It's not so easy to spot in the calendar. Perhaps it could stand out a bit more? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10259|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 10365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10365&action=edit Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version All instances of the old DynArch calendar have been replaced with jQueryUI versions and the old library files have been removed. calendar.inc has been modified to include jQueryUI localization strings and global configuration options. Just add a "datepicker" class to an input field to trigger a datepicker prompt. If you would like two fields in one from to limit each other (one is date from, one is date to), add these classes to each: "datepickerfrom" and "datepickerto." This will prevent an invalid entry, e.g. a date in the latter which falls before the former. jQueryUI is now upgraded to the latest verision, 1.8.21. Edit: Now with proper translatability, date formatting, first day of the week handling, and RTL support. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10365|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 10366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10366&action=edit Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version All instances of the old DynArch calendar have been replaced with jQueryUI versions and the old library files have been removed. calendar.inc has been modified to include jQueryUI localization strings and global configuration options. Just add a "datepicker" class to an input field to trigger a datepicker prompt. If you would like two fields in one from to limit each other (one is date from, one is date to), add these classes to each: "datepickerfrom" and "datepickerto." This will prevent an invalid entry, e.g. a date in the latter which falls before the former. jQueryUI is now upgraded to the latest verision, 1.8.21. Edit: Now with proper translatability, date formatting, first day of the week handling, and RTL support. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #3)
1) In the holidays calendar, the calendar does not display, until I copy a calendar somewhere.
I was able to reproduce this error when first visiting the page after switching to this branch, but not on subsequent page loads. Could it have been a browser cache issue?
2) In acquisitions late orders the filters do not respect the dateformat setting.
Handling of dateformat and other I18N settings has been fixed. That is to say, added.
3) The tooltip for the calendar shows up as a black box with '...' in it. It was a bit irritating for me, perhaps you have an idea?
This is a default of the jQueryUI datepicker: The calendar icon has a title attribute added to it, "..." I'm not sure why. It might be possible to revise the default configuration without modifying the jQueryUI library itself. I'll have to investigate.
Today's date is not very clearly marked there. It's not so easy to spot in the calendar. Perhaps it could stand out a bit more?
I have revised the CSS to make it brighter. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- This now appears to work fine for me. Well done Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10366|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 10371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10371&action=edit Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version All instances of the old DynArch calendar have been replaced with jQueryUI versions and the old library files have been removed. calendar.inc has been modified to include jQueryUI localization strings and global configuration options. Just add a "datepicker" class to an input field to trigger a datepicker prompt. If you would like two fields in one from to limit each other (one is date from, one is date to), add these classes to each: "datepickerfrom" and "datepickerto." This will prevent an invalid entry, e.g. a date in the latter which falls before the former. jQueryUI is now upgraded to the latest verision, 1.8.21. Edit: Now with proper translatability, date formatting, first day of the week handling, and RTL support. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 --- Comment #9 from Ian Walls <koha.sekjal@gmail.com> --- Created attachment 10391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10391&action=edit [PASSED QA] Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version All instances of the old DynArch calendar have been replaced with jQueryUI versions and the old library files have been removed. calendar.inc has been modified to include jQueryUI localization strings and global configuration options. Just add a "datepicker" class to an input field to trigger a datepicker prompt. If you would like two fields in one from to limit each other (one is date from, one is date to), add these classes to each: "datepickerfrom" and "datepickerto." This will prevent an invalid entry, e.g. a date in the latter which falls before the former. jQueryUI is now upgraded to the latest verision, 1.8.21. Edit: Now with proper translatability, date formatting, first day of the week handling, and RTL support. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Ian Walls <koha.sekjal@gmail.com> QA Comment: rebased on current master; minor merge conflicts with other patches pushed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10371|0 |1 is obsolete| | --- Comment #10 from Ian Walls <koha.sekjal@gmail.com> --- Comment on attachment 10371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10371 Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version Rebased patch to apply on current master (trivial conflicts resolved) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #11 from Ian Walls <koha.sekjal@gmail.com> --- While this is a very large patch, it is entirely template based. It moves us from one implementation of the datepicker to a better one, with a little spacing cleanup along the way for good measure. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- Could not confirm that every page work fine, but could not find anything wrong either. Patch pushed, i'll advertise this change in my next monthly RM newsletter -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8428 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Bug 8181 depends on bug 8428, which changed state. Bug 8428 Summary: can't save contracts http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10396 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org