http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12060 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26929&action=edit Bug 12060 - Indentation issues cause markup errors in header.inc By correcting the indentation, it became more apparent the two markup errors (stray </li> and </div> tags) that were generated by pasting the page source of PROTOCOL://STAFFCLIENT/cgi-bin/koha/tools/holidays.pl into http://validator.w3.org/check TEST PLAN --------- 1) Home -> Tools -> Calendar in the staff client 2) In another tab open http://validator.w3.org/check 3) Select Validate by Direct Input 4) In the staff client, view the page source 5) Copy the page source to the Validation text box in the other tab. 6) Click the 'Check' button. -- There will be 3 errors. 7) Apply the patch. 8) Refresh the staff client page. 9) Copy the revised page source into the validation text box. 10) click the 'Check' button. -- There will be 1 error. 11) Run the koha qa test tool. NOTE: This error is not in the intended file to fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12060 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12060 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26932&action=edit Bug 12060 - Indentation issues cause markup errors in header.inc By correcting the indentation, it became more apparent the two markup errors (stray </li> and </div> tags) that were generated by pasting the page source of PROTOCOL://STAFFCLIENT/cgi-bin/koha/tools/holidays.pl into http://validator.w3.org/check TEST PLAN --------- 1) Home -> Tools -> Calendar in the staff client 2) In another tab open http://validator.w3.org/check 3) Select Validate by Direct Input 4) In the staff client, view the page source 5) Copy the page source to the Validation text box in the other tab. 6) Click the 'Check' button. -- There will be 3 errors. 7) Apply the patch. 8) Refresh the staff client page. 9) Copy the revised page source into the validation text box. 10) click the 'Check' button. -- There will be 1 error. 11) Run the koha qa test tool. NOTE: This error is not in the intended file to fix. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> git diff --color -w HEAD^ reveals, that only a </li> and a </div> are removed by this patch, all other changes are whitespace. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12060 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26930|0 |1 is obsolete| | Attachment #26932|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26933&action=edit [PASSED QA] Bug 12060 - Indentation issues cause markup errors in header.inc By correcting the indentation, it became more apparent the two markup errors (stray </li> and </div> tags) that were generated by pasting the page source of PROTOCOL://STAFFCLIENT/cgi-bin/koha/tools/holidays.pl into http://validator.w3.org/check TEST PLAN --------- 1) Home -> Tools -> Calendar in the staff client 2) In another tab open http://validator.w3.org/check 3) Select Validate by Direct Input 4) In the staff client, view the page source 5) Copy the page source to the Validation text box in the other tab. 6) Click the 'Check' button. -- There will be 3 errors. 7) Apply the patch. 8) Refresh the staff client page. 9) Copy the revised page source into the validation text box. 10) click the 'Check' button. -- There will be 1 error. 11) Run the koha qa test tool. NOTE: This error is not in the intended file to fix. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> git diff --color -w HEAD^ reveals, that only a </li> and a </div> are removed by this patch, all other changes are whitespace. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12060 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes.