[Bug 26377] New: Clearly label parts of subscription-add.pl that relate to optional item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Bug ID: 26377 Summary: Clearly label parts of subscription-add.pl that relate to optional item records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com On the first screen of subscription-add.pl, there are several fields that set values to be applied to created items. They're only needed if you are creating item records when receiving serials. It'd be very helpful to move these so that they are all grouped together and clearly labeled. It might even be reasonable to hide them if not set to create item records. These fields relate to the item record: - Call number - Library - Location - item type - item type for older issues -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's not completely true, some of this information, like the library and location are also shown in the OPAC if you choose not to create items. The library is also used for access control to subscriptions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Good correction, thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think Call number is shown as well - that would only leave us with the item types. Not sure what a good GUI improvement could look like here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Now that the form has collection and itemtype, perhaps we could enable or disable the fields based on whether the "Create an item record when receiving this serial" button is checked? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134968&action=edit Perhaps we hide fields based on which option is selected? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 135355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135355&action=edit Bug 26377: Clearly label parts of subscription-add.pl that relate to optional item records This patch modifies the form for adding a new subscription so that the collection and item type fields are shown only when the subscription is configured to create an item when receiving. To test, apply the patch and go to Serials -> New subscription. - When the page first loads, the "Do not create an item record when receiving this serial" radio button should be selected. - Under the "Location" field there should be no item type or collection field. - Select the "Create an item when receiving this serial" radio button. - The item type and collection fields should appear. - Test that the values are correctly saved when you add or edit a subscription. - If you edit a subscription which had item type and collection defined, and you switch to "Do not create an item..." the record should save with empty values for those fields. - Confirm that existing subscriptions open with the correct settings applied: Only records with "Create an item..." checked should open with the item type and collection fields displayed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe collection might also be shown somewhere outside of items, but I do not remember clearly from testing the patch. Just something to test here to make sure! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23352 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I verified, the patches had no changes to the OPAC template files, sorry for doubting you! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 [Bug 23352] Define serial's collection in the subscription -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135355|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 135455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135455&action=edit Bug 26377: Clearly label parts of subscription-add.pl that relate to optional item records This patch modifies the form for adding a new subscription so that the collection and item type fields are shown only when the subscription is configured to create an item when receiving. To test, apply the patch and go to Serials -> New subscription. - When the page first loads, the "Do not create an item record when receiving this serial" radio button should be selected. - Under the "Location" field there should be no item type or collection field. - Select the "Create an item when receiving this serial" radio button. - The item type and collection fields should appear. - Test that the values are correctly saved when you add or edit a subscription. - If you edit a subscription which had item type and collection defined, and you switch to "Do not create an item..." the record should save with empty values for those fields. - Confirm that existing subscriptions open with the correct settings applied: Only records with "Create an item..." checked should open with the item type and collection fields displayed. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135479&action=edit Bug 26377: Show when loading the page if needed Prevent a blink -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135480&action=edit Bug 26377: Simplify JS code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Owen, do you agree with those 2 patches? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135479|0 |1 is obsolete| | Attachment #135480|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 135491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135491&action=edit Bug 26377: Show when loading the page if needed Prevent a blink Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 135492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135492&action=edit Bug 26377: Simplify JS code Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135455|0 |1 is obsolete| | Attachment #135491|0 |1 is obsolete| | Attachment #135492|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135500&action=edit Bug 26377: Clearly label parts of subscription-add.pl that relate to optional item records This patch modifies the form for adding a new subscription so that the collection and item type fields are shown only when the subscription is configured to create an item when receiving. To test, apply the patch and go to Serials -> New subscription. - When the page first loads, the "Do not create an item record when receiving this serial" radio button should be selected. - Under the "Location" field there should be no item type or collection field. - Select the "Create an item when receiving this serial" radio button. - The item type and collection fields should appear. - Test that the values are correctly saved when you add or edit a subscription. - If you edit a subscription which had item type and collection defined, and you switch to "Do not create an item..." the record should save with empty values for those fields. - Confirm that existing subscriptions open with the correct settings applied: Only records with "Create an item..." checked should open with the item type and collection fields displayed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135501&action=edit Bug 26377: Show when loading the page if needed Prevent a blink Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135502&action=edit Bug 26377: Simplify JS code Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | CC| |lucas@bywatersolutions.com --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #20 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- not feeling very confident while trying to fix the conflicts after applying on 21.11. Please provide backport if needed. Best, -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org