https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97766&action=edit Bug 24476: Database updates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97768&action=edit Bug 24476: Change CanBookBeRenewed and adjust tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97770&action=edit Bug 24476: Allow patrons to opt out of auto-renewal To test: 1 - Verify on staff side that patron can be edited to opt in our out of auto renewal 2 - Check out some items to a patron opted in to auto renewal 3 - Ensure the items are checked out and set to autorenew 4 - Login on the opac at the patron 5 - Verify items cannot be renewed as scheduled for auto-renewal 6 - On staff side, opt patron out of auto renewal 7 - Verify on opac items are no longer marked for auto renewal 8 - Run the auto renewal cron job, items are not renewed 9 - Set 'no renewal before' to a setting that would prevent renewal 10 - Verify that opting patron in or out of auto renewal changes only the reason items cannot be renewed 11 - Set 'no renewal before' to a setting that would allow for renewal 12 - Verify that opting patron in/out changes their ability to renew 13 - Verify that when opted out cron does not renew 14 - Verify that when opted in the item is auto renewed 15 - Reset the due date, opt out, verify manual renewal succeeds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Failing on step 7. Once I've opted the patron out of auto-renew, they still show on the OPAC as scheduled for auto-renew. Taking a step back, I think this could be a little more clear if we weren't defining it as a negative. Right now it's "select Yes to not auto-renew, select No to not not auto-renew." How about "Allow auto-renew: Yes/No" rather than "Disallow auto-renew: Yes/No"? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- It doesn't look like there's a way to turn off this feature. Could it be added to patron category configuration? I know my library would not want patrons to be able to opt out. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- To Owen's concern, as is there isn't a way for the patron to opt out for themselves from the OPAC, so that makes it easier for a library to disallow it. But ... Seems like if we're going to add this feature it'd be good to also give the patron the option to opt out for themselves from the OPAC. Following existing conventions, this sounds like two sysprefs and a new toggle on the category: IntranetAutoRenewOptOut OPACAutoRenewOptOut and then a thingy in the category to allow an individual category to differ from the syspref -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Whoops, right you are. Yeah, that doesn't exactly fit with the personal details updating stuff. Maybe it needs to be broken out somehow? As we do with privacy choices and messaging preferences? I'm not married to the idea of a syspref AND a category configuration, that's just how we've handled other things, like the ability to do a password reset. On the one hand, it's nice to have one main switch for libraries that want all their categories to behave the same. On the other hand, it's always good to avoid making a syspref if possible. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97766|0 |1 is obsolete| | Attachment #97767|0 |1 is obsolete| | Attachment #97768|0 |1 is obsolete| | Attachment #97769|0 |1 is obsolete| | Attachment #97770|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97831&action=edit Bug 24476: Database updates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97833&action=edit Bug 24476: Change CanBookBeRenewed and adjust tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97835&action=edit Bug 24476: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- I rewrote the column to be a positive instead of negative - all patrons are 'opted in' then can prevent autorenewal I altered the update to automatically add this field to the unwanted prefs for opac update and self-reg. I still need to address the column not showing up on patron update requests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97924&action=edit Bug 24476: API Updates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97926&action=edit Bug 24476: Allow patrons to opt out of auto-renewal To test: 1 - Verify on staff side that patron can be edited to opt in our out of auto renewal 2 - Check out some items to a patron opted in to auto renewal 3 - Ensure the items are checked out and set to autorenew 4 - Login on the opac at the patron 5 - Verify items cannot be renewed as scheduled for auto-renewal 6 - On staff side, opt patron out of auto renewal 7 - Verify on opac items are no longer marked for auto renewal 8 - Run the auto renewal cron job, items are not renewed 9 - Set 'no renewal before' to a setting that would prevent renewal 10 - Verify that opting patron in or out of auto renewal changes only the reason items cannot be renewed 11 - Set 'no renewal before' to a setting that would allow for renewal 12 - Verify that opting patron in/out changes their ability to renew 13 - Verify that when opted out cron does not renew 14 - Verify that when opted in the item is auto renewed 15 - Reset the due date, opt out, verify manual renewal succeeds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97928&action=edit Bug 24476: Add boolean for all TINYINT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #25 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- New test plan: 1 - Set loan period and No Renewal Before such than an item is eligable for renewal immediately upon checkout 2 - Check out an item to a patron opted in to auto renewal 3 - Ensure the item is checked out and set to autorenew 4 - Opt patron out of auto-renew 5 - Verify that patron's checkout now shows as available for manual renewal 6 - Make sure OpacRenewalAllowed is set to Allow and "autorenewal" is not in PatronSelfModificationBorrowerUnwantedField 7 - Login on the opac at the patron 8 - Verify checkout shows as available for manual renewal 9 - Verify you can submit change request from OPAC to opt patron in to auto-renew 10 - Find change request on intranet, verify it shows change to autorenew opt-in, accept change request 11 - Reload patron summary on OPAC, verify it now shows checkout is scheduled for auto-renewal 12 - On staff side, opt patron out of auto-renew 13 - Run misc/cronjobs/automatic_renewals.pl, verify item is not renewed 14 - Manually renew item from the intranet 15 - Manually renew item from the OPAC 16 - Opt patron in for auto-renew 17 - Run misc/cronjobs/automatic_renewals.pl, verify item is renewed 18 - Set No Renewal Before value so item is no longer eligable for renewal 19 - Verify intranet and OPAC still show checkout scheduled for auto-renewal 20 - Opt patron out of auto-renew 21 - Verify intranet and OPAC show checkout ineligible for manual renewal due to No Renewal Before 22 - Opt patron in to auto-renew 22 - Add "autorenewal to PatronSelfModificationBorrowerUnwantedField and BorrowerUnwantedField 23 - Confirm patron can no longer be opted out of auto-renew on intranet or OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97924|0 |1 is obsolete| | --- Comment #27 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97998&action=edit Bug 24476: API Updates Signed-off-by: Andrew <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97926|0 |1 is obsolete| | --- Comment #29 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 98000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98000&action=edit Bug 24476: Allow patrons to opt out of auto-renewal To test: 1 - Verify on staff side that patron can be edited to opt in our out of auto renewal 2 - Check out some items to a patron opted in to auto renewal 3 - Ensure the items are checked out and set to autorenew 4 - Login on the opac at the patron 5 - Verify items cannot be renewed as scheduled for auto-renewal 6 - On staff side, opt patron out of auto renewal 7 - Verify on opac items are no longer marked for auto renewal 8 - Run the auto renewal cron job, items are not renewed 9 - Set 'no renewal before' to a setting that would prevent renewal 10 - Verify that opting patron in or out of auto renewal changes only the reason items cannot be renewed 11 - Set 'no renewal before' to a setting that would allow for renewal 12 - Verify that opting patron in/out changes their ability to renew 13 - Verify that when opted out cron does not renew 14 - Verify that when opted in the item is auto renewed 15 - Reset the due date, opt out, verify manual renewal succeeds Signed-off-by: Andrew <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97928|0 |1 is obsolete| | --- Comment #31 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 98002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98002&action=edit Bug 24476: Add boolean for all TINYINT Signed-off-by: Andrew <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Does not apply: CONFLICT (content): Merge conflict in C4/Circulation.pm Any chances to get a more meaningful column's name (and so method). Koha::Patron->autorenewal could be related to renewing a registration. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99794&action=edit Bug 24476: API Updates Signed-off-by: Andrew <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99796&action=edit Bug 24476: Allow patrons to opt out of auto-renewal To test: 1 - Verify on staff side that patron can be edited to opt in our out of auto renewal 2 - Check out some items to a patron opted in to auto renewal 3 - Ensure the items are checked out and set to autorenew 4 - Login on the opac at the patron 5 - Verify items cannot be renewed as scheduled for auto-renewal 6 - On staff side, opt patron out of auto renewal 7 - Verify on opac items are no longer marked for auto renewal 8 - Run the auto renewal cron job, items are not renewed 9 - Set 'no renewal before' to a setting that would prevent renewal 10 - Verify that opting patron in or out of auto renewal changes only the reason items cannot be renewed 11 - Set 'no renewal before' to a setting that would allow for renewal 12 - Verify that opting patron in/out changes their ability to renew 13 - Verify that when opted out cron does not renew 14 - Verify that when opted in the item is auto renewed 15 - Reset the due date, opt out, verify manual renewal succeeds Signed-off-by: Andrew <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99798&action=edit Bug 24476: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99800&action=edit Bug 24476: Allow direct editing of autorenew_checkouts by patron -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99794|0 |1 is obsolete| | --- Comment #42 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 100023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100023&action=edit Bug 24476: API Updates Signed-off-by: Andrew <andrew@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99796|0 |1 is obsolete| | --- Comment #44 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 100025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100025&action=edit Bug 24476: Allow patrons to opt out of auto-renewal To test: 1 - Verify on staff side that patron can be edited to opt in our out of auto renewal 2 - Check out some items to a patron opted in to auto renewal 3 - Ensure the items are checked out and set to autorenew 4 - Login on the opac at the patron 5 - Verify items cannot be renewed as scheduled for auto-renewal 6 - On staff side, opt patron out of auto renewal 7 - Verify on opac items are no longer marked for auto renewal 8 - Run the auto renewal cron job, items are not renewed 9 - Set 'no renewal before' to a setting that would prevent renewal 10 - Verify that opting patron in or out of auto renewal changes only the reason items cannot be renewed 11 - Set 'no renewal before' to a setting that would allow for renewal 12 - Verify that opting patron in/out changes their ability to renew 13 - Verify that when opted out cron does not renew 14 - Verify that when opted in the item is auto renewed 15 - Reset the due date, opt out, verify manual renewal succeeds Signed-off-by: Andrew <andrew@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99798|0 |1 is obsolete| | --- Comment #46 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 100027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100027&action=edit Bug 24476: DO NOT PUSH - Schema Updates Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99800|0 |1 is obsolete| | --- Comment #48 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 100029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100029&action=edit Bug 24476: Allow direct editing of autorenew_checkouts by patron Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am stuck on this one :( The schema update patch would not apply, so I skipped it. Tried running DBIC: Koha::Schema::Result::Zebraqueue->set_primary_key("id"); DBIx::Class::ResultSource::column_info(): No such column autorenew_checkouts at (eval 1297) line 1656 Tried running the updatedatabase script (with and without my patch): $ updatedatabase {UNKNOWN}: DBIx::Class::ResultSource::column_info(): No such column autorenew_checkouts at /home/vagrant/kohaclone/Koha/Schema/Result/Borrower.pm line 1656 Compilation failed in require at /usr/share/perl5/Class/C3/Componentised.pm line 150. at /usr/share/perl5/Class/C3/Componentised.pm line 155 Compilation failed in require at /home/vagrant/kohaclone/Koha/Database.pm line 50. Can you please check and rabase? Also added a follo-up, please have a look. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100022|0 |1 is obsolete| | Attachment #100023|0 |1 is obsolete| | Attachment #100024|0 |1 is obsolete| | Attachment #100025|0 |1 is obsolete| | Attachment #100026|0 |1 is obsolete| | Attachment #100027|0 |1 is obsolete| | Attachment #100028|0 |1 is obsolete| | Attachment #100029|0 |1 is obsolete| | Attachment #101385|0 |1 is obsolete| | --- Comment #51 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 101419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101419&action=edit Bug 24476: Database updates Signed-off-by: Andrew <andrew@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #53 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 101421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101421&action=edit Bug 24476: Change CanBookBeRenewed and adjust tests Signed-off-by: Andrew <andrew@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #55 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 101423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101423&action=edit Bug 24476: Rename autorenewal to autorenew_checkouts Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #57 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 101425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101425&action=edit Bug 24476: (QA follow-up) Standardize on 'auto renew(al)' and improve db update There were several versions: auto renew, auto-renew, autorenew I've decided to use auto renew (from automatic renewal) to keep things a bit more consistent. The DB update was missing AFTER and IGNORE for the sys pref. Also fixed a tiny typo (tp > to) Also changed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #59 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 101427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101427&action=edit Bug 24476: Add boolean for TINYINT Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #61 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101511&action=edit Auto-renew setting in the OPAC I think the placement of the new option in the OPAC is not ideal, it appears in a very prominent spot, even atop of our warnings and other messages. I'd suggest to move it lower, even below the checkouts table maybe, but below the warnings. It will also appear for all patron categories independent of if they are set up to have auto-renewals or not. That's out of the scope of this bug - adding for documentation. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101419|0 |1 is obsolete| | --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101512&action=edit Bug 24476: Database updates Signed-off-by: Andrew <andrew@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101421|0 |1 is obsolete| | --- Comment #64 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101514&action=edit Bug 24476: Change CanBookBeRenewed and adjust tests Signed-off-by: Andrew <andrew@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101423|0 |1 is obsolete| | --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101516&action=edit Bug 24476: Rename autorenewal to autorenew_checkouts Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101425|0 |1 is obsolete| | --- Comment #68 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101518&action=edit Bug 24476: (QA follow-up) Standardize on 'auto renew(al)' and improve db update There were several versions: auto renew, auto-renew, autorenew I've decided to use auto renew (from automatic renewal) to keep things a bit more consistent. The DB update was missing AFTER and IGNORE for the sys pref. Also fixed a tiny typo (tp > to) Also changed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101427|0 |1 is obsolete| | --- Comment #70 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101520&action=edit Bug 24476: Add boolean for TINYINT Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #72 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #61)

Created attachment 101511 [details] Auto-renew setting in the OPAC

I think the placement of the new option in the OPAC is not ideal, it appears in a very prominent spot, even atop of our warnings and other messages. I'd suggest to move it lower, even below the checkouts table maybe, but below the warnings.

It will also appear for all patron categories independent of if they are set up to have auto-renewals or not. That's out of the scope of this bug - adding for documentation.

Added a follow up to move it lower (right above the table still) - RM/Nick, please check! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101521|0 |1 is obsolete| | --- Comment #73 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 101542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101542&action=edit Bug 24476: (QA follow-up) Move new option below warnings and messages in OPAC account This makes it so the new option appears right above the table of checkouts etc. but below any warnings, messages or dialogs. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #75 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Text to go in the|This development will allow |This development will allow release notes|a patron to opt-out of |a patron to opt-out of |auto-renewals - the cron |auto-renewals - the regular |will ignore these checkouts |job will ignore these |and items will be renewable |checkouts and items will |both via the staff |remain renewable both via |interface and OPAC. |the staff interface and | |OPAC. |Patrons will be able to set | |this flag themselves, staff |Patrons will be able |will also be able to. |to set this flag | |themselves, staff will also |There is one new system |be able to. |preference: | |AllowPatronToControlAutoren |**New system |ewal. The options are: |preference**: |allow only staff or allow |`AllowPatronToControlAutore |patrons |newal` defaults to | |disabled. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25029 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 [Bug 25029] AllowPatronToControlAutorenewal needs to have a disable setting -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #76 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- See also bug 24988. But if a patron has no autorenewal, he should not even have this choice. It would be useless and confusing. -- You are receiving this mail because: You are watching all bug changes.