[Bug 24396] New: Suggestions.t is failing with MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396 Bug ID: 24396 Summary: Suggestions.t is failing with MySQL 8 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org # Failed test 'DelSuggestion deletes the correct suggestion' # at t/db_dependent/Suggestions.t line 413. # got: 'my title 3' # expected: 'my deleted title' t/db_dependent/Suggestions.t .. 112/113 # Looks like you failed 1 test of 113. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23996 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 [Bug 23996] MySQL 8 support -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97176&action=edit Bug 24396: Fix Suggestions.t with MySQL 8 # Failed test 'DelSuggestion deletes the correct suggestion' # at t/db_dependent/Suggestions.t line 413. # got: 'my title 3' # expected: 'my deleted title' t/db_dependent/Suggestions.t .. 112/113 # Looks like you failed 1 test of 113. Suggestions were returned in the reverse order. Adding an ORDER BY clause fixes the problem. Test plan: % prove t/db_dependent/Suggestions.t must return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97176|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97181&action=edit Bug 24396: Fix Suggestions.t with MySQL 8 # Failed test 'DelSuggestion deletes the correct suggestion' # at t/db_dependent/Suggestions.t line 413. # got: 'my title 3' # expected: 'my deleted title' t/db_dependent/Suggestions.t .. 112/113 # Looks like you failed 1 test of 113. Suggestions were returned in the reverse order. Adding an ORDER BY clause fixes the problem. Test plan: % prove t/db_dependent/Suggestions.t must return green Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Dang, that could be annoying if we have to add order by statements all over the place to appease mysql8! Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org