[Bug 28292] New: Searching with colon ":" in the end of query gives internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28292 Bug ID: 28292 Summary: Searching with colon ":" in the end of query gives internal server error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylmala@helsinki.fi CC: nugged@gmail.com, stalkernoid@gmail.com Searching (SearchEngine=elasticsearch) the catalogue with anything that ends with just a colon ":" gives internal server error. E.g. searching "hello:" gives this error. The code that was modified in bug 24567 would need to be adapted so that it would strip also the colon when it ends the query and not just when there is whitespace around it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28292 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28292 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28292 Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28292 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28292 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 121273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121273&action=edit Bug 28292: strip the colon when it ends the query This patch adds additional regexp that strips the colon when it ends the query to avoid the internal server error. Also this patch adds new tests that check if colon gets removed from the very beginning and the very end of the query. To reproduce: 1) Enable ES and try to search "test:", which should give the internal server error. 2) Apply the patch, perform the same search again. Make sure that it doesn't gives that same error. 3) Additionally run t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t test and ensure that all tests are successful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28292 --- Comment #2 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Searching with "host-item:spr:n" even with this patch gives still error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28292 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28316 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28292 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #3 from Peter Vashchuk <stalkernoid@gmail.com> --- *** This bug has been marked as a duplicate of bug 28316 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org