[Bug 10027] New: Fine details not showing when printing a fine
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Bug ID: 10027 Summary: Fine details not showing when printing a fine Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle.m.hall@gmail.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Previously printing a fine invoice would result in a page with both the single item charge and the total outstanding dues. Right now only the total outstanding is printed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17348&action=edit Bug 10027 - Fine details not showing when printing a fine Previously printing a fine invoice would result in a page with both the single item charge and the total outstanding dues. Right now only the total outstanding is printed. Test Plan: 1) Print a fine, note the fine doesn't show, only the total 2) Apply patch 3) Print a fine, not the fine does show -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17349&action=edit Bug 10027 - Fine details not showing when printing a fine - Tidy members/printinvoice.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle.m.hall@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17348|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17354&action=edit Bug 10027 - Fine details not showing when printing a fine Previously printing a fine invoice would result in a page with both the single item charge and the total outstanding dues. Right now only the total outstanding is printed. Test Plan: 1) Print a fine, note the fine doesn't show, only the total 2) Apply patch 3) Print a fine, not the fine does show Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17349|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17355&action=edit Bug 10027 - Fine details not showing when printing a fine - Tidy members/printinvoice.pl Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de Severity|minor |normal --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is better, but not quite there yet. I have checked the print for a partially paid fine and it still shows the full amount instead of the amount left to pay. Upping bug severity a bit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10708 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20812&action=edit Bug 10027 - Fine details not showing when printing a fine - QA Followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this works as intended now, but it would be good if all fine lines showed not just the one you clicked - that would make more sense of the total given. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17354|0 |1 is obsolete| | Attachment #17355|0 |1 is obsolete| | Attachment #20812|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20851&action=edit [PASSED QA] Bug 10027 - Fine details not showing when printing a fine Previously printing a fine invoice would result in a page with both the single item charge and the total outstanding dues. Right now only the total outstanding is printed. Test Plan: 1) Print a fine, note the fine doesn't show, only the total 2) Apply patch 3) Print a fine, not the fine does show Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Comments on third patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20852&action=edit [PASSED QA] Bug 10027 - Fine details not showing when printing a fine - Tidy members/printinvoice.pl Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20853&action=edit [PASSED QA] Bug 10027 - Fine details not showing when printing a fine - QA Followup Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Checked invoice is correctly printed for - partially paid fines - paid fines - unpaid fines -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11408 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org