[Bug 30319] New: Patron self-modification values not retained if field blocked in PatronSelfRegistrationBorrowerUnwantedField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 Bug ID: 30319 Summary: Patron self-modification values not retained if field blocked in PatronSelfRegistrationBorrowerUnwantedField Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When a field is hidden for self-registration, Koha is mistakenly discarding values for that field in self-modification. Somehow these two sysprefs are not being enforced distinctly. To test: 1 - turn on OPACPatronDetails 2 - confirm PatronSelfModificationBorrowerUnwantedField is blank, all fields allowed 3 - set PatronSelfRegistrationBorrowerUnwantedField to hide Title 4 - log into the opac, go to self mod (/cgi-bin/koha/opac-memberentry.pl), set a title (it is not hidden, which is correct), and save your updates 5 - go to the patron modification page in the staff interface (/cgi-bin/koha/members/members-update.pl), confirm your modification request is there but shows no changes 6 - update PatronSelfRegistrationBorrowerUnwantedField to allow title 7 - repeat step 4 8 - your new modification request shows a change to title -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just ran into this and only found the duplicate after writing up my test plan and everything... so adding it here instead: If a field is set as Unwanted for the self registration form, it will not be reported to the library if an address change is requested by a registered user from their account. To test: - BorrowerUnwantedField: Set a field of your choice to "unwanted". Example: sex - Make sure same field is visible in: PatronSelfModificationBorrowerUnwantedField PatronSelfRegistrationBorrowerUnwantedField - Log into your OPAC account - Request a change of said field - Check the change request in the staff interface: field will be missing - PatronSelfRegistrationBorrowerUnwantedField: Update to make field visible - Request another change from the OPAC - Verify field is now visible in the change request The PatronSelfRegistrationBorrowerUnwantedField should not influence the change requests, only PatronSelfModificationBorrowerUnwantedField should. I am updating the severity as this affects the library - user communication and is basically causing an unnoticeable data loss. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 Jennifer Marlatt <jennifer.marlatt@coronaca.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jennifer.marlatt@coronaca.g | |ov --- Comment #2 from Jennifer Marlatt <jennifer.marlatt@coronaca.gov> --- This is causing problems at our library especially for patrons who rely on emails to alert them to due dates, renewals, etc. Patrons are attempting to add/update their email addresses through the OPAC. The request to update a patron record appears in the staff interface, but the data is not transferred with the request. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Patch complexity|--- |Trivial patch Comma delimited| |Open Fifth list of Sponsors| | Assignee|oleonard@myacpl.org |olivia.reynolds@openfifth.c | |o.uk Status|NEW |Needs Signoff --- Comment #3 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Apologies if I'm stepping on your toes, Owen; I didn't see that this was assigned before I'd written the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 --- Comment #4 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203281&action=edit Bug 30319: Remove appropriate hidden fields on self-modification Previously, the system preference PatronSelfRegistrationBorrowerUnwantedField was used to remove hidden fields regardless of whether the operation was self-registration or self-modification. This patch uses the appropriate set of hidden fields depending on the current operation (create/update). Test plan: 1. Set OPACPatronDetails to "Allow". 2. Ensure PatronSelfModificationBorrowerUnwantedField is empty. 3. Set PatronSelfRegistrationBorrowerUnwantedField to exclude Title (towards the bottom right of the modal). 4. Log into the OPAC, and navigate to Your account > Personal details. 5. Change your title and submit the request. 6. Verify you see the notice "No changes were made." at the top of the page. 7. Apply patch. 8. Change your title again and submit the request. 9. Verify the request is submitted successfully. 10. Return to the personal details screen, but don't submit. 11. Set PatronSelfModificationBorrowerUnwantedField to exclude Title. 12. On the preloaded personal details screen, update the title and submit. 13. Verify you see the notice "No changes were made." at the top of the page. Sponsored-by: Open Fifth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203281|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 203325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203325&action=edit Bug 30319: Remove appropriate hidden fields on self-modification Previously, the system preference PatronSelfRegistrationBorrowerUnwantedField was used to remove hidden fields regardless of whether the operation was self-registration or self-modification. This patch uses the appropriate set of hidden fields depending on the current operation (create/update). Test plan: 1. Set OPACPatronDetails to "Allow". 2. Ensure PatronSelfModificationBorrowerUnwantedField is empty. 3. Set PatronSelfRegistrationBorrowerUnwantedField to exclude Title (towards the bottom right of the modal). 4. Log into the OPAC, and navigate to Your account > Personal details. 5. Change your title and submit the request. 6. Verify you see the notice "No changes were made." at the top of the page. 7. Apply patch. 8. Change your title again and submit the request. 9. Verify the request is submitted successfully. 10. Return to the personal details screen, but don't submit. 11. Set PatronSelfModificationBorrowerUnwantedField to exclude Title. 12. On the preloaded personal details screen, update the title and submit. 13. Verify you see the notice "No changes were made." at the top of the page. Sponsored-by: Open Fifth Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Olivia, since you've introduced a 2nd argument for ParseCgiForBorrower() they should be passed in as hashref with named arguments. PERL23: Single argument for methods and functions Methods and functions should take a single argument: either a database ID, arrayref, or hashref with named arguments. https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL16:_Hashrefs_shou... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Thanks for catching that, Lucas. I've updated the signature to match the guideline. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203325|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 --- Comment #8 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204500&action=edit Bug 30319: Remove appropriate hidden fields on self-modification Previously, the system preference PatronSelfRegistrationBorrowerUnwantedField was used to remove hidden fields regardless of whether the operation was self-registration or self-modification. This patch uses the appropriate set of hidden fields depending on the current operation (create/update). Test plan: 1. Set OPACPatronDetails to "Allow". 2. Ensure PatronSelfModificationBorrowerUnwantedField is empty. 3. Set PatronSelfRegistrationBorrowerUnwantedField to exclude Title (towards the bottom right of the modal). 4. Log into the OPAC, and navigate to Your account > Personal details. 5. Change your title and submit the request. 6. Verify you see the notice "No changes were made." at the top of the page. 7. Apply patch. 8. Change your title again and submit the request. 9. Verify the request is submitted successfully. 10. Return to the personal details screen, but don't submit. 11. Set PatronSelfModificationBorrowerUnwantedField to exclude Title. 12. On the preloaded personal details screen, update the title and submit. 13. Verify you see the notice "No changes were made." at the top of the page. Sponsored-by: Open Fifth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204500|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 204632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204632&action=edit Bug 30319: Remove appropriate hidden fields on self-modification Previously, the system preference PatronSelfRegistrationBorrowerUnwantedField was used to remove hidden fields regardless of whether the operation was self-registration or self-modification. This patch uses the appropriate set of hidden fields depending on the current operation (create/update). Test plan: 1. Set OPACPatronDetails to "Allow". 2. Ensure PatronSelfModificationBorrowerUnwantedField is empty. 3. Set PatronSelfRegistrationBorrowerUnwantedField to exclude Title (towards the bottom right of the modal). 4. Log into the OPAC, and navigate to Your account > Personal details. 5. Change your title and submit the request. 6. Verify you see the notice "No changes were made." at the top of the page. 7. Apply patch. 8. Change your title again and submit the request. 9. Verify the request is submitted successfully. 10. Return to the personal details screen, but don't submit. 11. Set PatronSelfModificationBorrowerUnwantedField to exclude Title. 12. On the preloaded personal details screen, update the title and submit. 13. Verify you see the notice "No changes were made." at the top of the page. Sponsored-by: Open Fifth Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204632|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 206006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206006&action=edit Bug 30319: Remove appropriate hidden fields on self-modification Previously, the system preference PatronSelfRegistrationBorrowerUnwantedField was used to remove hidden fields regardless of whether the operation was self-registration or self-modification. This patch uses the appropriate set of hidden fields depending on the current operation (create/update). Test plan: 1. Set OPACPatronDetails to "Allow". 2. Ensure PatronSelfModificationBorrowerUnwantedField is empty. 3. Set PatronSelfRegistrationBorrowerUnwantedField to exclude Title (towards the bottom right of the modal). 4. Log into the OPAC, and navigate to Your account > Personal details. 5. Change your title and submit the request. 6. Verify you see the notice "No changes were made." at the top of the page. 7. Apply patch. 8. Change your title again and submit the request. 9. Verify the request is submitted successfully. 10. Return to the personal details screen, but don't submit. 11. Set PatronSelfModificationBorrowerUnwantedField to exclude Title. 12. On the preloaded personal details screen, update the title and submit. 13. Verify you see the notice "No changes were made." at the top of the page. Sponsored-by: Open Fifth Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Fixes a problem in patron release notes| |self-modification where the | |fields in | |PatronSelfRegistrationBorro | |werUnwantedField were being | |discarded even when they | |were visible, and editable, | |on the patron | |self-modification page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 --- Comment #11 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.05 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org