[Bug 7250] New: stage_bilbios_file.pl is missing options for encodings, wrongly passing the MARC flavour instead
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7250 Bug #: 7250 Summary: stage_bilbios_file.pl is missing options for encodings, wrongly passing the MARC flavour instead Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: major Priority: P1 - high Component: MARC Bibliographic record staging/import AssignedTo: katrin.fischer@bsz-bw.de ReportedBy: katrin.fischer@bsz-bw.de QAContact: ian.walls@bywatersolutions.com The script stage_bilbios_file.pl is passing the MARC flavor instead of the encoding. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7250 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|stage_bilbios_file.pl is |stage_biblios_file.pl is |missing options for |missing options for |encodings, wrongly passing |encodings, wrongly passing |the MARC flavour instead |the MARC flavour instead -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7250 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-21 07:04:04 UTC --- Created attachment 6361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6361 Bug 7250: stage_biblios_file.pl is missing options for encoding - adds command line options for encoding, defaulting to utf8 - options match options availablen in the stage marc records form of the staff interface - activates warnings - adds copyright statement To test: Import records with diacritics using the stage_biblios_file.pl Records can be imported into the catalog using the staff interface or the commit_biblios_file.pl script. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7250 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7250 --- Comment #2 from Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> 2011-11-22 16:01:18 UTC --- Created attachment 6374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6374 Successfully tested with default encoding utf8. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7250 Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ulrich.kleiber@bsz-bw.de Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7250 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6361|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7250 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-22 17:01:43 UTC --- Fixes an issue with the usage of BatchStageMarcRecords, as well as adds copyright statements, documentation, and cleans up spacing. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7250 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-24 14:14:05 UTC --- I can't reproduce the problem or find a difference with and without the patch. As the patch has been tested & signed-off by the same company, I really want to double check. Katrin/Ulrich = could you attach an example iso2709 file please ? (note i'm UNIMARC, maybe the problem is MARC21 related) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7250 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-24 14:32:55 UTC --- Created attachment 6390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6390 test records Without the patch the sub is called with wrong parameters - marcflavour instead of encoding. Without patch the umlauts in the attached marc file should be broken after import. stage_biblios_file.pl is to be run from command line. Documentation was updated to reflect the change. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7250 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-11-24 15:12:20 UTC --- I can confirm both the bug and the patch, at least for my test data. Good catch, Katrin! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7250 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-25 13:29:10 UTC --- patch pushed please test NOTE: just in case you miss the information like I did: it worked through the staff interface, this fix is just for staging records through the command line script (misc/stage_biblios_file.pl) Test plan: ./stage_biblios_file.pl --encoding ISO_5426 --file ../temp/panier.iso2709 --comment command_line ... staging MARC records -- please wait ... finished staging MARC records MARC record staging report ------------------------------------ Input file: ../temp/panier.iso2709 Number of input bibs: 4 Number of valid bibs: 4 Number of invalid bibs: 0 Incoming bibs not matched against existing bibs (--match-bibs option not supplied) No items parsed (--add-items option not supplied) => checked that diacritics were OK on the staff interface, they were -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7250 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org