[Bug 29341] New: If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Bug ID: 29341 Summary: If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: koha@univ-lyon3.fr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When you activate the pseudonymization process and the system preference OpacRenewalBranch = opacrenew, there's an "internal server error" when patrons renew there loans at the OPAC. In logs, you can find : DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`pseudonymized_trans actions`, CONSTRAINT `pseudonymized_transactions_borrowers_ibfk_3` FOREIGN KEY (`transaction_branchcode`) REFERENCES `branches` (`branchcode`)) [for Stat ement "INSERT INTO `pseudonymized_transactions` ( `branchcode`, `categorycode`, `ccode`, `dateenrolled`, `datetime`, `has_cardnumber`, `hashed_borrowernu mber`, `holdingbranch`, `homebranch`, `itemcallnumber`, `itemnumber`, `itemtype`, `location`, `sort1`, `sort2`, `transaction_branchcode`, `transaction_ty pe`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='MAN', 1='ETUL3', 2=undef, 3='2021-01-11', 4='2021-10-27 06:28:28' , 5=1, 6="$xxxxxxxxxxxxxxxxxxxxxxxxx", 7='MAN', 8='MAN', 9='345 PIN', 10="728028", 11='PRET', 12='MANDG3', 13='ELdro', 14='3101000IL', 15='OPACRenew', 16='renew'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, koha@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127034&action=edit Bug 29341: Prevent OPAC renew to crash if Pseudonymization is set If OpacRenewalBranch = opacrenew then we try to insert a wrong branchcode into pseudonymized_transactions.transaction_branchcode We are trying to insert 'OPACRenew' Test plan: Setup Pseudonymization Set OpacRenewalBranch = opacrenew Renew an item from the OPAC Notice that pseudonymized_transactions.transaction_branchcode is set to NULL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Depends on| |24151 Keywords| |rel_20_11_candidate, | |rel_21_05_candidate, | |rel_21_11_candidate Version|20.11 |unspecified Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 [Bug 24151] Add a pseudonymization process for patrons and transactions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127034|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 127078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127078&action=edit Bug 29341: Prevent OPAC renew to crash if Pseudonymization is set If OpacRenewalBranch = opacrenew then we try to insert a wrong branchcode into pseudonymized_transactions.transaction_branchcode We are trying to insert 'OPACRenew' Test plan: Setup Pseudonymization Set OpacRenewalBranch = opacrenew Renew an item from the OPAC Notice that pseudonymized_transactions.transaction_branchcode is set to NULL Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (koha-testing-docker): - To set up Pseudonymization: . generate a bcrypt_settings code from the command line: htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' . add entry to <bcrypt_settings>generated code</bcrypt_settings> in koha-conf.xml somewhere within the <config></config> (this setting was not in the koha-conf.xml file and I added before the closing </config>) . example: <bcrypt_settings>$2a$10$Jpln8Gg9Towzux6D4iZVaucXtxum.hf.lnbHIw1RXxZSzy9.mLjo6</bcrypt_settings> . flush_memcached and restart_all . You can then enable the Pseudonymization system preference and set values for PseudonymizationPatronFields and PseudonymizationTransactionFields (I selected all) . I initially had trouble generating the error, but was probably related to refreshing the browser/cached data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #4 from David Nind <david@davidnind.com> --- More testing notes (koha-tetsing-docker): - Database query: . access the database: koha-mysql kohadev . select * from pseudonymized_transactions; - View the log where the error appears: vi /var/log/koha/kohadev/plack-opac-error.log - Run tests before and after - they should pass: . prove t/db_dependent/Koha/Pseudonymization.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 pierre.genty@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |joonas.kylmala@iki.fi --- Comment #5 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- This messes up the statistic table, people are expecting there to be 'OPACRenew' as the value and not NULL. If you don't want to make this a huge patch I would suggest to just drop the foreign key for the 'transaction_branchcode' in pseudonymized_transactions table. I also assume people don't want there to be foreign key relation in order to be able to delete branches and still keep the stats in place. However, if you want to go the original patch's route, which I think not, then the change should be done in Koha::Item::renewal_branchcode instead. The syspref documentation and database upgrade would need to be provided as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127213&action=edit Bug 29341: Don't modify the branchcode for stats -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Joonas Kylmälä from comment #5)
This messes up the statistic table, people are expecting there to be 'OPACRenew' as the value and not NULL. If you don't want to make this a huge patch I would suggest to just drop the foreign key for the 'transaction_branchcode' in pseudonymized_transactions table. I also assume people don't want there to be foreign key relation in order to be able to delete branches and still keep the stats in place.
However, if you want to go the original patch's route, which I think not, then the change should be done in Koha::Item::renewal_branchcode instead. The syspref documentation and database upgrade would need to be provided as well.
Oops, my bad! Thanks! I think we want to keep the FK, this patch (can be squashed) is modifying the branchcode AFTER the stat entry has been created. Sonia, Lyon 3, can you confirm the expected behaviour please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Maybe those people using OPACRenewalBranch, should add that branchcode too in their system ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127078|0 |1 is obsolete| | Attachment #127213|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127350&action=edit Bug 29341: Prevent OPAC renew to crash if Pseudonymization is set If OpacRenewalBranch = opacrenew then we try to insert a wrong branchcode into pseudonymized_transactions.transaction_branchcode We are trying to insert 'OPACRenew' Test plan: Setup Pseudonymization Set OpacRenewalBranch = opacrenew Renew an item from the OPAC Notice that pseudonymized_transactions.transaction_branchcode is set to NULL Signed-off-by: David Nind <david@davidnind.com> [SQUASHED] Bug 29341: Don't modify the branchcode for stats Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Amended test for 'as is' and a reference to OPACRenew in test script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- There is still time for another QA stamp. But if there would not be, I am fine with passing QA too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #12 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Hi, I haven't tested it yet because I'm still fighting with my kohadevbox. But, in theory, It's a pity to store NULL value in pseudonymized_transactions instead of a value that gives us the information the it's a renew done on the OPAC. It's not possible to store the same value that the one in the statistics table? Sonia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Koha Team University Lyon 3 from comment #12)
Hi, I haven't tested it yet because I'm still fighting with my kohadevbox.
But, in theory, It's a pity to store NULL value in pseudonymized_transactions instead of a value that gives us the information the it's a renew done on the OPAC. It's not possible to store the same value that the one in the statistics table?
Sonia
I wasn't aware of this behaviour, but it does not sound correct. "Branch" must contain the branchcode, and be a foreign key. If we want to keep this additional information it should be stored into a separate column. Note that Marcel's workaround should work, if you create a branch with branchcode="OPACRenew" that should be inserted instead of NULL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- (In reply to Jonathan Druart from comment #13)
I wasn't aware of this behaviour, but it does not sound correct. "Branch" must contain the branchcode, and be a foreign key. If we want to keep this additional information it should be stored into a separate column.
The change should be then done for the statistics table as well, in this same bug report, since there is only one syspref, OpacRenewalBranch, for both the tables (statistics and pseudonymized_transactions). In addition to that the OpacRenewalBranch syspref needs to be updated to described that if opacrenewal is used then it is stored into another column. Another thing we might wanna fix here is that if the user actually selects "NULL" as the OpacRenewalBranch syspref value then we store empty string and not null really (I wonder if this NULL/empty string is actually a regression?).
Note that Marcel's workaround should work, if you create a branch with branchcode="OPACRenew" that should be inserted instead of NULL.
Not suitable for production. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree that knowing if a renewal was done from the OPAC is important and we need to maintain that information in some way. We could argue that in statistics the column doesn't need to be an FK, as you might want to keep statistics for deleted branches still. Same for itemtypes, categories etc. I think we could treat statistics like a log that is not altered by changes happening around it where we can avoid it. Adding a branch for that purpose is no solution (as Joonas already said :) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I am getting the feeling here that this fix is blamed for the weird OpacRenewalBranch stuff already in Koha. Obviously, this should have been developed differently. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I disagree with removing the FK. Statistics should not keep a wrong/obsolete code, they are kept (ON DELETE SET NULL) however. There are different things, and different fixes: Statistics table is missing the FK (or does not have it on purpose), and the OpacRenewalBranch behaviour is badly designed. I don't think removing the FK is going into the correct direction, adding a separate column is definitely out of the scope here. We need a quick bugfix for the ugly 500 (that is blocker), and this patch is the way to go in my opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #15)
Adding a branch for that purpose is no solution (as Joonas already said :) )
I called it a "workaround", it's the only way to remove the 500 in stable branches right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #18)
(In reply to Katrin Fischer from comment #15)
Adding a branch for that purpose is no solution (as Joonas already said :) )
I called it a "workaround", it's the only way to remove the 500 in stable branches right now.
I would call it a legitimate workaround given the lack of quality of this so-called feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Sonia Bouis <sonia.bouis@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sonia.bouis@univ-lyon3.fr --- Comment #20 from Sonia Bouis <sonia.bouis@univ-lyon3.fr> --- Hello, I'm OK that this is not statisfying but unless someone has a better way to fix it rapidly, it's perhaps better to fix it than to keep an internal servor error ? I'm not sur to really understand the technical part with the foreign key. But, as Katrin said, in a library, the branches can change (closure, opening of a new building) and we may want to delete the branch but we need to keep the statistics and the pseudonymized information. It would be nice if this BZ doesn't stay too long in discussion. Sonia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #17)
I disagree with removing the FK. Statistics should not keep a wrong/obsolete code, they are kept (ON DELETE SET NULL) however.
There are different things, and different fixes: Statistics table is missing the FK (or does not have it on purpose), and the OpacRenewalBranch behaviour is badly designed.
I don't think removing the FK is going into the correct direction, adding a separate column is definitely out of the scope here. We need a quick bugfix for the ugly 500 (that is blocker), and this patch is the way to go in my opinion.
I disagree here, I think we should remove the FK to branches as the quick fix. While we may have opinions about how that feature was implemented, it has been implemented. Statistics is a ledger of transactions - foreign keys are going to remove/nullify data after the fact and I think that would be incorrect. If Pseudonymized transactions are meant to mirror the statistics table then I feel we should remove the FK for now, and fix the larger issue with OPACRenew etc on a new bug. Adding a new branch is going to add the branch in many places throughout Koha and will impact workflows -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- If you delete the library then recreate another one with the same branchcode, do we want the stats to be linked to the new library? I don't think so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Sonia confirmed me that it's ok to keep the branchcode and so remove the FK. I personally still don't think it's a good idea, but I understand the use case. This is also a bad use case: Create branch CPL, for testing purpose (hey you just installed the software and want to try it) Do some stuffs, it will create stats entries Remove CPL to start from scratch and clean state Reuse CPL as branchcode Stats are accumulating using the test data I will provide an alternate patch tomorrow if nobody beats me to it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127727&action=edit Bug 29341: Remove foreign keys on pseudonymized_transactions Behave like the statistics table and don't remove the code even if the branch or patron's category is removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127350|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #23)
Sonia confirmed me that it's ok to keep the branchcode and so remove the FK.
I personally still don't think it's a good idea, but I understand the use case.
This is also a bad use case: Create branch CPL, for testing purpose (hey you just installed the software and want to try it) Do some stuffs, it will create stats entries Remove CPL to start from scratch and clean state Reuse CPL as branchcode Stats are accumulating using the test data
I will provide an alternate patch tomorrow if nobody beats me to it.
I feel like most people might have a test system or would be able to differentiate by timestamp in that case. My feeling is, that this would not be a big issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #21)
I disagree here, I think we should remove the FK to branches as the quick fix.
While we may have opinions about how that feature was implemented, it has been implemented. Statistics is a ledger of transactions - foreign keys are going to remove/nullify data after the fact and I think that would be incorrect.
If Pseudonymized transactions are meant to mirror the statistics table then I feel we should remove the FK for now, and fix the larger issue with OPACRenew etc on a new bug.
Adding a new branch is going to add the branch in many places throughout Koha and will impact workflows
Fair enough -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- KEY `pseudonymized_transactions_ibfk_1` (`categorycode`), KEY `pseudonymized_transactions_borrowers_ibfk_2` (`branchcode`), KEY `pseudonymized_transactions_borrowers_ibfk_3` (`transaction_branchcode`) When removing the FKs, the question is: Do we still need those indexes? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127727|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127848&action=edit Bug 29341: Remove foreign keys on pseudonymized_transactions Behave like the statistics table and don't remove the code even if the branch or patron's category is removed. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- OK We took the other turn :) Apart from comment27 no further questions. Trivial enough to combine SO and QA at this late time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #32 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Marcel de Rooy from comment #27)
KEY `pseudonymized_transactions_ibfk_1` (`categorycode`), KEY `pseudonymized_transactions_borrowers_ibfk_2` (`branchcode`), KEY `pseudonymized_transactions_borrowers_ibfk_3` (`transaction_branchcode`)
When removing the FKs, the question is: Do we still need those indexes?
I bet yes, for SQL join performance -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #33 from Fridolin Somers <fridolin.somers@biblibre.com> --- /!\ Arg, Koha.pm change is missing in 21.05.x : It is still in "21.05.05.003" when updatedatabase is "21.05.05.005" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #34 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #35 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 20.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_candidate, | |rel_21_05_candidate, | |rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Bug 29341 depends on bug 24151, which changed state. Bug 24151 Summary: Add a pseudonymization process for patrons and transactions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Bug 29341 depends on bug 24151, which changed state. Bug 24151 Summary: Add a pseudonymization process for patrons and transactions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org