http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #22 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-02-19 23:22:58 UTC ---

=== point 1 (and a question) === (In reply to comment #3)

...

More comprehensive description of rule selection: * Rules are chosen in order of preference borrower category, item type, branch * If value for certain rule is null, next rule in order is chosen * 0 is treated as null

does it mean that, if I set the general rule to 7 documents for 21 days, and set a rule for CHILDREN / DVD to 0 it will be treated as NULL and the general rule will be applied ? If yes, it's a big change in the behaviour, and, imo, a big mistake = libraries want to define such rules. 0 should mean 0. I agree we should handle "empty" as "rule unused at this level"

I agree, it is just how it was before, so I did not want to change that. Please advise best course of action.

=== point 4 === small point : SQL must have reserved words in capital so ." ORDER BY branchcode DESC, categorycode DESC, itemtype DESC"; and not ." order by branchcode desc, categorycode desc, itemtype desc";

Probably used some of the existing code, but will change that, it's not a big issue. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.