http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10949 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10949 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10949 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21451|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 21453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21453&action=edit [SIGNED-OFF] Bug 10949: restore ability to successfully print hold slips This fixes a regression introduced by the patch for bug 9394 -- when printing a hold slip using the 'print and confirm' button, the slip would contain only the text 'reserve not found', not a full hold slip. This patch also adds a regression test. To test: [1] Check in an item that would fill a hold. Use the 'print and confirm button' to confirm the hold. [2] The printout will only contain text to the effect of 'reserve not found'. [3] Apply the patch. [4] Repeat step 1. This time, a full hold slip should be printed. [5] Verify that prove -v t/db_dependent/Reserves.t passes. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10949 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21453|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21530&action=edit [PASSED QA] Bug 10949: restore ability to successfully print hold slips This fixes a regression introduced by the patch for bug 9394 -- when printing a hold slip using the 'print and confirm' button, the slip would contain only the text 'reserve not found', not a full hold slip. This patch also adds a regression test. To test: [1] Check in an item that would fill a hold. Use the 'print and confirm button' to confirm the hold. [2] The printout will only contain text to the effect of 'reserve not found'. [3] Apply the patch. [4] Repeat step 1. This time, a full hold slip should be printed. [5] Verify that prove -v t/db_dependent/Reserves.t passes. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Pass all tests, new and old, and QA script. Verified wrong and corrected behaviour. Note: Sometimes there will not be the message 'reserve not found' showing up, but hold information for a different record. This happens when there exists a reserve_id with the borrowernumber of the patron in question in your database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10949 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |9394 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.