https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21885 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pasi.kallinen@joensuu.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed <pasi.kallinen@joensuu.fi> --- Created attachment 82659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82659&action=edit Calendar to-date starts before end-date When adding new holidays to the calendar, you pick the start date, and then the end date, but the end date calendar will start from current date, not from the picked start date. Sometimes this means many extra clicks to pick an end date. Make the end date calendar start from the beginning date by default. Test plan: 1) Go to the tools -> calendar 2) Pick a start date somewhere in the future, and then open the end date calendar. Notice how it starts before the start date of the date range. 3) Apply patch. 4) Pick a start date in the future. The end date calendar should automatically default to the same date. 5) Change the start date a day backwards, note how the end date does not change. 6) Change the start date after the end date, note how the end date adjusts, so it is not in the past. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21885 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21885 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- A nice follow-up to this would be to disable dates before the chosen start date. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21885 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82835|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84758&action=edit Bug 21885: Calendar to-date starts before end-date When adding new holidays to the calendar, you pick the start date, and then the end date, but the end date calendar will start from current date, not from the picked start date. Sometimes this means many extra clicks to pick an end date. Make the end date calendar start from the beginning date by default. Test plan: 1) Go to the tools -> calendar 2) Pick a start date somewhere in the future, and then open the end date calendar. Notice how it starts before the start date of the date range. 3) Apply patch. 4) Pick a start date in the future. The end date calendar should automatically default to the same date. 5) Change the start date a day backwards, note how the end date does not change. 6) Change the start date after the end date, note how the end date adjusts, so it is not in the past. Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21885 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Calendar to-date starts |Improve date selection on |before end-date |calendar for selecting the | |end date on a range Blocks|22272 | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is certainly a nice little improvement. I agree with Owen that greying out dates would be another nice addition, but I think we can handle that on a separate bug report: Bug 22272 - Calendar: When entering date ranges grey out dates in the past from the start date I've rephrased the title a bit as this does a bit more than prevent to before start... but maybe it can still be improved. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22272 [Bug 22272] Calendar: When entering date ranges grey out dates in the past from the start date -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21885 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21885 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.