[Bug 26808] New: Reduce number of times a user has to press tab to confirm a check out when there is a condition that the user may want to overide, and is circulating without a mouse (Accessibility issue)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 Bug ID: 26808 Summary: Reduce number of times a user has to press tab to confirm a check out when there is a condition that the user may want to overide, and is circulating without a mouse (Accessibility issue) Change sponsored?: Seeking developer Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P3 Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kathryn@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Reduce number of times a user has to press tab to confirm a check out when there is a condition that the user may want to over-ride, and is circulating without a mouse (Accessibility issue) Test using the keyboard only. Steps to reproduce: * Set up a condition that you may want to over-ride at the point of check out, e.g. check the item out to another library member * Type a borrower name * Press enter * Type a barcode number * Press enter * Tab 13 times (if no circ rules set), 15 times if the item is checked out to another member) * Press enter. It would be much better if after typing the barcode number the next three tabs are the buttons in the yellow box. 1 tab for yes 2 tabs for no 3 tabs for cancel (if relevant). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Reduce number of times a |Improve tab key access to |user has to press tab to |circulation confirmation |confirm a check out when |dialog |there is a condition that | |the user may want to | |overide, and is circulating | |without a mouse | |(Accessibility issue) | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Templates Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Version|20.05 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112581&action=edit Bug 26808: Improve tab key access to circulation confirmation dialog This patch modifies the checkout template so that the checkout confirmation message can receive focus, improving tab access to the form buttons in the dialog. A "-1" value "tabindex" attribute makes the dialog focusable, and a "focus" class automatically triggers focus. The focus and tabindex are only set when the template logic says that the alert will require confirmation. To test, apply the patch and open a patron's account for checkout. - Submit a barcode for checkout which will trigger a confirmation dialog. For instance: - A barcode they already have checked out - A barcode which is checked out to another patron - When the page reloads you should see an alert-style dialog, "Please confirm checkout." The browser should show a focus outline around the dialog. - Hitting the tab key should move the focus to the first focusable element inside the dialog. If there is a link in the text, this may be the first element. If not the confirmation button should be the next tabbable element. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112581|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 112765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112765&action=edit Bug 26808: Improve tab key access to circulation confirmation dialog This patch modifies the checkout template so that the checkout confirmation message can receive focus, improving tab access to the form buttons in the dialog. A "-1" value "tabindex" attribute makes the dialog focusable, and a "focus" class automatically triggers focus. The focus and tabindex are only set when the template logic says that the alert will require confirmation. To test, apply the patch and open a patron's account for checkout. - Submit a barcode for checkout which will trigger a confirmation dialog. For instance: - A barcode they already have checked out - A barcode which is checked out to another patron - When the page reloads you should see an alert-style dialog, "Please confirm checkout." The browser should show a focus outline around the dialog. - Hitting the tab key should move the focus to the first focusable element inside the dialog. If there is a link in the text, this may be the first element. If not the confirmation button should be the next tabbable element. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112765|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112772&action=edit Bug 26808: Improve tab key access to circulation confirmation dialog This patch modifies the checkout template so that the checkout confirmation message can receive focus, improving tab access to the form buttons in the dialog. A "-1" value "tabindex" attribute makes the dialog focusable, and a "focus" class automatically triggers focus. The focus and tabindex are only set when the template logic says that the alert will require confirmation. To test, apply the patch and open a patron's account for checkout. - Submit a barcode for checkout which will trigger a confirmation dialog. For instance: - A barcode they already have checked out - A barcode which is checked out to another patron - When the page reloads you should see an alert-style dialog, "Please confirm checkout." The browser should show a focus outline around the dialog. - Hitting the tab key should move the focus to the first focusable element inside the dialog. If there is a link in the text, this may be the first element. If not the confirmation button should be the next tabbable element. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- does not apply clean to 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org