[Bug 18150] New: CanItemBeReserved don't work with ( IndependentBranches AND ! canreservefromotherbranches)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Bug ID: 18150 Summary: CanItemBeReserved don't work with (IndependentBranches AND ! canreservefromotherbranches) Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P4 Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nicolas.legrand@bulac.fr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If you have independent branches and forbid holds between branches you won't be able to place a hold on an item you should be able to reserve. This is because it tests the item homebranch as if the $item variable was a hash whereas, if it did began as such, by the middle of the function it is replaced by a Koha object. So $item->{homebranch} should be $item->homebranch. Patch coming soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|CanItemBeReserved don't |CanItemBeReserved doesn't |work with |work with |(IndependentBranches AND ! |(IndependentBranches AND ! |canreservefromotherbranches |canreservefromotherbranches |) |) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 --- Comment #1 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Also affects 16.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |nicolas.legrand@bulac.fr |ity.org | Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 --- Comment #2 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 60542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60542&action=edit Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND ! canreservefromotherbranches) The variable $item used to be a hash, but at the end of the function, it's a Koha object. As $item->{homebranch} doesn't yield anything and should be $item->homebranch. It prevents people using different branches without holds between branches from placing a hold on an item they should be able to place hold on. Test plan: 1. Before patch a. with IndependantBranches off b. try to place hold on an item you should be able to place hold on c. it should work d. put IndependantBranches on and canreservefromotherbranches off e. shouldn't work 2. after patches redo steps from (1) and everything should be working fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 60853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60853&action=edit [SIGNED OFF] Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND ! canreservefromotherbranches) The variable $item used to be a hash, but at the end of the function, it's a Koha object. As $item->{homebranch} doesn't yield anything and should be $item->homebranch. It prevents people using different branches without holds between branches from placing a hold on an item they should be able to place hold on. Test plan: 1. Before patch a. with IndependantBranches off b. try to place hold on an item you should be able to place hold on c. it should work d. put IndependantBranches on and canreservefromotherbranches off e. shouldn't work 2. after patches redo steps from (1) and everything should be working fine. Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60853|0 |1 is obsolete| | --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 60854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60854&action=edit [SIGNED OFF] Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND ! canreservefromotherbranches) The variable $item used to be a hash, but at the end of the function, it's a Koha object. As $item->{homebranch} doesn't yield anything and should be $item->homebranch. It prevents people using different branches without holds between branches from placing a hold on an item they should be able to place hold on. Test plan: 1. Before patch a. with IndependantBranches off b. try to place hold on an item you should be able to place hold on d. put IndependantBranches on and canreservefromotherbranches off e. shouldn't work 2. after patches redo steps from (1) and everything should be working fine. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60542|0 |1 is obsolete| | Attachment #60854|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60901&action=edit Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND ! canreservefromotherbranches) The variable $item used to be a hash, but at the end of the function, it's a Koha object. As $item->{homebranch} doesn't yield anything and should be $item->homebranch. It prevents people using different branches without holds between branches from placing a hold on an item they should be able to place hold on. Test plan: 1. Before patch a. with IndependantBranches off b. try to place hold on an item you should be able to place hold on c. it should work d. put IndependantBranches on and canreservefromotherbranches off e. shouldn't work 2. after patches redo steps from (1) and everything should be working fine. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Note: Item is fetched twice, it's not necessary. But out of the scope of this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the 17.05 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.06. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org