[Bug 23123] New: Status AVAILABLE for suggestions is not translated in the templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Bug ID: 23123 Summary: Status AVAILABLE for suggestions is not translated in the templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Target Milestone: --- We noticed that the status AVAILABLE (suggestion was ordered and received in acq) is not displayed correctly in the suggestions table. I think it's missing in the templates here: 131 <span class="label">Status:</span> 132 [% SET status_found = 0 %] 133 [% IF ( STATUS == 'ASKED' ) %] 134 Pending 135 [% SET status_found = 1 %] 136 [% ELSIF ( STATUS == 'ACCEPTED' ) %] 137 Accepted 138 [% SET status_found = 1 %] 139 [% ELSIF ( STATUS == 'CHECKED' ) %] 140 Checked 141 [% SET status_found = 1 %] 142 [% ELSIF ( STATUS == 'REJECTED' ) %] 143 Rejected 144 [% SET status_found = 1 %] 145 [% ELSE %] 146 [% FOREACH s IN SuggestionStatuses %] 147 [% IF STATUS == s.authorised_value %] 148 [% s.lib | html %] 149 [% SET status_found = 1 %] 150 [% END %] 151 [% END %] 152 [% END %] It shows as AVAILABLE and is not translatable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ORDERED is missing as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Status AVAILABLE for |Status AVAILABLE and |suggestions is not |ORDERED for suggestions is |translated in the templates |not translated in the | |templates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This part of the code looks incomplete as well: 506 <td> 507 [% IF ( suggestions_loo.ASKED ) %] 508 Pending 509 [% ELSIF ( suggestions_loo.ACCEPTED ) %] 510 Accepted 511 [% ELSIF ( suggestions_loo.ORDERED ) %] 512 Ordered 513 [% ELSIF ( suggestions_loo.REJECTED ) %] 514 Rejected 515 [% ELSIF ( suggestions_loo.CHECKED ) %] 516 Checked 517 [% ELSIF AuthorisedValues.GetByCode( 'SUGGEST_STATUS', suggestions_loo.STATUS ) %] 518 [% AuthorisedValues.GetByCode( 'SUGGEST_STATUS', suggestions_loo.STATUS ) | html %] 519 [% ELSE %] 520 Status unknown 521 [% END %] 522 523 [% IF ( suggestions_loo.reason ) %] 524 <br />([% suggestions_loo.reason | html %]) 525 [% END %] 526 </td> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Status AVAILABLE and |Status AVAILABLE and |ORDERED for suggestions is |ORDERED for suggestions are |not translated in the |not translated in the |templates |templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91514&action=edit Bug 23123: Add missing suggestion status to template for translation This completes suggestion status options in the templates in 2 places so all values can be translated and show correctly. To test: - Create 2 suggestions - Accept them - Create a basket and order those 2 from suggestions - Close the basket - Receive shipment and receive one of the 2 suggestions - Go back to suggestions: - Look at the status column in the suggestions table for both - Verify that it shows AVAILABLE - View both suggestions - Verify that the Status: is empty - Apply patch - Repeat test from above, it should all show nicely now -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | CC| |hayleymapley@catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Claudie Trégouët <claudie.tregouet@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91514|0 |1 is obsolete| | --- Comment #4 from Claudie Trégouët <claudie.tregouet@biblibre.com> --- Created attachment 93444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93444&action=edit Bug 23123: Add missing suggestion status to template for translation This completes suggestion status options in the templates in 2 places so all values can be translated and show correctly. To test: - Create 2 suggestions - Accept them - Create a basket and order those 2 from suggestions - Close the basket - Receive shipment and receive one of the 2 suggestions - Go back to suggestions: - Look at the status column in the suggestions table for both - Verify that it shows AVAILABLE - View both suggestions - Verify that the Status: is empty - Apply patch - Repeat test from above, it should all show nicely now Signed-off-by: Claudie Trégouët <claudie.tregouet@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Claudie Trégouët <claudie.tregouet@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |claudie.tregouet@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you, Claudie! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93444|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93582&action=edit Bug 23123: Add missing suggestion status to template for translation This completes suggestion status options in the templates in 2 places so all values can be translated and show correctly. To test: - Create 2 suggestions - Accept them - Create a basket and order those 2 from suggestions - Close the basket - Receive shipment and receive one of the 2 suggestions - Go back to suggestions: - Look at the status column in the suggestions table for both - Verify that it shows AVAILABLE - View both suggestions - Verify that the Status: is empty - Apply patch - Repeat test from above, it should all show nicely now Signed-off-by: Claudie Trégouët <claudie.tregouet@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Component|Acquisitions |I18N/L10N -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org