https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43541 Bug ID: 43541 Summary: Hold ratios report counts item-less orders inconsistently Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com Depends on: 15685, 15997 Target Milestone: --- There are inconsistencies and conceptual errors in when/how the Hold Ratios report (/cgi-bin/koha/circ/reserveratios.pl) counts orders unreceived orders and includes them in the "items" count when determining ratios. When accessing the hold ratios via the circulation module, orders without attached items are *never* counted. This is because Bug 15685 made the counting of these orders dependent upon a basket's create_items value and when accessing the ratios from circulation there is no associated basket. If accessing the hold ratios via the acquisitions module (selecting "From titles with highest hold ratios" when adding to a basket), unreceived orders will only be counted if the basket to which one is adding an order is set to create items upon receiving. These orders are counted regardless of whether or not one has selected "Include ordered" on the hold ratios report. Further, these orders are counted regardless of whether or not they have an attached item. This causes double-counting when orders do have attached items, as both the order and the item are included in the count. I suggest that we should: - Allow un-received orders without attached items to be included in the hold ratio items count when one is accessing the hold ratios via circulation - Allow un-received orders without attached items to be included in the hold ratio items count when one is accessing the hold ratios via acquistions regardless of the create_items value of the basket to which one is adding orders - In either circulation or acquisitions, only include un-received orders without attached items if the "Include ordered" checkbox has been selected - Never count un-received orders with attached items (count the item instead) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15997 [Bug 15997] Hold Ratios for ordered items doesn't count orders where AcqCreateItem is set to 'receiving' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.