https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42840 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42840 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 202237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202237&action=edit Bug 42840: Update some patron account and POS pages to use grid layout for forms This patch updates patron acount and point of sale pages to use new structure and CSS for layout forms using CSS grids. The test plan is a beast, but most of these templates are linked by the use of transaction_types.inc and have to be dealt with in one go. NOTE: This patch does *not* modify additional-fields-entry.inc, so if you have additional fields configured the display of these fields may be a little bit off. This was a trade-off in terms of visual inconsistency versus a much larger patch (and test plan). To test, apply the patch and rebuild the staff interface CSS. At each step, confirm that the form looks correct. - Locate a patron record and click "Accounting" in the sidebar menu - Open the "Create manual credit" tab. - Confirm that the manual credit form looks correct. - Add a credit to the patron's account. - From the "Transactions" tab, click "Issue payout" on the credit you added. Check the form in the modal which is displayed. - Confirm that the payout is submitted correctly. - Open the "Create manual invoice" tab. - Confirm that the form is correct and that charge is added correctly. - From the "Trasactions" tab, click the "Apply discount" button for the charge you just added. - Confirm that the form in the modal window looks correct. - Submit the form and confirm that the discount is applied correctly. - Click the "Void payment" button for the discount you submitted. - Confirm that the form in the modal window looks correct and that the payment is correcty voided. - Click the "Cancel charge" button for the charge you manually added. - Add a note, submit, and confirm that the charge is cancelled and the note added. - Click the "Edit" button on the note you just added. Confirm that the form looks correct and that your edit is applied correctly. - Open the "Make a payment" tab and click "Pay" on an individual charge. - Confirm that the form looks correct, and that the payment is submitted correctly. - From the "Transactions" tab, click the "Issue refund" button on the charge you paid. - Confirm that the form in the modal window looks correct and that the payment is correcty refunded. - If necessary, add additional manual credits on the patron's account. - From the "Make a payment" tab, click "Pay selected" and test that form. - Do the same with the "Write off selected" button. - If necessary, turn on the "EnablePointOfSale" and "UseCashRegisters" system preferences. You'll have to go to Administration and create a cash register and add at least one debit type. - Go to the Point of Sale page - Add one or more items to purchase - Test the "Collect payment" form and confirm it looks correct and works correctly. - Click "Transsaction history for [cash register] in the sidebar. - Click "Issue refund" on the sale you just made. - Confirm that the form in the modal window looks correct and that your refund submits correctly. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42840 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42840 --- Comment #2 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 202641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202641&action=edit Bug 42840: Update some patron account and POS pages to use grid layout for forms This patch updates patron acount and point of sale pages to use new structure and CSS for layout forms using CSS grids. The test plan is a beast, but most of these templates are linked by the use of transaction_types.inc and have to be dealt with in one go. NOTE: This patch does *not* modify additional-fields-entry.inc, so if you have additional fields configured the display of these fields may be a little bit off. This was a trade-off in terms of visual inconsistency versus a much larger patch (and test plan). To test, apply the patch and rebuild the staff interface CSS. At each step, confirm that the form looks correct. - Locate a patron record and click "Accounting" in the sidebar menu - Open the "Create manual credit" tab. - Confirm that the manual credit form looks correct. - Add a credit to the patron's account. - From the "Transactions" tab, click "Issue payout" on the credit you added. Check the form in the modal which is displayed. - Confirm that the payout is submitted correctly. - Open the "Create manual invoice" tab. - Confirm that the form is correct and that charge is added correctly. - From the "Trasactions" tab, click the "Apply discount" button for the charge you just added. - Confirm that the form in the modal window looks correct. - Submit the form and confirm that the discount is applied correctly. - Click the "Void payment" button for the discount you submitted. - Confirm that the form in the modal window looks correct and that the payment is correcty voided. - Click the "Cancel charge" button for the charge you manually added. - Add a note, submit, and confirm that the charge is cancelled and the note added. - Click the "Edit" button on the note you just added. Confirm that the form looks correct and that your edit is applied correctly. - Open the "Make a payment" tab and click "Pay" on an individual charge. - Confirm that the form looks correct, and that the payment is submitted correctly. - From the "Transactions" tab, click the "Issue refund" button on the charge you paid. - Confirm that the form in the modal window looks correct and that the payment is correcty refunded. - If necessary, add additional manual credits on the patron's account. - From the "Make a payment" tab, click "Pay selected" and test that form. - Do the same with the "Write off selected" button. - If necessary, turn on the "EnablePointOfSale" and "UseCashRegisters" system preferences. You'll have to go to Administration and create a cash register and add at least one debit type. - Go to the Point of Sale page - Add one or more items to purchase - Test the "Collect payment" form and confirm it looks correct and works correctly. - Click "Transsaction history for [cash register] in the sidebar. - Click "Issue refund" on the sale you just made. - Confirm that the form in the modal window looks correct and that your refund submits correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes.