[Bug 12616] New: Locale in subscriptions should not default to English when empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Bug ID: 12616 Summary: Locale in subscriptions should not default to English when empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The locale field in subscriptions currently defaults to empty, with a note that in this case English will be used automatically. If it really defaults to English, then it would make sense to offer an option to preselect it to the currently selected template language or to a language chosen in configuration. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Note: in our 3.16.1 installation it always defaults to "Urdu"... I was not able to reproduce this in master, but have seen it multiple times when testing and presenting. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com Component|Templates |Serials Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is still a problem in 3.18.5.1 The pull down defaults to Urdu instead of empty. The note says: If empty, English is used - independent of the selected display language. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, there is a deeper problem behind this in the creation of the language list. Multiple entries are marked as selected in the source code with an empty value attribute: ... <option value="por">Português (Portuguese)</option> <option value="rum">Român (Romanian)</option> <option value="rus">Русский (Russian)</option> <option value="" selected="selected">Cрпски (Serbian)</option> <option value="spa">Español (Spanish)</option> <option value="swe">Svenska (Swedish)</option> <option value="" selected="selected">Tetun (Tetum)</option> <option value="tha">ภาษาไทย (Thai)</option> <option value="tur">Türkçe (Turkish)</option> <option value="ukr">Українська (Ukranian)</option> <option value="" selected="selected">اردو (Urdu)</option> ... The preselection of Urdu also happens in the English GUI. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Locale in subscriptions |Locale in subscriptions not |should not default to |preselecting correctly |English when empty | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Somethins strange is happening here - on master the options are clean and complete, but on switching to German the language list stays in English? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Sorry but can't reproduce, on master and 3.16.10 Tried using German and Spanish -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the problem might be missing language descriptions - some of our installations are pretty old. I will try to update the database tables and see if this fixes the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, bit puzzled here. I have 2 installations, both 3.18.5.1 currently. Example: Urdu Installation 1: <option value="" selected="selected">اردو (Urdu)</option> Installation 2: <option value="urd" selected="selected">اردو (Urdu)</option> I haven't spotted the difference in the database yet, that would cause the difference. The one showing the code directly is actually the older database. There are about 4-5 languages where the code is missing in the list. They are all also 'selected'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- To reproduce on master: delete a couple of values from language_rfc4646_to_iso639 table. For example DELETE FROM language_rfc4646_to_iso639 WHERE rfc4646_subtag IN ('ta','ur') gives a pulldown that defaults to Urdu (or the last lang without 3 letter code) and 'ta' (tamil) is also selected. Problem is missing values in that table. We can hide the problem removing pulldown entries without proper iso639-2 code -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- That might be good - I think I can fix this database with your hints, but there are probably more installations out there with that problem. It looks like we don't have a clean state for installations that have gone threw a few updates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 40246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40246&action=edit Bug 12616: Locale in subscriptions not preselecting correctly There is a problem if a language is present but don't have ISO639-2 code. Locale pulldown on serial suscription is malformed. To reproduce on master: a) remove some entries on language_rfc4646_to_iso639 b) go to Serials > New suscription c) Put any value on Vendor and record, press Next>> d) Look at locale pulldown, it must default to last removed lang from a), also other langs has no value and are also 'selected' on html To test: 1) Reproduce the bug 2) Apply the patch 3) Add New suscription, pulldown must be fixed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You're the best - thx Bernardo! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40246|0 |1 is obsolete| | --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40250&action=edit Bug 12616: Locale in subscriptions not preselecting correctly There is a problem if a language is present but don't have ISO639-2 code. Locale pulldown on serial suscription is malformed. To reproduce on master: a) remove some entries on language_rfc4646_to_iso639 b) go to Serials > New suscription c) Put any value on Vendor and record, press Next>> d) Look at locale pulldown, it must default to last removed lang from a), also other langs has no value and are also 'selected' on html To test: 1) Reproduce the problem 2) Apply the patch 3) Add New suscription, pulldown must be fixed NOTE: Deleted Urdu and Chinese. Master had both "selected" in the HTML. Applied patch, neither were added. Defaults to first item, which is blank meaning English. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Don't you think it's better to fix the DB data? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we should do both - it could be hard to get all edge cases for the old databases where we have slacked with the database updates. This fixes a problem until we can figure out a more complete solution (maybe bug 12017?) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40250|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40254&action=edit Bug 12616: Locale in subscriptions not preselecting correctly There is a problem if a language is present but don't have ISO639-2 code. Locale pulldown on serial suscription is malformed. To reproduce on master: a) remove some entries on language_rfc4646_to_iso639 b) go to Serials > New suscription c) Put any value on Vendor and record, press Next>> d) Look at locale pulldown, it must default to last removed lang from a), also other langs has no value and are also 'selected' on html To test: 1) Reproduce the problem 2) Apply the patch 3) Add New suscription, pulldown must be fixed NOTE: Deleted Urdu and Chinese. Master had both "selected" in the HTML. Applied patch, neither were added. Defaults to first item, which is blank meaning English. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Good catch Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #18 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x will be in 3.18.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org