[Bug 33960] New: Add ability to retrieve deleted biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Bug ID: 33960 Summary: Add ability to retrieve deleted biblios Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com CC: tomascohen@gmail.com To add ability for discovery services to use the REST api to keep up to date, we need a way to retrieve information on deleted biblios. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152199&action=edit Bug 33960: Add deleted option ot biblios endpoint This patch adds a 'deleted' parameter to the biblios endpoint. If this parameter is passed the API will return deleted biblios rather than current ones To test: 1 - Apply patch 2 - GET http://localhost:8081/api/v1/biblios 3 - Confirm you can search and page 4 - add 'deleted' param to query 5 - Confirm you get dleted biblios information 6 - Confirm searching and paging work as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152200&action=edit Bug 33960: Add objects and update schema -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152201&action=edit Bug 33960: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 152215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152215&action=edit Bug 33960: (QA follow-up) ->delete doesn't send to deletedbiblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152199|0 |1 is obsolete| | Attachment #152200|0 |1 is obsolete| | Attachment #152201|0 |1 is obsolete| | Attachment #152215|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 155331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155331&action=edit Bug 33960: Add deleted option ot biblios endpoint This patch adds a 'deleted' parameter to the biblios endpoint. If this parameter is passed the API will return deleted biblios rather than current ones To test: 1 - Apply patch 2 - GET http://localhost:8081/api/v1/biblios 3 - Confirm you can search and page 4 - add 'deleted' param to query 5 - Confirm you get dleted biblios information 6 - Confirm searching and paging work as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 155332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155332&action=edit Bug 33960: Add objects and update schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 155333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155333&action=edit Bug 33960: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 155334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155334&action=edit Bug 33960: (QA follow-up) ->delete doesn't send to deletedbiblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 155335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155335&action=edit Bug 33960: Add api mapping and biblioitems to Old::Biblios to match Biblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should this be signed off? I see lines from Tomas. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- He was just providing some feedback, still needs a signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I suggest to tidy for QA ;) WARN Koha/Old/Biblio.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 13) WARN Koha/Old/Biblio/Metadata.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 3) FAIL Koha/Old/Biblio/Metadatas.pm FAIL pod coverage POD is missing for 'object_class' OK Koha/Old/Biblios.pm WARN Koha/REST/V1/Biblios.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 138, now: 139) WARN Koha/Schema/Result/Deletedbiblio.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 41, now: 49) OK api/v1/swagger/paths/biblios.yaml WARN t/db_dependent/api/v1/biblios.t WARN tidiness The file is less tidy than before (bad/messy lines before: 370, now: 387) This table seems a little overkill: +Returns an object representing the metadata record. The expected record type +corresponds to this table: + + ------------------------------- + | format | object type | + ------------------------------- + | marcxml | MARC::Record | + ------------------------------- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155331|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155416&action=edit Bug 33960: Add deleted option ot biblios endpoint This patch adds a 'deleted' parameter to the biblios endpoint. If this parameter is passed the API will return deleted biblios rather than current ones To test: 1 - Apply patch 2 - GET http://localhost:8081/api/v1/biblios 3 - Confirm you can search and page 4 - add 'deleted' param to query 5 - Confirm you get dleted biblios information 6 - Confirm searching and paging work as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155332|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155417&action=edit Bug 33960: Add objects and update schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155333|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155418&action=edit Bug 33960: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155334|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155419&action=edit Bug 33960: (QA follow-up) ->delete doesn't send to deletedbiblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155335|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155420&action=edit Bug 33960: Add api mapping and biblioitems to Old::Biblios to match Biblio Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure if anything more is needed to make the API docs look pretty, I was not entirely sure how to test the local API documentation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize@ptfs-europe | |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155416|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157899&action=edit Bug 33960: Add deleted option ot biblios endpoint This patch adds a 'deleted' parameter to the biblios endpoint. If this parameter is passed the API will return deleted biblios rather than current ones To test: 1 - Apply patch 2 - GET http://localhost:8081/api/v1/biblios 3 - Confirm you can search and page 4 - add 'deleted' param to query 5 - Confirm you get dleted biblios information 6 - Confirm searching and paging work as expected Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155417|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157900&action=edit Bug 33960: Add objects and update schema Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155418|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157901&action=edit Bug 33960: Unit tests Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155419|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157902&action=edit Bug 33960: (QA follow-up) ->delete doesn't send to deletedbiblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155420|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157903&action=edit Bug 33960: Add api mapping and biblioitems to Old::Biblios to match Biblio Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157904&action=edit Bug 33960: (QA follow-up) Enhance tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm not 100% there on this yet.. I enhanced the test to actually check that the 'deleted' option filters on only those deleted and doesn't add both resultsets. I note there's also no tests for the more involved queries and without passing through the api_query_fixer I would imagine some queries would result in a 500 right now. The question is.. should passing the deleted flag prevent such searches anyway.. and if so should we somehow note that in the specifications? I not also, we don't validate the output.. so the addition of a deleted_on field isn't flagged either way in our specification.. I'm not sure I like the inconsistency here... but I'm not really sure on a resolution either. Open to thoughts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Marking blocked whilst I ask for feedback -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158071&action=edit Bug 33960: (follow-up) Add to description to highlight that deleted limits query options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Got struck here by another bug: [2023/11/03 10:33:00] [ERROR] GET /api/v1/biblios: unhandled exception (Mojo::Exception)<<Can't call method "to_api" on an undefined value at /usr/share/koha/Koha/Biblio.pm line 1433.>> => my $json_biblioitem = $self->biblioitem->to_api( $args ); Just testing /api/v1/biblios with Accept=application/json. Note that Accept=application/marc works fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35246 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Cant finish here right now. Back to SO. Any one else feel free to take over. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I know I suggested Nick to stick to the 'deleted' query parameter... But right now I feel like this should be a separate endpoint, with deleted_biblio_id as the identifier. My reasoning is it would be ugly that you can GET /biblios but then cannot do things like POST /biblios/:biblio_id/items on the retrieved biblio_ids, for example. Or worse, need to code something to deal with such scenarios polluting the controllers. Sorry :-/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157899|0 |1 is obsolete| | Attachment #157900|0 |1 is obsolete| | Attachment #157901|0 |1 is obsolete| | Attachment #157902|0 |1 is obsolete| | Attachment #157903|0 |1 is obsolete| | Attachment #157904|0 |1 is obsolete| | Attachment #158071|0 |1 is obsolete| | --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159998&action=edit Bug 33960: Add objects and update schema Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159999&action=edit Bug 33960: Add api mapping and biblioitems to Old::Biblios to match Biblio Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160000&action=edit Bug 33960: Add routes and controller -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #35 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160001&action=edit Bug 33960: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160002&action=edit Bug 33960: Tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #37 from Owen Leonard <oleonard@myacpl.org> --- I'm getting a couple warnings and a fail from the qa tool. Can you check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Owen Leonard from comment #37)
I'm getting a couple warnings and a fail from the qa tool. Can you check?
You can ignore the fail, the warnings should be cleared by tidy patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160002|0 |1 is obsolete| | --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160552&action=edit Bug 33960: Tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #40 from Brendan Lawlor <blawlor@clamsnet.org> --- I tried to test this, but I can't figure out how to format the query for the biblios endpoint. I can only make queries with the path parameters. Is there an example of what to put in the body of the request? I tried like this but get 500 error: curl --location --request GET 'http://localhost:8081/api/v1/biblios' \ --header 'Content-Type: application/json' \ --header 'Authorization: Bearer ...' \ --data '{ "_page": 1, "_per_page": 10, "_match": "contains", "_order_by": [], "q": ["array", "of", "strings"] }' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_11_candidate |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159998|0 |1 is obsolete| | Attachment #159999|0 |1 is obsolete| | Attachment #160000|0 |1 is obsolete| | Attachment #160001|0 |1 is obsolete| | Attachment #160552|0 |1 is obsolete| | --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163852&action=edit Bug 33960: Add objects and update schema Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #42 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163853&action=edit Bug 33960: Add api mapping and biblioitems to Old::Biblios to match Biblio Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #43 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163854&action=edit Bug 33960: Add routes and controller Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #44 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163855&action=edit Bug 33960: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163852|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163948&action=edit Bug 33960: Add objects and update schema Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163853|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163949&action=edit Bug 33960: Add api mapping and biblioitems to Old::Biblios to match Biblio Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163854|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163950&action=edit Bug 33960: Add routes and controller Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163855|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163951&action=edit Bug 33960: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- My apologies, this one slipped the net for me. Looks great now with the work that's happened since I last assessed it. I'm happy to PQA on it, tests all passing, QA script is happy and it all makes clear sense to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nick, was this one sponsored.. there's no sponsor lines ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #51 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #50)
Nick, was this one sponsored.. there's no sponsor lines ;)
This one does not need credit beyond ByWater, and all the community folks that helped ;-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to retrieve |Add ability to retrieve |deleted biblios |deleted bibliographic | |records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate |additional_work_needed --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We have some test fails to be fixed, that were probably caused by the work here: t_db_dependent_TestBuilder_t not ok 697 - Module Koha::Old::Biblio::Metadatas should have koha_object[s]_class method if needed not ok 698 - Module Koha::DeletedbiblioMetadata should be defined not ok 699 - Module Koha::DeletedbiblioMetadatas should be defined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've added the requisite pieces to the schema class now.. will push shortly.. just removing the additiona_work_needed tag to prevent duplicate work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #55 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #56 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- API route change, nothing to add/edit in the Koha manual. I assume API documentation is done automatically? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38678 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38678 [Bug 38678] GET /deleted/biblios cannot be filtered on `deleted_on` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38679 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38679 [Bug 38679] GET /deleted/biblios missing some mappings -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org