[Bug 13891] New: Make all patron searches use DataTables server-side processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Bug ID: 13891 Summary: Make all patron searches use DataTables server-side processing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart@biblibre.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 9811 Blocks: 12633 Bug 9811 introduces a new search way for patrons. Some code have been refactored and the server-side option of DataTables is now used. Bug 12648 (basket users) and bug 13021 (guarantors) uses the same way to search patrons. But in 3 other places, the former C4::Members::Search subroutine is still used (and in some cases, a manual pagination...): - budget users and owner - serial recipients - patron cards The 2 expected goals are 1/ Use the same centralized way to search for patrons and 2/ to get rid of the last calls to the C4::Members::Search (and so SQLHelper). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37104&action=edit Bug 13891: DataTables server-side processing - budget users This first patch remove the previous way to search for users to link to budgets. Test plan: 1/ Edit or create a fund 2/ Edit the owner of this fund a select a patron 3/ Add 1+ users to the user lists of this fund -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37105&action=edit Bug 13891: DataTables server-side processing - Serial recipients This second patch removes the previous way to search for serial recipients. Test plan: 1/ Edit the routing list for a subscription (serials/routing.pl?subscriptionid=X) 2/ Add 1+ recipients 3/ Confirm there is no regression on the add/delete/search actions QA note: This search does not use a clean way to interact with the window opener. Indeed the opener is reloaded to display the new item. This patch does not change this behavior, but note the trick in the template (common/patron_search.tt) to wait for the opener in order not to get a JS error. This is also used by the next patch (patron card). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37106&action=edit Bug 13891: DataTables server-side processing - patron cards This third patch removes the previous way to search for patron cards users. Test plan: 1/ Add items to a patron card batch (patroncards/edit-batch.pl?op=edit&element_id=X) 2/ Add 1+ patrons to the batch 3/ Confirm there is no regression -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37107&action=edit Bug 13891: DataTables server-side processing - Fix regressions This patch fixes the regressions introduced by the previous patches. If you have tested all in once, you didn't see them. It introduces library, category and "first letter" filters. Test plan: 1/ On all pages impacted by previous patches + new order empty (link patron to an order) + guarantor search 2/ Add / Select patron to the list 3/ Use the filters 4/ Confirm there is no regression -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13021 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- 6 files deleted, 400 lines of code removed but new features added :) Please test! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #6 from Marc Véron <veron@veron.ch> --- Patch does not apply: Applying: Bug 13891: DataTables server-side processing - budget users Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt Removing koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudget_user_search.tt Removing admin/aqbudget_user_search.pl Applying: Bug 13891: DataTables server-side processing - Serial recipients Applying: Bug 13891: DataTables server-side processing - patron cards Applying: Bug 13891: DataTables server-side processing - Fix regressions fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 13891: DataTables server-side processing - Fix regressions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13879 Status|Patch doesn't apply |Needs Signoff --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Marc Véron from comment #6) Sorry Marc, I forgot to add the dependency on bug 13879. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #8 from Marc Véron <veron@veron.ch> --- I have the following problem (tested with adding owner and user to fund and with routing list, but I thing it will appear at all places): 1) Do a search in the pop-up window 2) The names in the result table are linked to patron's detail page. If you click on a name, patron's details appear inside this pop-up window, no way back. I would expect the names to have no detail link at all OR the link on the names to behave like the 'Select' link. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Marc Véron from comment #8)
I have the following problem (tested with adding owner and user to fund and with routing list, but I thing it will appear at all places):
1) Do a search in the pop-up window 2) The names in the result table are linked to patron's detail page. If you click on a name, patron's details appear inside this pop-up window, no way back.
I would expect the names to have no detail link at all OR the link on the names to behave like the 'Select' link.
I think the links already existed before this patch set. I am not sure removing them is a good idea. What did you mean with "behave like the 'Select' link"? Open in a new window? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 37180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37180&action=edit No links on patron's names (behaviour without patches) Hi Jonathan, Without patches applied the names are not linked. With "Behave like the select link" I mean that if a link is on the name, it should select this patron for the fund (or whatever the pop-up was opened for). But I think it is better to have no links at all on the names, as it was without patch. See screenshot in attachment. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Marc Véron from comment #10)
Created attachment 37180 [details] No links on patron's names (behaviour without patches)
Hi Jonathan,
Without patches applied the names are not linked.
On the users and owner of a budget, but it is on the order users search :) So we need to have the same behavior everywhere.
With "Behave like the select link" I mean that if a link is on the name, it should select this patron for the fund (or whatever the pop-up was opened for).
But I think it is better to have no links at all on the names, as it was without patch.
I don't have any objection to remove the link but I would prefer to wait for the QA step before removing it. If it's your only concern, you can add it as a tester note and let the QAer and RM take the decision. I will submit a followup if they agree with you. Note that it is possible to have a link in a page and not in another one, but it would be a weird behavior. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 37184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37184&action=edit [Signed-off] Bug 13891: DataTables server-side processing - budget users This first patch remove the previous way to search for users to link to budgets. Test plan: 1/ Edit or create a fund 2/ Edit the owner of this fund a select a patron 3/ Add 1+ users to the user lists of this fund Tested together with other patches. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37104|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #13 from Marc Véron <veron@veron.ch> --- Created attachment 37185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37185&action=edit [Signed-off] Bug 13891: DataTables server-side processing - Serial recipients This second patch removes the previous way to search for serial recipients. Test plan: 1/ Edit the routing list for a subscription (serials/routing.pl?subscriptionid=X) 2/ Add 1+ recipients 3/ Confirm there is no regression on the add/delete/search actions QA note: This search does not use a clean way to interact with the window opener. Indeed the opener is reloaded to display the new item. This patch does not change this behavior, but note the trick in the template (common/patron_search.tt) to wait for the opener in order not to get a JS error. This is also used by the next patch (patron card). Tested together with other patches. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37105|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #14 from Marc Véron <veron@veron.ch> --- Created attachment 37186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37186&action=edit [Signed-off] Bug 13891: DataTables server-side processing - patron cards This third patch removes the previous way to search for patron cards users. Test plan: 1/ Add items to a patron card batch (patroncards/edit-batch.pl?op=edit&element_id=X) 2/ Add 1+ patrons to the batch 3/ Confirm there is no regression Tested together with other patches. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37106|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #15 from Marc Véron <veron@veron.ch> --- Created attachment 37187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37187&action=edit [Signed-off] Bug 13891: DataTables server-side processing - Fix regressions This patch fixes the regressions introduced by the previous patches. If you have tested all in once, you didn't see them. It introduces library, category and "first letter" filters. Test plan: 1/ On all pages impacted by previous patches + new order empty (link patron to an order) + guarantor search 2/ Add / Select patron to the list 3/ Use the filters 4/ Confirm there is no regression Tested together with other patches. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37107|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- QA Note, it appears that serials/add_user_search takes into account the search text field when browsing by last name. Original version doesn't have name browse. Could be considered a bug or a feature depending on your point of view. This behavior does no occur on the "patron cards" patron search. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> ---
This behavior does no occur on the "patron cards" patron search. correct, it *does* occur.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37184|0 |1 is obsolete| | Attachment #37185|0 |1 is obsolete| | Attachment #37186|0 |1 is obsolete| | Attachment #37187|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37334&action=edit [PASSED QA] Bug 13891: DataTables server-side processing - budget users This first patch remove the previous way to search for users to link to budgets. Test plan: 1/ Edit or create a fund 2/ Edit the owner of this fund a select a patron 3/ Add 1+ users to the user lists of this fund Tested together with other patches. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37335&action=edit [PASSED QA] Bug 13891: DataTables server-side processing - Serial recipients This second patch removes the previous way to search for serial recipients. Test plan: 1/ Edit the routing list for a subscription (serials/routing.pl?subscriptionid=X) 2/ Add 1+ recipients 3/ Confirm there is no regression on the add/delete/search actions QA note: This search does not use a clean way to interact with the window opener. Indeed the opener is reloaded to display the new item. This patch does not change this behavior, but note the trick in the template (common/patron_search.tt) to wait for the opener in order not to get a JS error. This is also used by the next patch (patron card). Tested together with other patches. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37336&action=edit [PASSED QA] Bug 13891: DataTables server-side processing - patron cards This third patch removes the previous way to search for patron cards users. Test plan: 1/ Add items to a patron card batch (patroncards/edit-batch.pl?op=edit&element_id=X) 2/ Add 1+ patrons to the batch 3/ Confirm there is no regression Tested together with other patches. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37337&action=edit [PASSED QA] Bug 13891: DataTables server-side processing - Fix regressions This patch fixes the regressions introduced by the previous patches. If you have tested all in once, you didn't see them. It introduces library, category and "first letter" filters. Test plan: 1/ On all pages impacted by previous patches + new order empty (link patron to an order) + guarantor search 2/ Add / Select patron to the list 3/ Use the filters 4/ Confirm there is no regression Tested together with other patches. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Good job Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14123 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123 [Bug 14123] Patroncard: Patron search for batch no longer has Select / Select All / Add selected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14739 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 [Bug 14739] Regression on adding several patrons to a new batch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14739 | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14739 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 [Bug 14739] Regression on adding several patrons to a new batch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com --- Comment #23 from Barton Chittenden <barton@bywatersolutions.com> --- Is it possible to port this back to 3.18? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Barton Chittenden from comment #23)
Is it possible to port this back to 3.18?
I don't think it's a good idea. The patches don't apply and the dependency tree is quite important (most of them are not in 3.18 yet). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org