[Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Hi Martin, Sorry, I should have read the proposed language closer - pending_checkouts is confusing, I think it can just be 'checkouts' filter_by_has_checkouts I wonder about the methods for filtering Why do you search issues for borrowernumber, then use an in? Would it be simpler to use a single query? I think it is clearer to do something like: $self->search("issues.borrowernumber" => { -not => undef } },{join=>"issues"}); Later for housebound_choosers we do a search related to housebound_roles, then another to borrowernumber - this works, but it comes out as "FROM borrowers JOIN housebound_role JOIN borrowers" -Nick -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org