[Bug 33108] New: We need a way to launch the ES indexer automatically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Bug ID: 33108 Summary: We need a way to launch the ES indexer automatically Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Severity|enhancement |major Status|NEW |ASSIGNED Depends on| |32594 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 [Bug 32594] Add a dedicated ES indexing background worker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 147560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147560&action=edit Bug 33108: Add is_elasticsearch_enabled method to tools This patch adds a way to query if an instance is configured to use ES. To test: 1. Apply this patch 2. Enter KTD as root: $ ktd --shell --root 3. Run: $ source /kohadevbox/koha/debian/scripts/koha-functions.sh 4. Run: $ is_elasticsearch_enabled hola => FAIL: Instance hola doesn't exist (hopefully :-P) 5. Have the SearchEngine syspref set to Elasticsearch 6. Run: $ is_elasticsearch_enabled kohadev && echo "it is" || echo "it isn't" => SUCCESS: "it is" gets printed 7. Set SearchEngine to Zebra 8. Repeat 6 => SUCCESS: "it isn't" gets printed 9. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147560|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 147574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147574&action=edit Bug 33108: koha-es-indexer added -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 147575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147575&action=edit Bug 33108: Teach koha-list filter elasticsearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 147576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147576&action=edit Bug 33108: Make init handle koha-es-indexer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147574|0 |1 is obsolete| | Attachment #147575|0 |1 is obsolete| | Attachment #147576|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147617&action=edit Bug 33108: koha-es-indexer added Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147618&action=edit Bug 33108: Teach koha-list filter elasticsearch Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147619&action=edit Bug 33108: Make init handle koha-es-indexer Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147620&action=edit Bug 33108: (follow-up) Don't die, only warn if not using ES -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Nick Clemens from comment #8)
Created attachment 147620 [details] [review] Bug 33108: (follow-up) Don't die, only warn if not using ES
Why that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Typo several time in debian/koha-common.init + koha-es-indexer --start --quiet $(koha-list --enabled --elasticsearcvh) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Once I fixed the typo: % restart_all Restarting Apache httpd web server: apache2. Restarting Koha ILS: koha-commonStopping Plack daemon for kohadev:. Stopping Z39.50/SRU daemon for kohadev:. Stopping Koha worker daemon for kohadev (default):. Stopping Koha worker daemon for kohadev (long_tasks):. Stopping Koha indexing daemon for kohadev:. Error: ES indexing daemon not running for kohadev: failed! failed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147701&action=edit Bug 33108: (follow-up) Fix typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147702&action=edit Bug 33108: (follow-up) Don't let restart die if ES indexer not running This fixes the restart action in koha-common to continue with starting services even if the last service cannot be stopped (because it may not be running) This needs a larger fix, to ensure all stopped services return a warning, for now 'do_stop' simply returns the last success/failure To test: 1 - Apply patch 2 - reset_all 3 - sudo koha-es-indexer --stop kohadev 4 - restart_all 5 - You are notified that ES indexer was not running 6 - You are notified that soem services could not be stopped 7 - The services are started -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147617|0 |1 is obsolete| | Attachment #147618|0 |1 is obsolete| | Attachment #147619|0 |1 is obsolete| | Attachment #147620|0 |1 is obsolete| | Attachment #147701|0 |1 is obsolete| | Attachment #147702|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148328&action=edit Bug 33108: koha-es-indexer added Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148329&action=edit Bug 33108: Teach koha-list filter elasticsearch Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148330&action=edit Bug 33108: Make init handle koha-es-indexer Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 33108: (follow-up) Fix typo Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148331&action=edit Bug 33108: (follow-up) Don't die, only warn if not using ES Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148332&action=edit Bug 33108: (follow-up) Don't let restart die if ES indexer not running This fixes the restart action in koha-common to continue with starting services even if the last service cannot be stopped (because it may not be running) This needs a larger fix, to ensure all stopped services return a warning, for now 'do_stop' simply returns the last success/failure To test: 1 - Apply patch 2 - reset_all 3 - sudo koha-es-indexer --stop kohadev 4 - restart_all 5 - You are notified that ES indexer was not running 6 - You are notified that soem services could not be stopped 7 - The services are started Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Bug 33108 depends on bug 32594, which changed state. Bug 32594 Summary: Add a dedicated ES indexing background worker https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org