[Bug 7687] New: Remove problematic CSS gradient declarations targeting Internet Explorer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7687 Priority: P5 - low Change sponsored?: --- Bug ID: 7687 Assignee: oleonard@myacpl.org Summary: Remove problematic CSS gradient declarations targeting Internet Explorer QA Contact: koha.sekjal@gmail.com Severity: minor Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Browser compatibility Product: Koha Compatibility of CSS gradients in Internet Explorer is looking worse than I expected. I propose to remove the gradient from these elements in favor of a solid background: - Cart and Lists buttons : Applying a background gradient to these elements causes the background to "bleed" out of the rounded corners in IE9 creating an ugly halo. - Lists menu and patron menu items : These elements use gradients which in standards-compliant browsers accept several "steps" (color 1 blended with color 2 blended with color 3). IE only understands two colors. Better to have a solid background than the inferior fallback IE ends up with. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7687 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7687 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13122&action=edit Bug 7687 - Remove problematic CSS gradient declarations targeting Internet Explorer Removing and revising some CSS which causes problems in Internet Explorer: - User sidebar menu tabs in the OPAC - Sidebar menu tabs in the staff client (circ, catalog, etc) - List edit/delete buttons in the OPAC (when viewing the list of lists and viewing a list itself). Also fixed is the sprite positioning for the "new list" link which showed the wrong icon. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7687 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7687 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7687 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13122|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13336&action=edit Bug 7687 - Remove problematic CSS gradient declarations targeting Internet Explorer Removing and revising some CSS which causes problems in Internet Explorer: - User sidebar menu tabs in the OPAC - Sidebar menu tabs in the staff client (circ, catalog, etc) - List edit/delete buttons in the OPAC (when viewing the list of lists and viewing a list itself). Also fixed is the sprite positioning for the "new list" link which showed the wrong icon. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> I tested this in Firefox, and Chromium and it didn't break anything, I trust it works for IE too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7687 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Patch complexity|--- |Trivial patch --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment * css only small patch * don't break anything on FF afaics passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7687 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13779&action=edit Bug 7687 - Remove problematic CSS gradient declarations targeting Internet Explorer Removing and revising some CSS which causes problems in Internet Explorer: - User sidebar menu tabs in the OPAC - Sidebar menu tabs in the staff client (circ, catalog, etc) - List edit/delete buttons in the OPAC (when viewing the list of lists and viewing a list itself). Also fixed is the sprite positioning for the "new list" link which showed the wrong icon. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> I tested this in Firefox, and Chromium and it didn't break anything, I trust it works for IE too. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7687 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7687 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7687 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x, will be in 3.10.1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org