[Bug 16735] New: Replace existing library search groups functionality with the new hierarchical groups system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Bug ID: 16735 Summary: Replace existing library search groups functionality with the new hierarchical groups system Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org We should replace the existing library search groups with the use of the new hierarchical groups system so that old system can be removed completely. General outline: 1) Add the option to each group for it to be a "search" group 2) Port over existing groups by creating a new group for each "categorycode" in the branchrelations table 3) Re-implement the group search using the new system, remove the old system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15707 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 [Bug 15707] Add ability to define hierarchical groups of libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could we make it so that search groups and hierarchical groups can be different? You might want to group libraries for search differently than for organisational reasons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #1)
Could we make it so that search groups and hierarchical groups can be different? You might want to group libraries for search differently than for organisational reasons.
First off, you can actually define multiple different hierarchies within the new editor. It allows you to create an unlimited number of root groups. This gives us much flexibility in how a system can define its' hierarchy for different features. I think there are two ways to accomplish this: 1) Add the "show group in search" option I outlined previously 2) Allow the library to create a special root group just for searching. This group would be stored in a syspref. Each child of the root group would be a search group to be displayed. The pros of this way would be that we don't need to alter the database schema to implement it. What do you all think? Kyle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- My thinking was to preserve a bit of the feature now, without having it interfere with concerns of transport/circulation rules etc. Say you would geographically grouped search groups... but for organisation you group schools, publics etc. - not sure if that makes sense. Sounds like option b maybe? But asking some consortia librarians might be good :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #3)
My thinking was to preserve a bit of the feature now, without having it interfere with concerns of transport/circulation rules etc. Say you would geographically grouped search groups... but for organisation you group schools, publics etc. - not sure if that makes sense.
Sounds like option b maybe? But asking some consortia librarians might be good :)
I think you are correct, I think b is the way to go. General work outline: 1) Create a new system preference "SearchGroupsGroup" or something to that effect. This pref will accept the name of a group to use for Search Groups. The description will be something like: "Use all direct children of the group $GroupName as search groups. 2) Make db update to detect if system is already using search groups, if so, create a new group named "Search Groups" and add each collection of libraries as a child group to the new "Search Groups" root group. 3) Add code to generate the search groups markup for forms using the new system 4) Remove the old code and table from Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52732&action=edit Bug 16735 - Remove modules no longer needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52733&action=edit Bug 16735 - Remove tables no longer needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52734&action=edit Bug 16735 - Clean up sample data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52735&action=edit Bug 16735 - Replace existing library search groups functionality with the new hierarchical groups system Test Plan: 1) Apply this patch set 2) Note your existing search groups have been ported over to the new __SEARCH_GROUPS__ group if you had any 3) Create the group __SEARCH_GROUPS__ if one does not already exist 4) Add some first level subgroups to this group, add libraries to those groups 5) Search the library group searching in the intranet and opac 6) Note you get the same results as pre-patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jkpattison@gmail.com, | |manueltamayao@gmail.com, | |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- These patches do not apply cleanly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52732|0 |1 is obsolete| | Attachment #52733|0 |1 is obsolete| | Attachment #52734|0 |1 is obsolete| | Attachment #52735|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57098&action=edit Bug 16735 - Remove modules no longer needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57099&action=edit Bug 16735 - Remove tables no longer needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57100&action=edit Bug 16735 - Clean up sample data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57101&action=edit Bug 16735 - Replace existing library search groups functionality with the new hierarchical groups system Test Plan: 1) Apply this patch set 2) Note your existing search groups have been ported over to the new __SEARCH_GROUPS__ group if you had any 3) Create the group __SEARCH_GROUPS__ if one does not already exist 4) Add some first level subgroups to this group, add libraries to those groups 5) Search the library group searching in the intranet and opac 6) Note you get the same results as pre-patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace@sub.s | |u.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |alexbuckley@catalyst.net.nz --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- The Library Groups webpage (http://localhost:8081/cgi-bin/koha/admin/library_groups.pl) where the user should be able to create a group (in addition to being able to see previously made groups) results in a Internal Server Error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Alex Buckley from comment #14)
The Library Groups webpage (http://localhost:8081/cgi-bin/koha/admin/library_groups.pl) where the user should be able to create a group (in addition to being able to see previously made groups) results in a Internal Server Error.
I am unable to replicate your error on a fresh installation of kohadevbox. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Chris Kirby <chris.kirby@ilsleypubliclibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.kirby@ilsleypubliclib | |rary.org --- Comment #16 from Chris Kirby <chris.kirby@ilsleypubliclibrary.org> --- Patch set did not apply cleanly. "fatal: sha1 information is lacking or useless (Koha/Library/Group.pm).Repository lacks necessary blobs to fall back on 3-way merge." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Chris Kirby from comment #16)
Patch set did not apply cleanly. "fatal: sha1 information is lacking or useless (Koha/Library/Group.pm).Repository lacks necessary blobs to fall back on 3-way merge."
On top of bug 15707 applies cleanly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58087&action=edit [SIGNED-OFF] Bug 16735 - Remove modules no longer needed Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58088&action=edit [SIGNED-OFF] Bug 16735 - Remove tables no longer needed Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #20 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58089&action=edit [SIGNED-OFF] Bug 16735 - Clean up sample data Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57098|0 |1 is obsolete| | Attachment #57099|0 |1 is obsolete| | Attachment #57100|0 |1 is obsolete| | Attachment #57101|0 |1 is obsolete| | --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58090&action=edit [SIGNED-OFF] Bug 16735 - Replace existing library search groups functionality with the new hierarchical groups system Test Plan: 1) Apply this patch set 2) Note your existing search groups have been ported over to the new __SEARCH_GROUPS__ group if you had any 3) Create the group __SEARCH_GROUPS__ if one does not already exist 4) Add some first level subgroups to this group, add libraries to those groups 5) Search the library group searching in the intranet and opac 6) Note you get the same results as pre-patch Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58087|0 |1 is obsolete| | Attachment #58088|0 |1 is obsolete| | Attachment #58089|0 |1 is obsolete| | Attachment #58090|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60497&action=edit Bug 16735 - Remove modules no longer needed Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60498&action=edit Bug 16735 - Remove tables no longer needed Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60499&action=edit Bug 16735 - Clean up sample data Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60500&action=edit Bug 16735 - Replace existing library search groups functionality with the new hierarchical groups system Test Plan: 1) Apply this patch set 2) Note your existing search groups have been ported over to the new __SEARCH_GROUPS__ group if you had any 3) Create the group __SEARCH_GROUPS__ if one does not already exist 4) Add some first level subgroups to this group, add libraries to those groups 5) Search the library group searching in the intranet and opac 6) Note you get the same results as pre-patch Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60501&action=edit Bug 16735 - Don't use objects for database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60502&action=edit Bug 16735 - Remove use of get_categories Feature using it is completely undocumented as far as my research has shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60503&action=edit Bug 16735 - Filter individual libraries from search group pulldown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tested on top of bug 15707: I cannot test it, the actions from the 'Actions' button do not do anything. You should also add the btn-default class to the buttons to make them look like other Koha buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Followup for this is on bug 15707 since it is an update to the editor and not directly related to this dependent bug. (In reply to Jonathan Druart from comment #29)
Tested on top of bug 15707: I cannot test it, the actions from the 'Actions' button do not do anything.
You should also add the btn-default class to the buttons to make them look like other Koha buttons.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #29)
You should also add the btn-default class to the buttons to make them look like other Koha buttons.
This is still valid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60497|0 |1 is obsolete| | Attachment #60498|0 |1 is obsolete| | Attachment #60499|0 |1 is obsolete| | Attachment #60500|0 |1 is obsolete| | Attachment #60501|0 |1 is obsolete| | Attachment #60502|0 |1 is obsolete| | Attachment #60503|0 |1 is obsolete| | --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60772&action=edit Bug 16735 - Remove modules no longer needed Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60773&action=edit Bug 16735 - Remove tables no longer needed Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60774&action=edit Bug 16735 - Clean up sample data Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60775&action=edit Bug 16735 - Replace existing library search groups functionality with the new hierarchical groups system Test Plan: 1) Apply this patch set 2) Note your existing search groups have been ported over to the new __SEARCH_GROUPS__ group if you had any 3) Create the group __SEARCH_GROUPS__ if one does not already exist 4) Add some first level subgroups to this group, add libraries to those groups 5) Search the library group searching in the intranet and opac 6) Note you get the same results as pre-patch Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60776&action=edit Bug 16735 - Don't use objects for database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60777&action=edit Bug 16735 - Remove use of get_categories Feature using it is completely undocumented as far as my research has shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60778&action=edit Bug 16735 - Filter individual libraries from search group pulldown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60779&action=edit Bug 16735 - Filter groups without immediate child libraries from group pulldown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #31)
(In reply to Jonathan Druart from comment #29)
You should also add the btn-default class to the buttons to make them look like other Koha buttons.
This is still valid.
Fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The more I think about this the more I dislike the idea. Search Groups and Functional Groups may well need to be different. If I'm understanding it correctly, the idea of Bug 15707 is to allow for preferences (i.e. things that govern functionality including lending rules, holding rules etc etc) to be shared and inherited down a hierarchical institution structure. As such, each entity should have one parent and only one parent.. else inheritance gets super messy. Searches may well want to apply over completely different groups and may well want to overlap. Think of a set of library branches spread across a large area, you may well want to have search groups to allow searching of a group of 'immediate neighbours'; as such depending on which branch you're neighbours will be different and thus one entity will likely need to be part of more than one group. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Martin, I'm not sure what you are suggesting, but I think I have the idea. Consider this group structure: United States Pennsylvania Crawford County Meadville Public Library Saegertown Public Library Erie County Millcreek Public Library Edinboro Public Library New York Niagara County Niagara Public Library Falls Public Library Orleans County Orleans Public Library Beaver Public Library So, if this were the heirarchy, you'd expect the search options to include: Pennsylvania Crawford County Erie County New York Niagara County Orleans Count and selecting one of those would search all the libraries that are below that group or subgroup. Is that correct? If so, I think I agree and would be happy to implement that. (In reply to Martin Renvoize from comment #41)
The more I think about this the more I dislike the idea.
Search Groups and Functional Groups may well need to be different.
If I'm understanding it correctly, the idea of Bug 15707 is to allow for preferences (i.e. things that govern functionality including lending rules, holding rules etc etc) to be shared and inherited down a hierarchical institution structure. As such, each entity should have one parent and only one parent.. else inheritance gets super messy.
Searches may well want to apply over completely different groups and may well want to overlap. Think of a set of library branches spread across a large area, you may well want to have search groups to allow searching of a group of 'immediate neighbours'; as such depending on which branch you're neighbours will be different and thus one entity will likely need to be part of more than one group.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. So using your example Hierarchy. United States Pennsylvania Crawford County Meadville Public Library Saegertown Public Library Erie County Millcreek Public Library Edinboro Public Library New York Niagara County Niagara Public Library Falls Public Library Orleans County Orleans Public Library Beaver Public Library What if 'Meadville' and 'Orleans' are physically near each other. You may want a 'Search Group' that allows searching just that pair. Thus the 'Hierarchical Grouping' doesn't work for that case. I think 'Search Groups' and 'Privilege Groups' need to be different things entirely and not bound to the same fundamental structure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So, what you've described in your reply is what I 'think' I understand bug 15707 to be aiming for.. or is that not the case? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- 'aiming for' in terms of 'privileges' down the tree.. not 'search groups'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #45)
'aiming for' in terms of 'privileges' down the tree.. not 'search groups'.
Correct, same behavior applied to different mechanics. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- You are correct, which is why you can create as many groups and hierarchies as you want! If your "political" structure differs from your "geographic" structure, you can have two complete hierarchies which you can choose from based on your needs. For searching, you could even allow both sets of hierarchies to be searchable if you so chose. (In reply to Martin Renvoize from comment #43)
OK.. So using your example Hierarchy.
United States Pennsylvania Crawford County Meadville Public Library Saegertown Public Library Erie County Millcreek Public Library Edinboro Public Library New York Niagara County Niagara Public Library Falls Public Library Orleans County Orleans Public Library Beaver Public Library
What if 'Meadville' and 'Orleans' are physically near each other. You may want a 'Search Group' that allows searching just that pair. Thus the 'Hierarchical Grouping' doesn't work for that case. I think 'Search Groups' and 'Privilege Groups' need to be different things entirely and not bound to the same fundamental structure.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #48 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Depends on a report in ASSIGNED status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60772|0 |1 is obsolete| | Attachment #60773|0 |1 is obsolete| | Attachment #60774|0 |1 is obsolete| | Attachment #60775|0 |1 is obsolete| | Attachment #60776|0 |1 is obsolete| | Attachment #60777|0 |1 is obsolete| | Attachment #60778|0 |1 is obsolete| | Attachment #60779|0 |1 is obsolete| | --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65658&action=edit Bug 16735 - Remove modules no longer needed Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65659&action=edit Bug 16735 - Clean up sample data Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65660&action=edit Bug 16735 - Replace existing library search groups functionality with the new hierarchical groups system Test Plan: 1) Apply this patch set 2) Note your existing search groups have been ported over to the new __SEARCH_GROUPS__ group if you had any 3) Create the group __SEARCH_GROUPS__ if one does not already exist 4) Add some first level subgroups to this group, add libraries to those groups 5) Search the library group searching in the intranet and opac 6) Note you get the same results as pre-patch Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Conflicts: catalogue/search.pl installer/data/mysql/updatedatabase.pl opac/opac-search.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65661&action=edit Bug 16735 - Don't use objects for database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65662&action=edit Bug 16735 - Remove use of get_categories Feature using it is completely undocumented as far as my research has shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65663&action=edit Bug 16735 - Filter individual libraries from search group pulldown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65664&action=edit Bug 16735 - Filter groups without immediate child libraries from group pulldown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #56 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65665&action=edit Bug 16735 - Use libraries in all subgroups, not just immediate children -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65658|0 |1 is obsolete| | Attachment #65659|0 |1 is obsolete| | Attachment #65660|0 |1 is obsolete| | Attachment #65661|0 |1 is obsolete| | Attachment #65662|0 |1 is obsolete| | Attachment #65663|0 |1 is obsolete| | Attachment #65664|0 |1 is obsolete| | Attachment #65665|0 |1 is obsolete| | --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69533&action=edit Bug 16735 - Remove modules no longer needed Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69534&action=edit Bug 16735 - Remove tables no longer needed Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69535&action=edit Bug 16735 - Clean up sample data Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69536&action=edit Bug 16735 - Replace existing library search groups functionality with the new hierarchical groups system Test Plan: 1) Apply this patch set 2) Note your existing search groups have been ported over to the new __SEARCH_GROUPS__ group if you had any 3) Create the group __SEARCH_GROUPS__ if one does not already exist 4) Add some first level subgroups to this group, add libraries to those groups 5) Search the library group searching in the intranet and opac 6) Note you get the same results as pre-patch Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69537&action=edit Bug 16735 - Don't use objects for database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #62 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69538&action=edit Bug 16735 - Remove use of get_categories Feature using it is completely undocumented as far as my research has shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69539&action=edit Bug 16735 - Filter individual libraries from search group pulldown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69540&action=edit Bug 16735: DBIC Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69541&action=edit Bug 16735 - Use libraries in all subgroups, not just immediate children -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches have been rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19765 [Bug 19765] Special library groups should have a 'translated' title and should not be editable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69536|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69537|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69538|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69539|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69540|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69533|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69534|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69535|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #67 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69684&action=edit Bug 16735: Remove modules no longer needed Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #68 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69685&action=edit Bug 16735: Remove tables no longer needed Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #69 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69686&action=edit Bug 16735: Clean up sample data Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #70 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69687&action=edit Bug 16735: Migrate library search groups into the new hierarchical groups Test Plan: 1) Apply this patch set 2) Note your existing search groups have been ported over to the new __SEARCH_GROUPS__ group if you had any 3) Create the group __SEARCH_GROUPS__ if one does not already exist 4) Add some first level subgroups to this group, add libraries to those groups 5) Search the library group searching in the intranet and opac 6) Note you get the same results as pre-patch Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #71 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69688&action=edit Bug 16735: Don't use objects for database update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #72 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69689&action=edit Bug 16735: Remove use of get_categories Feature using it is completely undocumented as far as my research has shown. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #73 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69690&action=edit Bug 16735: Filter individual libraries from search group pulldown Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #74 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69691&action=edit Bug 16735: DBIC Schema files Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #75 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69692&action=edit Bug 16735: Use libraries in all subgroups, not just immediate children Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #76 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69693&action=edit Bug 16735: (QA followup) POD fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #77 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69694&action=edit Bug 16735: (QA followup) Fix rebase error Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #78 from Alex Buckley <alexbuckley@catalyst.net.nz> --- I have tried to apply these patches as they are a dependency for the patches on bug 19765 however I have found that the patches attached to this bug report (16735) not longer cleanly apply on an up to date branch. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 16735: Remove modules no longer needed Applying: Bug 16735: Remove tables no longer needed Applying: Bug 16735: Clean up sample data Applying: Bug 16735: Migrate library search groups into the new hierarchical groups fatal: sha1 information is lacking or useless (C4/Auth.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 16735: Migrate library search groups into the new hierarchical groups The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-16735-Migrate-library-search-groups-into-the-n-yOLkh7.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #79 from Tomás Cohen Arazi <tomascohen@gmail.com> --- It applies cleanly if you have the dependencies in your branch. This is latest master. I've applied the dependent bug (15707) manually so it is more readable: tcohen@bibliotecas-1:koha(qa_16735)$ git reset --hard origin/master HEAD is now at 03dd826757 Bug 17182: (QA follow-up) Fix call to GetMarcBiblio tcohen@bibliotecas-1:koha(qa_16735)$ git bz apply 15707 Bug 15707 - Add ability to define hierarchical groups of libraries 69573 - Bug 15707: Update DB 69574 - Bug 15707: Add Koha::Library::Group(s) modules 69575 - Bug 15707: Add library groups editor 69576 - Bug 15707: Unit Tests 69577 - Bug 15707: Fix conflict with bug 15446 (type vs _type) 69578 - Bug 15707: (QA followup) Switch to treetable which Koha already uses 69579 - Bug 15707: (QA followup) Drop table if exists 69580 - Bug 15707: (QA followup) Fix UI issues 69581 - Bug 15707: (QA followup) Remove class for treegrid 69582 - Bug 15707: (QA followup) Allow object names to be styled without impeding translation 69583 - Bug 15707: (followup) use cat-search instead of cities-search in header 69584 - Bug 15707: Switch datetimes to timestamps 69585 - Bug 15707: Add UNIQUE constraint to library groups table 69586 - Bug 15707: Updates for Bootstrap 3 69587 - Bug 15707: Display error if group title is already used 69588 - Bug 15707: DBIC Schema files 69589 - Bug 15707: (QA followup) Style buttons correctly Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15707: Update DB Applying: Bug 15707: Add Koha::Library::Group(s) modules Applying: Bug 15707: Add library groups editor Applying: Bug 15707: Unit Tests Applying: Bug 15707: Fix conflict with bug 15446 (type vs _type) Applying: Bug 15707: (QA followup) Switch to treetable which Koha already uses Applying: Bug 15707: (QA followup) Drop table if exists Applying: Bug 15707: (QA followup) Fix UI issues Applying: Bug 15707: (QA followup) Remove class for treegrid Applying: Bug 15707: (QA followup) Allow object names to be styled without impeding translation Applying: Bug 15707: (followup) use cat-search instead of cities-search in header Applying: Bug 15707: Switch datetimes to timestamps Applying: Bug 15707: Add UNIQUE constraint to library groups table Applying: Bug 15707: Updates for Bootstrap 3 Applying: Bug 15707: Display error if group title is already used Applying: Bug 15707: DBIC Schema files Applying: Bug 15707: (QA followup) Style buttons correctly tcohen@bibliotecas-1:koha(qa_16735)$ git bz apply 16735 Bug 16735 Depends on bug 15707 Follow? [(y)es, (n)o] n Bug 16735 - Replace existing library search groups functionality with the new hierarchical groups system 69684 - Bug 16735: Remove modules no longer needed 69685 - Bug 16735: Remove tables no longer needed 69686 - Bug 16735: Clean up sample data 69687 - Bug 16735: Migrate library search groups into the new hierarchical groups 69688 - Bug 16735: Don't use objects for database update 69689 - Bug 16735: Remove use of get_categories 69690 - Bug 16735: Filter individual libraries from search group pulldown 69691 - Bug 16735: DBIC Schema files 69692 - Bug 16735: Use libraries in all subgroups, not just immediate children 69693 - Bug 16735: (QA followup) POD fixes 69694 - Bug 16735: (QA followup) Fix rebase error Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 16735: Remove modules no longer needed Applying: Bug 16735: Remove tables no longer needed Applying: Bug 16735: Clean up sample data Applying: Bug 16735: Migrate library search groups into the new hierarchical groups Applying: Bug 16735: Don't use objects for database update Applying: Bug 16735: Remove use of get_categories Applying: Bug 16735: Filter individual libraries from search group pulldown Applying: Bug 16735: DBIC Schema files Applying: Bug 16735: Use libraries in all subgroups, not just immediate children Applying: Bug 16735: (QA followup) POD fixes Applying: Bug 16735: (QA followup) Fix rebase error tcohen@bibliotecas-1:koha(qa_16735)$ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #80 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches do not apply but rebased on https://github.com/joubu/Koha/commits/bug_18403 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20157 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #81 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71386&action=edit Bug 16735: Remove unecessary use of Koha::LibraryCategories in onboarding This was not used, it has been copied/pasted from admin/branches.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #82 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71393&action=edit Bug 16735: Fix POD format for Koha::Library::Groups methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #83 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Bug 16735 depends on bug 15707, which changed state. Bug 15707 Summary: Add ability to define hierarchical groups of libraries https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #84 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Enhancement, not backported to stable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 [Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20838 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 [Bug 20838] Search by group of libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20875 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 [Bug 20875] OpacAddMastheadLibraryPulldown displays an empty list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32291 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32291 [Bug 32291] What is a library category? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40535 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40535 [Bug 40535] Branches.tt view page has out of place "Category:" field -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org