https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 82331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82331&action=edit Display illrequests.medium as Request type To test: - Make sure you have an ILL request with a value in illrequests.medium - View the request in Detail view and Edit view, "N/A" is displayed for the Request type - Apply the patch - View the request in Detail and Edit view again, the value from illrequests.medium is now displayed as the Request type This patch also brings the coding around illrequests.medium more in line with the coding of similar attributes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82331|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82573&action=edit Bug 21833: Display illrequests.medium as Request type To test: - Make sure you have an ILL request with a value in illrequests.medium - View the request in Detail view and Edit view, "N/A" is displayed for the Request type - Apply the patch - View the request in Detail and Edit view again, the value from illrequests.medium is now displayed as the Request type This patch also brings the coding around illrequests.medium more in line with the coding of similar attributes. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 --- Comment #4 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- I believe this is a non-issue. Bug 20941 switched away from displaying medium in the UI since we seemingly don't use it any more, we store the material type as an illrequestattribute (the get_type function was introduced to retrieve the item's type), so I think any patches related to medium are no longer needed. Backends will need to be adapted to display the "type" illrequestattribute. I mentioned it to Magnus as I believe he's the only other backend dev. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |magnus@libriotech.no |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 Niamh Walker-Headon <Niamh.WalkerHeadon@hse.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Niamh.WalkerHeadon@hse.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Summary|Request type is not |illrequests.medium is not |displayed on ILL request |displayed on ILL request |detail page |detail page and ILL | |requests table --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think there were changes after this was filed that changed things a bit: Request type: This is now pulled from illrequestattributes.type for the big table and on the detail pages. So what we need to do now is bring back the display of illrequests.medium, because it is no longer displayed at all. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Magnus, do you want this one to remain assigned to you? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Older versions of backends might use it, it's hard to tell. We might need to have some kind of deprecation process to be on the save side. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Our own backend has quite a bit of code using the medium, but it might date back to the type when it was still used. It would certainly need some work to clean-up. What could a deprecation process look like? How and where do we anounce it and how can we make it the most visible? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833 --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #13)

Our own backend has quite a bit of code using the medium, but it might date back to the type when it was still used. It would certainly need some work to clean-up.

What could a deprecation process look like? How and where do we anounce it and how can we make it the most visible?

Katrin, very fair points. I think you're bringing up a bigger issue. Maybe we should consider a koha-ill mailing list, a koha-ill IRC chat, or something similar where these sort of topics could be discussed. As it stands, there's no way of telling how many backends exist and what they're using. Furthermore, we're also missing proper documentation on every backend capability that core checks for, and what their purpose is (e.g. "should_display_availability", "unmediated_ill", or "create_api" (this last one is only introduced in bug 30719). These are useful to know as a backend developer, because they effectively function as 'hooks' for core functionality that backends can make use of. I believe we need a place where every ILL invested individual/organization can give their input on - and become aware of - updates and changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.