http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9625 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15378&action=edit Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap This patch converts the toolbar include file used by guided/SQL report pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page in reports/ which uses reports-toolbar.inc (Saved reports, Guided reports, SQL reports). Buttons and menus should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9625 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9625 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15385|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15469&action=edit [PASSED QA] Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap This patch converts the toolbar include file used by guided/SQL report pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page in reports/ which uses reports-toolbar.inc (Saved reports, Guided reports, SQL reports). Buttons and menus should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, logic is correct. Toolbar differes, depending on the action: show report, list of reports, edit report. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9625 --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Is there a reason for the 'xx' in this line: +[% IF ( showsql || execute || editsql || save_successful ) %]xx If not -- and I don't think there is -- I will remove it prior to pushing. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9625 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #4)

Is there a reason for the 'xx' in this line: +[% IF ( showsql || execute || editsql || save_successful ) %]xx

If not -- and I don't think there is -- I will remove it prior to pushing.

Thank you, you are correct. -- You are receiving this mail because: You are watching all bug changes.