[Bug 29932] New: Phase out jquery.cookie.js: bibs_selected (Browse selected records)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29932 Bug ID: 29932 Summary: Phase out jquery.cookie.js: bibs_selected (Browse selected records) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 19290 Blocks: 27750 The "Browse selected records" feature (enabled by the BrowseResultSelection system preference) sets a "bibs_selected" cookie when the user checks items in staff interface catalog search results. This cookie can be replaced with the use of localStorage. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290 [Bug 19290] Browse selected biblios - Staff https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27750 [Bug 27750] Remove jquery.cookie.js plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29932 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129734&action=edit Bug 29932: Use localStorage instead of cookie for bibs_selected This patch replaces the use of the jquery.cookie.js plugin in the "Browse selected records" feature. The feature is modified to use localStorage instead of cookies. To test, apply the patch and go to Administration -> System preferences. - Enable the "BrowseResultSelection" system preference. - Perform a catalog search which will return multiple results. - On the search results page, check the checkbox for a number of titles. - Click the "Browse selected biblios" button in the toolbar. - You should be directed to the detail page for the first title you checked. - Clicking the right-arrow in the sidebar should take you through each one of your selected titles. - When you click the "Results" link in the sidebar you should be returned to the same search results set and the same titles should be checked. _ If you uncheck those titles and reload the page the checkboxes should remain unchecked. - If you log out of the staff interface the "bibs_selected" item in localStorage should be deleted. See, for example, https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector for information about viewing local storage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29932 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29932 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129734|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 129809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129809&action=edit Bug 29932: Use localStorage instead of cookie for bibs_selected This patch replaces the use of the jquery.cookie.js plugin in the "Browse selected records" feature. The feature is modified to use localStorage instead of cookies. To test, apply the patch and go to Administration -> System preferences. - Enable the "BrowseResultSelection" system preference. - Perform a catalog search which will return multiple results. - On the search results page, check the checkbox for a number of titles. - Click the "Browse selected biblios" button in the toolbar. - You should be directed to the detail page for the first title you checked. - Clicking the right-arrow in the sidebar should take you through each one of your selected titles. - When you click the "Results" link in the sidebar you should be returned to the same search results set and the same titles should be checked. _ If you uncheck those titles and reload the page the checkboxes should remain unchecked. - If you log out of the staff interface the "bibs_selected" item in localStorage should be deleted. See, for example, https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector for information about viewing local storage. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29932 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129809|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129858&action=edit Bug 29932: Use localStorage instead of cookie for bibs_selected This patch replaces the use of the jquery.cookie.js plugin in the "Browse selected records" feature. The feature is modified to use localStorage instead of cookies. To test, apply the patch and go to Administration -> System preferences. - Enable the "BrowseResultSelection" system preference. - Perform a catalog search which will return multiple results. - On the search results page, check the checkbox for a number of titles. - Click the "Browse selected biblios" button in the toolbar. - You should be directed to the detail page for the first title you checked. - Clicking the right-arrow in the sidebar should take you through each one of your selected titles. - When you click the "Results" link in the sidebar you should be returned to the same search results set and the same titles should be checked. _ If you uncheck those titles and reload the page the checkboxes should remain unchecked. - If you log out of the staff interface the "bibs_selected" item in localStorage should be deleted. See, for example, https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector for information about viewing local storage. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29932 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29932 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29932 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29932 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |andrew@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03,21.05.11 released in| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I see this has been pushed to 21.11. Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29932 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org