[Bug 16011] New: Remove $VERSION from our modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Bug ID: 16011 Summary: Remove $VERSION from our modules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org It has been decided to remove the $VERSION from our modules. See the discussion on http://koha.1045719.n5.nabble.com/Proposal-Deal-with-modules-versioning-VERS... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48835&action=edit Bug 16011: $VERSION - remove use vars $VERSION perl -p -i -e 's/^(use vars .*)\$VERSION\s?(.*)/$1$2/' **/*.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48835|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=edit Bug 16011: $VERSION - remove use vars $VERSION perl -p -i -e 's/^(use vars .*)\$VERSION\s?(.*)/$1$2/' **/*.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48837&action=edit Bug 16011: $VERSION - Remove the $VERSION init Mainly a perl -p -i -e 's/^.*3.07.00.049.*\n//' **/*.pm Then some adjustements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=edit Bug 16011: $VERSION - Remove comments perl -p -i -e 's/^.*set the version for version checking.*\n//' **/*.pm + manual adjustements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Intentionally there is no test plan for this patch set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Shouldn't be the whole line removed in these files? https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/BackgroundJob.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/ClassSortRoutine/Dewey.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/ClassSortRoutine/Generic.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/ClassSortRoutine/LCC.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/Matcher.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/Members/AttributeTypes.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/Members/Messaging.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/SMS.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/Koha/Borrower/Files.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/Koha/Misc/Files.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/Koha/Template/Plugin/Cache.pm_sec1 For you it's just another regexp I believe ;) Here stayd empty BEGIN block, is it necessary to keep it? Just asking ;) https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=diff#a/C4/BackgroundJob.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=diff#a/C4/Matcher.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=diff#a/C4/Members/AttributeTypes.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=diff#a/C4/Members/Messaging.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=diff#a/Koha/Borrower/Files.pm_sec1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48836|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48853&action=edit Bug 16011: $VERSION - remove use vars $VERSION perl -p -i -e 's/^(use vars .*)\$VERSION\s?(.*)/$1$2/' **/*.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48837|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48854&action=edit Bug 16011: $VERSION - Remove the $VERSION init Mainly a perl -p -i -e 's/^.*3.07.00.049.*\n//' **/*.pm Then some adjustements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48838|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48855&action=edit Bug 16011: $VERSION - Remove comments perl -p -i -e 's/^.*set the version for version checking.*\n//' **/*.pm + manual adjustements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48856&action=edit Bug 16011: $VERSION - Remove use vars qw(); perl -p -i -e 's/use vars qw\(\);\n//' **/*.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48857&action=edit Bug 16011: $VERSION - Remove empty BEGIN block perl -p -i -0 -e 's/BEGIN \{\n?\n?\}\n//' **/*.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #6)
Shouldn't be the whole line removed in these files?
Here stayd empty BEGIN block, is it necessary to keep it? Just asking ;)
Yep agreed! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- I think there are probably two more use vars qw( ); statements (note the space between parenthesis) in files: Koha/Template/Plugin/Cache.pm C4/SMS.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Upon initial review, this looks like it's on the right track and t/db_dependent/00-strict.t passes. I note that Koha::SuggestionEngine::* plugins include a ->VERSION() method, but that's not strictly on point for this particular bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48856|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48954&action=edit Bug 16011: $VERSION - Remove use vars qw(); perl -p -i -e 's/use vars qw\(\s*\);\n//' **/*.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48857|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48955&action=edit Bug 16011: $VERSION - Remove empty BEGIN block perl -p -i -0 -e 's/BEGIN \{\n?\n?\}\n//' **/*.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #13)
I think there are probably two more use vars qw( ); statements (note the space between parenthesis) in files:
Koha/Template/Plugin/Cache.pm
C4/SMS.pm
Patch amended. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48853|0 |1 is obsolete| | --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 48956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48956&action=edit Bug 16011: $VERSION - remove use vars $VERSION perl -p -i -e 's/^(use vars .*)\$VERSION\s?(.*)/$1$2/' **/*.pm Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48854|0 |1 is obsolete| | --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 48957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48957&action=edit Bug 16011: $VERSION - Remove the $VERSION init Mainly a perl -p -i -e 's/^.*3.07.00.049.*\n//' **/*.pm Then some adjustements Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48855|0 |1 is obsolete| | --- Comment #20 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 48958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48958&action=edit Bug 16011: $VERSION - Remove comments perl -p -i -e 's/^.*set the version for version checking.*\n//' **/*.pm + manual adjustements Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48954|0 |1 is obsolete| | --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 48959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48959&action=edit Bug 16011: $VERSION - Remove use vars qw(); perl -p -i -e 's/use vars qw\(\s*\);\n//' **/*.pm Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48955|0 |1 is obsolete| | --- Comment #22 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 48960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48960&action=edit Bug 16011: $VERSION - Remove empty BEGIN block perl -p -i -0 -e 's/BEGIN \{\n?\n?\}\n//' **/*.pm Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The QA tools report some problems: FAIL t/Koha/Plugin/Test.pm OK critic OK forbidden patterns OK pod OK spelling FAIL valid Global symbol "$VERSION" requires explicit package name t/Koha/Plugin/Test.pm had compilation errors. FAIL C4/External/BakerTaylor.pm OK critic OK forbidden patterns OK pod OK spelling FAIL valid C4/External/BakerTaylor.pm had compilation errors. Global symbol "$VERSION" requires explicit package name Can you please check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49387&action=edit Bug 16011: Reintroduce $VERSION for 2 pm These files should be managed on their own bug reports. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48956|0 |1 is obsolete| | --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49441&action=edit Bug 16011: $VERSION - remove use vars $VERSION perl -p -i -e 's/^(use vars .*)\$VERSION\s?(.*)/$1$2/' **/*.pm Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48957|0 |1 is obsolete| | --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49442&action=edit Bug 16011: $VERSION - Remove the $VERSION init Mainly a perl -p -i -e 's/^.*3.07.00.049.*\n//' **/*.pm Then some adjustements Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48958|0 |1 is obsolete| | --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49443&action=edit Bug 16011: $VERSION - Remove comments perl -p -i -e 's/^.*set the version for version checking.*\n//' **/*.pm + manual adjustements Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48959|0 |1 is obsolete| | --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49444&action=edit Bug 16011: $VERSION - Remove use vars qw(); perl -p -i -e 's/use vars qw\(\s*\);\n//' **/*.pm Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48960|0 |1 is obsolete| | --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49445&action=edit Bug 16011: $VERSION - Remove empty BEGIN block perl -p -i -0 -e 's/BEGIN \{\n?\n?\}\n//' **/*.pm Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49387|0 |1 is obsolete| | --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49446&action=edit Bug 16011: Reintroduce $VERSION for 2 pm These files should be managed on their own bug reports. Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #31 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #32 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 49630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49630&action=edit Patch for missing declartaion in BakerTaylor This patch corrects a bug introduced in the last patch with caused BakerTaylor.pm to fail to compile resulting in make test failing. VERSION needed to be declared -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49630|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49633&action=edit Bug 16011 reintroduced VERSION variable needs declaration $VERSION reintroduced into External/BakerTaylor.pm but was not declared. Causes tests to fail. Readd VERSION to the package vars Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #34 from Brendan Gallagher <brendan@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #33)
Created attachment 49633 [details] [review] Bug 16011 reintroduced VERSION variable needs declaration
$VERSION reintroduced into External/BakerTaylor.pm but was not declared. Causes tests to fail. Readd VERSION to the package vars
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Last patch pushed - Mar 29th 2016 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org