[Bug 18251] New: SCO alerts - need a trigger for successful checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Bug ID: 18251 Summary: SCO alerts - need a trigger for successful checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Failed checkouts on the sco can be triggered by presence of alert, however, we have no feedback for a successful checkout. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61040&action=edit Bug 18251 - SCO alerts - need a trigger for successful checkouts This patch adds simple text and a div to allow for sounds to be configured upon successful SCO checkout To test: 1 - Enable sco module 2 - Enable AudioAlerts 3 - Define alert with Selector: .sco-alert-success Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg 4 - Checkout to patron using SCO 5 - Note only feedback is a addition of item to checkouts list 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16732 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732 [Bug 16732] Add audio alerts (custom sound notifications) to web based self checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16732 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61040|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 61211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61211&action=edit Bug 18251 - SCO alerts - need a trigger for successful checkouts This patch adds simple text and a div to allow for sounds to be configured upon successful SCO checkout To test: 1 - Enable sco module 2 - Enable AudioAlerts 3 - Define alert with Selector: .sco-alert-success Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg 4 - Checkout to patron using SCO 5 - Note only feedback is a addition of item to checkouts list 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out Followed test plan, works as expected. (Works with external sound only, see Bug 16732) Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Should not it be an id instead of a class? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- And maybe the message should be in a box, to make it more visible. At the moment it is quite hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #5 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #3)
Should not it be an id instead of a class?
The alerts were introduced with Bug 11431, the triggers are in a class, e.g. https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44395&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt_sec1 <div id="circ_needsconfirmation" class="dialog alert audio-alert-action"> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11431 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61262&action=edit Bug 18251 (QA Followup) Add alert box to checkout message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I understand that your patch fixes your need, but to me it's now inconsistent. We get a confirmation message for checkouts, but for checkins... Do not you think we should get confirmation messages for all the sco possible actions? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #7)
Do not you think we should get confirmation messages for all the sco possible actions?
I do agree with this, we should give more feedback rather than less. Take this one as a start and open new bugs for other actions? Or would you prefer everything on one report? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I'd prefer to deal with everything here, the changes should not be big. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61324&action=edit Bug 18251 (QA Followup) Add alerts for all SCO actions To test: Add sound alerts for sco-alert-warning Test various actions (return,renew) and verify success/failure notices and sounds Note additional classes (return,renew,issue) to allow for more specificity of sounds alerts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, I never see the "renewed" message. I am wondering if there is not something broken somewhere. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 61343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61343&action=edit SCO renew button triggers a checkout (In reply to Jonathan Druart from comment #11)
Nick, I never see the "renewed" message. I am wondering if there is not something broken somewhere.
Looking at the form details for renewing I see 'checkout' in hidden field 'op', see screenshot attached. Would expect an op like 'renew'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61665&action=edit Bug 18251 - (QA Followup) Add 'renew' operation and check renewal vs checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- In that case we could remove the confirmed param in the template, do you confirm? I can followup on QAing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61211|0 |1 is obsolete| | Attachment #61262|0 |1 is obsolete| | Attachment #61324|0 |1 is obsolete| | Attachment #61665|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61715&action=edit Bug 18251 - SCO alerts - need a trigger for successful checkouts This patch adds simple text and a div to allow for sounds to be configured upon successful SCO checkout To test: 1 - Enable sco module 2 - Enable AudioAlerts 3 - Define alert with Selector: .sco-alert-success Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg 4 - Checkout to patron using SCO 5 - Note only feedback is a addition of item to checkouts list 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out Followed test plan, works as expected. (Works with external sound only, see Bug 16732) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61716&action=edit BUg 18251 (QA Followup) Add alert box to checkout message Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61717&action=edit Bug 18251 (QA Followup) Add alerts for all SCO actions To test: Add sound alerts for sco-alert-warning Test various actions (return,renew) and verify success/failure notices and sounds Note additional classes (return,renew,issue) to allow for more specificity of sounds alerts Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61718&action=edit Bug 18251 - (QA Followup) Add 'renew' operation and check renewal vs checkout Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #14)
In that case we could remove the confirmed param in the template, do you confirm? I can followup on QAing.
Wrong, we need it to avoid the call to CanBookBeIssued. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hold on, do not push please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18349 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Will need to be rebased on top of bug 18349. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61715|0 |1 is obsolete| | Attachment #61716|0 |1 is obsolete| | Attachment #61717|0 |1 is obsolete| | Attachment #61718|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 66186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66186&action=edit Bug 18251 - SCO alerts - need a trigger for successful checkouts This patch adds simple text and a div to allow for sounds to be configured upon successful SCO checkout To test: 1 - Enable sco module 2 - Enable AudioAlerts 3 - Define alert with Selector: .sco-alert-success Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg 4 - Checkout to patron using SCO 5 - Note only feedback is a addition of item to checkouts list 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out Followed test plan, works as expected. (Works with external sound only, see Bug 16732) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 66187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66187&action=edit BUg 18251 (QA Followup) Add alert box to checkout message Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 66188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66188&action=edit Bug 18251 (QA Followup) Add alerts for all SCO actions To test: Add sound alerts for sco-alert-warning Test various actions (return,renew) and verify success/failure notices and sounds Note additional classes (return,renew,issue) to allow for more specificity of sounds alerts Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 66189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66189&action=edit Bug 18251 - (QA Followup) Add 'renew' operation and check renewal vs checkout Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- One pair of eyes is missing here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tried testing this, but ran into some problems: 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out I don't see the note in 9. Also renewals for me don't work. I tried to check out an item and immediately renew it. Nothing happens when I click on "renew item" - so I can't test this part. It's the same with and without the patch. Can someone confirm this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Filed bug 19187 - figured out it was OpacRenewalAllowed. Renewals are ok (sound and note), but no sound and note for successful checkouts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85409&action=edit Bug 18251: (follow-up) fix rebase error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22378 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378 [Bug 22378] Fix sound alerts on SCO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66186|0 |1 is obsolete| | Attachment #66187|0 |1 is obsolete| | Attachment #66188|0 |1 is obsolete| | Attachment #66189|0 |1 is obsolete| | Attachment #85409|0 |1 is obsolete| | --- Comment #30 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85603&action=edit Bug 18251: SCO alerts - need a trigger for successful checkouts This patch adds simple text and a div to allow for sounds to be configured upon successful SCO checkout To test: 1 - Enable sco module 2 - Enable AudioAlerts 3 - Define alert with Selector: .sco-alert-success Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg 4 - Checkout to patron using SCO 5 - Note only feedback is a addition of item to checkouts list 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out Followed test plan, works as expected. (Works with external sound only, see Bug 16732) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #31 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85604&action=edit Bug 18251: (QA follow-up) Add alert box to checkout message Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #32 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85605&action=edit Bug 18251: (QA follow-up) Add alerts for all SCO actions To test: Add sound alerts for sco-alert-warning Test various actions (return,renew) and verify success/failure notices and sounds Note additional classes (return,renew,issue) to allow for more specificity of sounds alerts Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #33 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85606&action=edit Bug 18251: (QA follow-up) Add 'renew' operation and check renewal vs checkout Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #34 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85607&action=edit Bug 18251: (follow-up) fix rebase error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Signed Off |Failed QA --- Comment #35 from Josef Moravec <josef.moravec@gmail.com> --- I rebased the patchset as there were some minor conflicts. The patchset works as described, but I think it should be adapted to play internal sounds too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Josef Moravec from comment #35)
I rebased the patchset as there were some minor conflicts. The patchset works as described, but I think it should be adapted to play internal sounds too.
I don't disagree with this, but I would consider it a separate issue. We will need to decide how we want to handle these. Copy all files to the opac directories? Build the full path to the intranet versions? Move the sounds to a new share directory? As there is some decision to be made I think we can do it on a new bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22406 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22406 [Bug 22406] Add ability to play internal sounds in self checkout system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #37 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Nick Clemens from comment #36)
(In reply to Josef Moravec from comment #35)
I rebased the patchset as there were some minor conflicts. The patchset works as described, but I think it should be adapted to play internal sounds too.
I don't disagree with this, but I would consider it a separate issue.
We will need to decide how we want to handle these. Copy all files to the opac directories? Build the full path to the intranet versions? Move the sounds to a new share directory? As there is some decision to be made I think we can do it on a new bug
I created new report, see bug 22406. As you pointed out, there are some decisions needed and we don't block this patchset with it. So I am returning this to the queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85603|0 |1 is obsolete| | Attachment #85604|0 |1 is obsolete| | Attachment #85605|0 |1 is obsolete| | Attachment #85606|0 |1 is obsolete| | Attachment #85607|0 |1 is obsolete| | --- Comment #38 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85616&action=edit Bug 18251: SCO alerts - need a trigger for successful checkouts This patch adds simple text and a div to allow for sounds to be configured upon successful SCO checkout To test: 1 - Enable sco module 2 - Enable AudioAlerts 3 - Define alert with Selector: .sco-alert-success Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg 4 - Checkout to patron using SCO 5 - Note only feedback is a addition of item to checkouts list 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out Followed test plan, works as expected. (Works with external sound only, see Bug 16732) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #39 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85617&action=edit Bug 18251: (QA follow-up) Add alert box to checkout message Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #40 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85618&action=edit Bug 18251: (QA follow-up) Add alerts for all SCO actions To test: Add sound alerts for sco-alert-warning Test various actions (return,renew) and verify success/failure notices and sounds Note additional classes (return,renew,issue) to allow for more specificity of sounds alerts Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #41 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85619&action=edit Bug 18251: (QA follow-up) Add 'renew' operation and check renewal vs checkout Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #42 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85620&action=edit Bug 18251: (follow-up) fix rebase error Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement won't be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Bug 18251 depends on bug 22378, which changed state. Bug 22378 Summary: Fix sound alerts on SCO https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds new release notes| |triggers to ease defining | |custom sounds/alerts for | |the self checkout module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #45 from David Cook <dcook@prosentient.com.au> --- This appears to contribute to the problem in Bug 26301... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26301 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org