https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162715&action=edit Bug 36221: Preparation This refactors the code for more DRY -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36197 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 [Bug 36197] Allow for OPAC unauthenticated ILL request -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, nugged@gmail.com, | |tomascohen@gmail.com, | |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve styling of Standard |Improve styling of Standard |backend create form |backend create OPAC form -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35604 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 [Bug 35604] ILL - Allow for automatic backend selection -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162933|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162715|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162716|0 |1 is obsolete| | --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162949&action=edit Bug 36221: OPAC Styling Test plan, dont apply patches yet: 1) Enable ILLModule 2) Create a new OPAC ILL request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?method=create&backend=Standard 3) Notice the style. Apply patches. Repeat Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36282 [Bug 36282] OPAC - Remove trailing and leading blank space from translated strings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162971&action=edit Bug 36221: Update 'Create' button class btn-primary should be used here, not btn-default -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162948|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165462&action=edit Bug 36221: Preparation This refactors the code for more DRY Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162970|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165464&action=edit Bug 36221: Move patron section to top of create form -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #17 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173706&action=edit Bug 36221: (QA follow-up): Fix year value -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165463|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173753&action=edit Bug 36221: OPAC Styling Test plan, dont apply patches yet: 1) Enable ILLModule 2) Create a new OPAC ILL request, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?method=create&backend=Standard 3) Notice the style. Apply patches. Repeat Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165465|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173755&action=edit Bug 36221: Update 'Create' button class btn-primary should be used here, not btn-default Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Just another signoff.. hoping Victor finished QA today -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |roadmap_24_05, | |roadmap_24_11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #25 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

<input class="form-control input-fluid" type="article" [...]>

Happens on staff interface also. The origin is form_input_helpers.inc => BLOCK ill_text_input_field -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It seems placeholder values should have been extracted as translatable strings directly. Oh, it's not even about placeholders. When changing the language, the Create and Cancel button are still untranslated. That might be that having .inc files in Koha/ILL/Backend can't work. The translation deployment script don't even have a place to copy the .inc files and translate them. But it's a problem that made through some previous ticket and not this one. So here there is no problem about the placeholders in the .inc files. (is there a ticket about this? didn't found one but I'm not sure about my search) There is still a problem about those in shared-includes/shared.js Solution: https://wiki.koha-community.org/wiki/Coding_Guidelines#JS2:_Enabling_transla... https://wiki.koha-community.org/wiki/Coding_Guidelines#JS5:_Enabling_transla... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #30 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173940&action=edit Bug 36221: (QA follow-up): Apply styling improvements to DVD qa tools throw: ill_text_input_field: not found But I believe this is a false positive. We can clearly see it working by going to: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard And picking 'DVD' or any other type. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #32 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks for the follow-ups :) Almost everything looks good. Remains some OPAC styling that ended up in the staff interface: https://pic.infini.fr/jf8dBvZK/BhOdvYNu.png It's when making a request with custom fields, then editing it's item metadata and adding fields. The new ones are added with the OPAC style. In the screenshot, I emptied the fields that were already populated (FOREACH key IN keys) to best compare them with the ones added by the JS. Bad news, this is true on the staff page: ( opac ? 'form-control input-fluid custom-field-input' : '') + console.log(opac) => Array [] ----- Testing notes, to have custom field pre populated in the OPAC, use a request like this (thanks Pedro): http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?atitle=Music%20in%20an%20Emergent%20History%20of%20Psychology.&aulast=Klempe%20SH&backend=Standard&cardnumber=kohaadmin&custom_field=example1&date=2024&doi=10.1007%2Fs12124-023-09778-9&genre=article&issn=19363567&issue=1&custom_field2=example2&method=create&opac=1&openurl=1&pages=1-11&spage=1&title=Integrative%20psychological%20%26%20behavioral%20science&volume=58 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #34 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

In the screenshot, I emptied the fields that were already populated (FOREACH key IN keys) to best compare them with the ones added by the JS.

Which showed the edited fields having no placeholder and the new empty ones having one. Above patch fixed this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173752|0 |1 is obsolete| | --- Comment #36 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 174017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174017&action=edit Bug 36221: Preparation This refactors the code for more DRY Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173940|0 |1 is obsolete| | --- Comment #38 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 174019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174019&action=edit Bug 36221: (QA follow-up): Apply styling improvements to DVD qa tools throw: ill_text_input_field: not found But I believe this is a false positive. We can clearly see it working by going to: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard And picking 'DVD' or any other type. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173755|0 |1 is obsolete| | --- Comment #40 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 174021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174021&action=edit Bug 36221: Update 'Create' button class btn-primary should be used here, not btn-default Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173939|0 |1 is obsolete| | --- Comment #42 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 174023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174023&action=edit Bug 36221: (QA follow-up): Fix incorrect input type on HTML Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173965|0 |1 is obsolete| | --- Comment #44 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 174025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174025&action=edit Bug 36221: (QA follow-up): add placeholder attr to staff custom fields In the prepopulated fields when editing item metadata that had custom fields (tt generated). So it's consistent when adding new empty fields (done in JS) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #46 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 174027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174027&action=edit Bug 36221: (QA follow-up): fix space between the 2 custom fields <input> It was missing in the JS that adds new empty custom fields. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please check: FAIL Koha/ILL/Backend/intra-includes/create.inc FAIL valid_template /shared-includes/form_input_helpers.inc: not found FAIL Koha/ILL/Backend/intra-includes/edititem.inc FAIL valid_template /shared-includes/form_input_helpers.inc: not found FAIL Koha/ILL/Backend/opac-includes/create.inc FAIL valid_template /shared-includes/form_input_helpers.inc: not found OK Koha/ILL/Backend/shared-includes/custom_fields.inc OK Koha/ILL/Backend/shared-includes/form_input_helpers.inc FAIL Koha/ILL/Backend/shared-includes/forms/article.inc FAIL valid_template journal_text_input_fields: not found FAIL Koha/ILL/Backend/shared-includes/forms/book.inc FAIL valid_template book_text_input_fields: not found FAIL Koha/ILL/Backend/shared-includes/forms/chapter.inc FAIL valid_template book_text_input_fields: not found FAIL Koha/ILL/Backend/shared-includes/forms/conference.inc FAIL valid_template ill_text_input_field: not found FAIL Koha/ILL/Backend/shared-includes/forms/dvd.inc FAIL valid_template ill_text_input_field: not found FAIL Koha/ILL/Backend/shared-includes/forms/journal.inc FAIL valid_template journal_text_input_fields: not found FAIL Koha/ILL/Backend/shared-includes/forms/resource.inc FAIL valid_template ill_text_input_field: not found FAIL Koha/ILL/Backend/shared-includes/forms/thesis.inc FAIL valid_template ill_text_input_field: not found -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #47)

Works, makes sense, QA script happy, code looks good, passing QA :)

QA script was not happy for me - could it be a change from another bug changing things? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #52 from Owen Leonard <oleonard@myacpl.org> --- This has some interface issues that require follow-ups: - We don't use an asterisk to denote required fields. In the OPAC you should add a hint after the form field: <div class="required_label required">Required</div> - The dropdown menus don't look right. There's no dropdown indicator (a down arrow). It wasn't immediately obvious to me why not! - Can we add client-side form validation? Or at least 'required="required"' to trigger the browser's built-in validation? - Error messages should be styled like error messages, using a div with the classes "alert alert-warning" - Capitalization rules should be followed, e.g. "Please Note" should be "Please note" - Do we need both the heading "New interlibrary loan request" and the heading "Create a manual ILL request"? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #54 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #52)

- The dropdown menus don't look right. There's no dropdown indicator (a down arrow). It wasn't immediately obvious to me why not!

The <select>s need the "form-select" class! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #56 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174385&action=edit Bug 36221: (follow-up) Style and markup fixes This patch makes several changes to make the updated forms more consistent with how other pages work: - Form labels should have ":" after them. - Form fields should have a hint when they are required. - Required fields should not be indicated with an asterisk. - In the OPAC, <select> should have a "form-select" class if the form is otherwise being styled with Bootstrap classes. - Primary submit buttons should have a "btn btn-primary" class. - The Font Awesome 6 icon for a delete operation is "fa-trash-can." - Error messages should be wrapped in <div class="alert alert-warning">. - All language strings in JS files should be wrapped in __(''). - Terminology: "Library" instead of "Branch," "Patron" instead of "Member." -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174385|0 |1 is obsolete| | --- Comment #58 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174398&action=edit Bug 36221: (follow-up) Style and markup fixes This patch makes several changes to make the updated forms more consistent with how other pages work: - Form labels should have ":" after them. - Form fields should have a hint when they are required. - Required fields should not be indicated with an asterisk. - In the OPAC, <select> should have a "form-select" class if the form is otherwise being styled with Bootstrap classes. - Primary submit buttons should have a "btn btn-primary" class. - The Font Awesome 6 icon for a delete operation is "fa-trash-can." - Error messages should be wrapped in <div class="alert alert-warning">. - All language strings in JS files should be wrapped in __(''). - Terminology: "Library" instead of "Branch," "Patron" instead of "Member." Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #59)

Hi guys thanks for your time and input here.

I've submitted patches to 35570 (as requested by Katrin, not yet pushed) that contain fixes to some of the issues being raised here (terminology, translation, etc): https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter. html&bug=35570&attachment=173916 https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter. html&bug=35570&attachment=173917 https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter. html&bug=35570&attachment=173918

Up to RM what to pick and push but it's a bit of a shame we're fixing the same things in different places and overlapping in time investment. If my follow-ups on bug 35570 have gone unnoticed then please let me know what I should've done differently.

I'm on board with everything Owen is suggesting, and added my sign-off to his patch. Please let me know what else is required of me to help move this.

I am sorry, that one is on me. It's hard to keep all things in mind. What helps so that I don't miss a follow-up is to set it back to PQA. That way I WILL stumble upon it again next time I push usually and it won't be missed for sure. I'll try to see if I can resolve any possible conflicts. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #61 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed some more "Please Note". This here is not correctI bleive with the mix of concatentation and __() + $('#custom-warning').text(__('The name "' + val + '" is not permitted')).show(); Can you please follow-up on this? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #61)

Fixed some more "Please Note".

This here is not correctI bleive with the mix of concatentation and __()

+ $('#custom-warning').text(__('The name "' + val + '" is not permitted')).show();

Can you please follow-up on this?

To verify I did a gulp po:update --lang de-DE cd misc/translator/po git grep "is not permitted" but it didn't show up. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #64 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38340 --- Comment #66 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #62)

(In reply to Katrin Fischer from comment #61)

...

Fixed some more "Please Note".

This here is not correctI bleive with the mix of concatentation and __()

+ $('#custom-warning').text(__('The name "' + val + '" is not permitted')).show();

Can you please follow-up on this?

To verify I did a gulp po:update --lang de-DE cd misc/translator/po git grep "is not permitted" but it didn't show up.

I may be wrong, but I think this will never work, because gulpfile.js is extracting messages from the following dirs: 'koha-tmpl/intranet-tmpl/prog/js/vue/**/*.vue', 'koha-tmpl/intranet-tmpl/prog/js/**/*.js', 'koha-tmpl/opac-tmpl/bootstrap/js/**/*.js', And shared.js we're talking about here is located in: 'Koha/ILL/Backend/shared-includes/shared.js' I've filed bug 38340 a few days ago for this. These files in Standard backend are designed as DRY, to use the same form logic and javscript for OPAC+Staff. I think the quick fix would be to duplicate these assets and move each set to their respective koha-tmpl/intranet|opac-tmpl directories, but this would be duplicating code. Ideally, with bug 35716, we could move these but not have them duplicated, but I don't think bug 35716 is trivial. Thoughts? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #67 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174454&action=edit Bug 36221: (QA follow-up): Fix translation entry concat -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #69 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #66)

(In reply to Katrin Fischer from comment #62)

...

(In reply to Katrin Fischer from comment #61)

...

Fixed some more "Please Note".

This here is not correctI bleive with the mix of concatentation and __()

+ $('#custom-warning').text(__('The name "' + val + '" is not permitted')).show();

Can you please follow-up on this?

To verify I did a gulp po:update --lang de-DE cd misc/translator/po git grep "is not permitted" but it didn't show up.

I may be wrong, but I think this will never work, because gulpfile.js is extracting messages from the following dirs: 'koha-tmpl/intranet-tmpl/prog/js/vue/**/*.vue', 'koha-tmpl/intranet-tmpl/prog/js/**/*.js', 'koha-tmpl/opac-tmpl/bootstrap/js/**/*.js',

And shared.js we're talking about here is located in: 'Koha/ILL/Backend/shared-includes/shared.js'

I've filed bug 38340 a few days ago for this. These files in Standard backend are designed as DRY, to use the same form logic and javscript for OPAC+Staff. I think the quick fix would be to duplicate these assets and move each set to their respective koha-tmpl/intranet|opac-tmpl directories, but this would be duplicating code. Ideally, with bug 35716, we could move these but not have them duplicated, but I don't think bug 35716 is trivial. Thoughts?

I think a quick fix for stable releases would be good as this also affects the OPAC (= end users) and then we need to work on a proper fix for the shared assets for 25.05 maybe? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #71 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- reverted = switched: if (core.indexOf(val.toLowerCase()) > -1) { $('#custom-warning').text(__("The name '%s' is not permitted").format(val)).show(); ... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #72 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 --- Comment #74 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Katrin Fischer from comment #70)

Small glitch: I have reverted the quotes. Strings need to be in "", so that languages like French using ' inside strings don't break translations (see coding guidelines).

Oh no, almost all stuff above are actually follow-ups for bug 35570. But the issue about simple quotes also applies to changes from this very bug! - '<input type="text" class="custom-name" name="custom_key">' + - '<input type="text" id="custom-value" name="custom_value"> '+ + '<input type="text" class="custom-name ' + + ( opac ? 'form-control input-fluid custom-field-input' : '') + + '" name="custom_key" placeholder="'+__('key')+'">' + + ' ' + + '<input type="text" id="custom-value" name="custom_value" class="' + + ( opac ? 'form-control input-fluid custom-field-input' : '') +'" placeholder="'+__('value')+'"> ' + It might be tricky with the HTML attribute values being double quoted. And maybe Bug 13768 is relevant. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This makes various release notes| |improvements to the ILL | |request form in the OPAC to | |make it more consistent | |with the other forms in | |Koha. This includes fixes | |to the styling of required | |fields, terminology and | |translations. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Bug 36221 depends on bug 35725, which changed state. Bug 35725 Summary: Generic master form does not keep patron and cardnumber when changing type https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #76 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Screenshots recently updated in the Manual; no need for any further updates. -- You are receiving this mail because: You are watching all bug changes.