[Bug 17161] New: Making 'preview MARC' links show as buttons in batch record mod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161 Bug ID: 17161 Summary: Making 'preview MARC' links show as buttons in batch record mod Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54726&action=edit Bug 17161: Making 'Preview MARC' links show as buttons in batch record modification This patch removes the column heading and makes all links show as font awesome buttons. I have also changed the wording from Preview MARC to Show MARC to shorten the button and be consistent with other places in Koha To test: 1) Go to Tools -> Batch record modification 2) Put in some record numbers and click Continue 3) Ensure column heading 'Preview' no longer shows, and buttons are showing with an appropriate icon. Confirm button still works as expected. 4) Confirm button does not wrap on narrower browser Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt@gmail.com |aleishaamohia@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54726|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 54751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54751&action=edit Bug 17161: Making 'Preview MARC' links show as buttons in batch record modification This patch removes the column heading and makes all links show as font awesome buttons. I have also changed the wording from Preview MARC to Show MARC to shorten the button and be consistent with other places in Koha To test: 1) Go to Tools -> Batch record modification 2) Put in some record numbers and click Continue 3) Ensure column heading 'Preview' no longer shows, and buttons are showing with an appropriate icon. Confirm button still works as expected. 4) Confirm button does not wrap on narrower browser Sponsored-by: Catalyst IT Works as described Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54751|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54772&action=edit Bug 17161: Making 'Preview MARC' links show as buttons in batch record modification This patch removes the column heading and makes all links show as font awesome buttons. I have also changed the wording from Preview MARC to Show MARC to shorten the button and be consistent with other places in Koha To test: 1) Go to Tools -> Batch record modification 2) Put in some record numbers and click Continue 3) Ensure column heading 'Preview' no longer shows, and buttons are showing with an appropriate icon. Confirm button still works as expected. 4) Confirm button does not wrap on narrower browser Sponsored-by: Catalyst IT Works as described Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54773&action=edit Bug 17161: Add missing td tag Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Aleisha, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17161 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.04. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org