https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29422 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30113 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34352 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153874&action=edit Bug 34352: Add allowyear to flatpickr options An attempt at allowing four digit years to be entered into the flatpickr bound date filter input. However, we're triggering at the wrong stage and I'm not sure where else to look right now :(. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34352 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The first patch here enables the flatpickr for `type: "date"` columns in our datatables wrapper (this can be tested on the patron search results page, where we already set date types for dateofbirth and expirationdate fields in bug 34226). However, the caveat is this allows only fully formed dates to be input which prevents end users from filtering on year only (or day, or month for that matter). Jonathan raised this as a possible issue and so I tried to update flatpickr to allow 4 digit dates to be entered into the input box.. I failed however, but my attempt is attached in case anyone wants to give it a try. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34352 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply. I'd be happy to revisit this myself if I can ever get Bug 33703 in. :P -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34352 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Moving this to In Discussion rather than leaving it as 'Patch doesn't apply': a straight rebase wouldn't get us there, this needs reworking against how main looks now. What I found: - Main still has no flatpickr in the DataTables column filters: every searchable column gets a plain text input, and a column with type 'date' only has the typed value converted with $date_to_rfc3339 when the query is built. - The second patch (allowyear) was an unfinished experiment, as its own commit message says. It also has a bug: new RegExp('^\d{4}$') in a JS string loses the backslash, so it never matches a four digit year, and it leaves a console.log behind. - The first patch only added calendar.inc to patron-search.inc. Since bug 33568, type 'date' is used by more DataTables on the staff side (holdshistory, the items table in catalogue detail, batch_modify_holds, transferstoreceive, pendingbookings as well as patron search), and apply_flatpickr lives in calendar.inc, so each of those would need it loaded. The patch also runs apply_flatpickr over every .flatpickr on the page rather than only the filter inputs. - calendar.inc's flatpickr defaults now add an altInput and a maskito date input mask. That mask is in conflict with the original wish to filter on a year only (or a month/day), so that needs an explicit decision. I'd still like to do this, but it isn't a priority right now and it would need rebuilding rather than rebasing the 2023 patches. If someone wants to pick it up (or has an opinion on full dates vs partial dates in these filters), please do say. -- You are receiving this mail because: You are watching all bug changes.