[Bug 31056] New: Unable to 'Close and export as PDF' a basket group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Bug ID: 31056 Summary: Unable to 'Close and export as PDF' a basket group Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org The button to 'Close and export as PDF' in the basket groups page seems to be broken. To test: 0) Make sure to have budgets, funds, and vendors set up in the acquisitions module 1) Go to Acquisitions 2) Search for a vendor 3) Create a new basket 4) Add materials to the basket 5) Close the basket (do NOT create a basket group at this time) 6) Click on the Basket groups tab on the left 7) Create a new basket group and add the basket (do NOT check the 'close basket group' box) 8) From the open basket groups list, click 'Close and export as PDF' --> Nothing happens In order to export as PDF, you have to edit the basket group, check the 'Close basket group' box, save and then export as PDF. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32935 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146461&action=edit Bug 31056: Restore closeandprint function on basketgroups page Bug 13614 removed the basketgroup.js asset from the basket group page. This file includes the closeandprint function used for closing and printing the PDF from the open basket groups tab. The patch restores just this function directly in the file where it's needed as this is the only spot and it's only a few lines. The rest of basketgroup.js appears unused. To test: * Create a basket with one or more oder lines * Close the basket and check the checkbox to add it to a basket group * Reopen the basket group from the basket groups page * Verify the close and print only leads to a JS error and nothing happens * Apply patch * Repeat and verify you can now 'Close and print' from the open basket group tab * Verify all other buttons work as expected as well -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13614 Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Keywords| |regression Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 [Bug 13614] Replace usage of YUI on basket groups page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146461|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 146507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146507&action=edit Bug 31056: Restore closeandprint function on basketgroups page Bug 13614 removed the basketgroup.js asset from the basket group page. This file includes the closeandprint function used for closing and printing the PDF from the open basket groups tab. The patch restores just this function directly in the file where it's needed as this is the only spot and it's only a few lines. The rest of basketgroup.js appears unused. To test: * Create a basket with one or more oder lines * Close the basket and check the checkbox to add it to a basket group * Reopen the basket group from the basket groups page * Verify the close and print only leads to a JS error and nothing happens * Apply patch * Repeat and verify you can now 'Close and print' from the open basket group tab * Verify all other buttons work as expected as well Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Caroline Cyr La Rose from comment #3)
Thanks Katrin!
You are very welcome! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I don't understand, it's in koha-tmpl/intranet-tmpl/prog/js/basketgroup.js:function closeandprint(bg){ You are not supposed to redefine it here. The js file still exists, but never used I think you may simply need to re-add it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #5)
I don't understand, it's in
koha-tmpl/intranet-tmpl/prog/js/basketgroup.js:function closeandprint(bg){
You are not supposed to redefine it here.
The js file still exists, but never used
I think you may simply need to re-add it.
I explained that in the commit message: Bug 13614 removed the basketgroup.js asset from the basket group page. This file includes the closeandprint function used for closing and printing the PDF from the open basket groups tab. The patch restores just this function directly in the file where it's needed as this is the only spot and it's only a few lines. The rest of basketgroup.js appears unused. And I also filed bug 32935 to remove basketgroup.js. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146507|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147192&action=edit Bug 31056: Restore closeandprint function on basketgroups page Bug 13614 removed the basketgroup.js asset from the basket group page. This file includes the closeandprint function used for closing and printing the PDF from the open basket groups tab. The patch restores just this function directly in the file where it's needed as this is the only spot and it's only a few lines. The rest of basketgroup.js appears unused. To test: * Create a basket with one or more oder lines * Close the basket and check the checkbox to add it to a basket group * Reopen the basket group from the basket groups page * Verify the close and print only leads to a JS error and nothing happens * Apply patch * Repeat and verify you can now 'Close and print' from the open basket group tab * Verify all other buttons work as expected as well Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> JD Amended patch: fix indentation and spacing Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- PQA as it restores the exact same function that existed already, but this sleep 3s is wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 32077 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org