[Bug 30407] New: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Bug ID: 30407 Summary: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com This can be used to instruct staff how the item should handled when it's checked in. For example items notforloan status has been changed as "Invoiced item" while item has been on loan. When it's checked in staff sees that they should put item aside for further processing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 132554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132554&action=edit Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description This can be used to instruct staff how the item should handled when it's checked in. For example items notforloan status has been changed as "Invoiced item" while item has been on loan. When it's checked in staff sees that they should put item aside for further processing. To test: 1. Apply patch and update database if needed 2. Set items notforloan status as -1 (or create new one) 3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin 4. Check item out for patron. 5. Check item in. => Description of notforloan status should be displayed. => Confirm notforloan status hasn't changed. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- I like this idea - but the patch doesn't currently apply. CONFLICT (content): Merge conflict in C4/Circulation.pm error: Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132554|0 |1 is obsolete| | --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 138168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138168&action=edit Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description This can be used to instruct staff how the item should handled when it's checked in. For example items notforloan status has been changed as "Invoiced item" while item has been on loan. When it's checked in staff sees that they should put item aside for further processing. To test: 1. Apply patch and update database if needed 2. Set items notforloan status as -1 (or create new one) 3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin 4. Check item out for patron. 5. Check item in. => Description of notforloan status should be displayed. => Confirm notforloan status hasn't changed. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Sally from comment #2)
I like this idea - but the patch doesn't currently apply.
CONFLICT (content): Merge conflict in C4/Circulation.pm error: Failed to merge in the changes.
Patch rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138168|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 138171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138171&action=edit Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description This can be used to instruct staff how the item should handled when it's checked in. For example items notforloan status has been changed as "Invoiced item" while item has been on loan. When it's checked in staff sees that they should put item aside for further processing. To test: 1. Apply patch and update database if needed 2. Set items notforloan status as -1 (or create new one) 3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin 4. Check item out for patron. 5. Check item in. => Description of notforloan status should be displayed. => Confirm notforloan status hasn't changed. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described, signing off. Thanks for the patch! The display of the not for loan status for the staff on check in will be particularly useful when we get a publisher recall. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25560 CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Careful Bug 25560 is also modifying this preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138171|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141211&action=edit Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description This can be used to instruct staff how the item should handled when it's checked in. For example items notforloan status has been changed as "Invoiced item" while item has been on loan. When it's checked in staff sees that they should put item aside for further processing. To test: 1. Apply patch and update database if needed 2. Set items notforloan status as -1 (or create new one) 3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin 4. Check item out for patron. 5. Check item in. => Description of notforloan status should be displayed. => Confirm notforloan status hasn't changed. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141212&action=edit Bug 30407: (QA follow-up) Fix missing TT filter Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141213&action=edit Bug 30407: (QA follow-up) Replace message with description Switches "not for loan message" to "not for loan description" to stay closer to the usual terminology for AV values also used when managing them. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *ping* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 142724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142724&action=edit Bug 30407: Fix sysprefs.sql syntax Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/669 Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35692 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35293 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org