[Bug 17395] New: exporting checkouts in CVS generates a file with wrong extension
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Bug ID: 17395 Summary: exporting checkouts in CVS generates a file with wrong extension Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In checkouts table, the is an export form (when some exports syspref are enabled). Export using a CSV profile will create a file with name koha.mrc (same as ISO2709 export). It would be better with koha.csv. Bug 14647 manages the export page, this but will only manage for export from checkouts table where file name is hard-coded. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14647 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17394 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 56019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56019&action=edit Bug 17395 - exporting checkouts in CVS generates a file with wrong extension In checkouts table, the is an export form (when some exports syspref are enabled). Export using a CSV profile will create a file with name koha.mrc (same as ISO2709 export). It would be better with koha.csv. Bug 14647 manages the export page, this but will only manage for export from checkouts table where file name is hard-coded. Test plan : - Enable checkouts exports by setting syspref ExportWithCsvProfile with a profile for record export - Go to circ page of a patron with checkouts : /cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx - Show checkouts table - Select some checkboxes in "Export" column - Select "CSV" in export format combo-box - Click on "Export" => Without patch, the generated file is koha.mrc => With patch, the generated file is koha.csv - Check ISO2709 export generates a file named koha.mrc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Would not have been better to revive the patch from bug 14647? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #2)
Would not have been better to revive the patch from bug 14647?
Bug 14647 manages exports made by a real user with the page form, it will not manage when export page is called from exporting checkouts : arg filename is not provided so it is then hardcoded. Maybe we can add an hidden input for filename but its more complicated I'd say. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Fridolin <fsomers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56019|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to sandboxes@biblibre.com from comment #4)
Patch tested with a sandbox, by Fridolin <fsomers@biblibre.com>
I'm just testing our new sandboxes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56019|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Fridolin <fsomers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56019|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56019|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to sandboxes@biblibre.com from comment #6)
Patch tested with a sandbox, by Fridolin <fsomers@biblibre.com>
Aborted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Danielle Elder <danielle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56019|0 |1 is obsolete| | --- Comment #8 from Danielle Elder <danielle@bywatersolutions.com> --- Created attachment 56200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56200&action=edit Bug 17395 - exporting checkouts in CVS generates a file with wrong extension In checkouts table, the is an export form (when some exports syspref are enabled). Export using a CSV profile will create a file with name koha.mrc (same as ISO2709 export). It would be better with koha.csv. Bug 14647 manages the export page, this but will only manage for export from checkouts table where file name is hard-coded. Test plan : - Enable checkouts exports by setting syspref ExportWithCsvProfile with a profile for record export - Go to circ page of a patron with checkouts : /cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx - Show checkouts table - Select some checkboxes in "Export" column - Select "CSV" in export format combo-box - Click on "Export" => Without patch, the generated file is koha.mrc => With patch, the generated file is koha.csv - Check ISO2709 export generates a file named koha.mrc Signed-off-by: Dani Elder <dani@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Danielle Elder <danielle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |danielle@bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not understand the test plan: the filename is automatically set to "koha.mrc". It looks like we should do this trick using some JS code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #9)
I do not understand the test plan: the filename is automatically set to "koha.mrc". It looks like we should do this trick using some JS code.
I don't see how, but this quick fix is ok no ? Some users may not be aware they must change the file extension, they open it directly from web-browser. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|exporting checkouts in CVS |exporting checkouts in CSV |generates a file with wrong |generates a file with wrong |extension |extension CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- As I said previously, this has to be done in javascript to fill the "File name" input depending on the format the user picked. Currently the behavior is: - "File name" is "koha.mrc" by default - User select csv as the format and pick a csv profile - "File name" is still "koha.mrc" - Click on export => File is named "koha.mrc" (expected) What you want (I suppose): - "File name" is "koha.mrc" by default - User select csv as the format and pick a csv profile - "File name" is changed to "koha.csv" (ideally you only change the extension) - Click on export => File is named "koha.csv" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #11)
As I said previously, this has to be done in javascript to fill the "File name" input depending on the format the user picked. Mmmm this is a point of view I think. Fixing in perl is safer in my opinion, it fixes for all calls.
to fill the "File name" input There is actually no such input, create an hidden one you mean ?
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56200|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57748&action=edit Bug 17395 - exporting checkouts in CVS generates a file with wrong extension In checkouts table, the is an export form (when some exports syspref are enabled). Export using a CSV profile will create a file with name koha.mrc (same as ISO2709 export). It would be better with koha.csv. Bug 14647 manages the export page, this but will only manage for export from checkouts table where file name is hard-coded. Test plan : - Enable checkouts exports by setting syspref ExportWithCsvProfile with a profile for record export - Go to circ page of a patron with checkouts : /cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx - Show checkouts table - Select some checkboxes in "Export" column - Select "CSV" in export format combo-box - Click on "Export" => Without patch, the generated file is koha.mrc => With patch, the generated file is koha.csv - Check ISO2709 export generates a file named koha.mrc Signed-off-by: Dani Elder <dani@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sorry Frido, I mixed it up with the export records tool. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Frido! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org