[Bug 38351] New: Improve layout of course reserve details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 Bug ID: 38351 Summary: Improve layout of course reserve details Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The course reserves detail page has a section showing details about the course. It could use some formatting improvements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173942&action=edit Bug 38351: Improve layout of course reserve details This patch makes some simple markup and CSS changes to the course details page in order to improve the layout of the section: - Add colons after labels. - Replace fieldset.rows with div.rows (there's no form). - Make list of instructors line up with other details. - Do not display fields which are empty. ALSO: Replaced the "Reserves" heading with course name, matching breadcrumbs and page title. To test, apply the patch and go to Course reserves. - If necessary, create a course. - View the details of the course. - Confirm that the list of details looks correct. - Test with all the optional fields empty: Section, term, instructor, staff note, public note. There should not be empty lines for these fields in the course details. - "Number of students" should show "0" if you left the field empty. - Add multiple instructors to confirm that they are displayed in alignment with other course details. - The page heading should match the page breadcrumb. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 176109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176109&action=edit Screenshot - Course details page(showing formatting issues) Hi Owen. This is a great improvement! However, some things I noticed: 1. There is a row border just above/through the instructors row. (See screenshot.) 2. The staff note and public note are misaligned. (See screenshot.) 3. When editing the course, the instructor search label and search box are indented/misaligned, unless that is the way it is supposed to be. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 176389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176389&action=edit Bug 38351: (follow-up) Tweaks to list and form alignment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173942|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 176394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176394&action=edit Bug 38351: Improve layout of course reserve details This patch makes some simple markup and CSS changes to the course details page in order to improve the layout of the section: - Add colons after labels. - Replace fieldset.rows with div.rows (there's no form). - Make list of instructors line up with other details. - Do not display fields which are empty. ALSO: Replaced the "Reserves" heading with course name, matching breadcrumbs and page title. To test, apply the patch and go to Course reserves. - If necessary, create a course. - View the details of the course. - Confirm that the list of details looks correct. - Test with all the optional fields empty: Section, term, instructor, staff note, public note. There should not be empty lines for these fields in the course details. - "Number of students" should show "0" if you left the field empty. - Add multiple instructors to confirm that they are displayed in alignment with other course details. - The page heading should match the page breadcrumb. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176389|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 176395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176395&action=edit Bug 38351: (follow-up) Tweaks to list and form alignment Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176109|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement to the release notes| |course reserves layout: | |- | |Replaces the "Reserves" | |heading with "Courses" for | |the list of courses. | |- | |Improves the course details | |page: | | . Replaces the | |"Reserves" heading with the | |course name, | | matching | |the breadcrumbs and page | |title. | | . Adds separator | |lines between fields. | | . | |Adds colons after labels. | | | |. Fixes some alignment | |issues. | | . Only displays | |fields with values. | | . | |"Number of students" now | |shows as "0" if no value | |added. --- Comment #6 from David Nind <david@davidnind.com> --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176395|0 |1 is obsolete| | --- Comment #7 from William Lavoie <william.lavoie@inLibro.com> --- Created attachment 176396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176396&action=edit Bug 38351: (follow-up) Tweaks to list and form alignment Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: William Lavoie <william.lavoie@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176394|0 |1 is obsolete| | Attachment #176396|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177917&action=edit Bug 38351: Improve layout of course reserve details This patch makes some simple markup and CSS changes to the course details page in order to improve the layout of the section: - Add colons after labels. - Replace fieldset.rows with div.rows (there's no form). - Make list of instructors line up with other details. - Do not display fields which are empty. ALSO: Replaced the "Reserves" heading with course name, matching breadcrumbs and page title. To test, apply the patch and go to Course reserves. - If necessary, create a course. - View the details of the course. - Confirm that the list of details looks correct. - Test with all the optional fields empty: Section, term, instructor, staff note, public note. There should not be empty lines for these fields in the course details. - "Number of students" should show "0" if you left the field empty. - Add multiple instructors to confirm that they are displayed in alignment with other course details. - The page heading should match the page breadcrumb. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177918&action=edit Bug 38351: (follow-up) Tweaks to list and form alignment Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: William Lavoie <william.lavoie@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177917|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 179053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179053&action=edit Bug 38351: Improve layout of course reserve details This patch makes some simple markup and CSS changes to the course details page in order to improve the layout of the section: - Add colons after labels. - Replace fieldset.rows with div.rows (there's no form). - Make list of instructors line up with other details. - Do not display fields which are empty. ALSO: Replaced the "Reserves" heading with course name, matching breadcrumbs and page title. To test, apply the patch and go to Course reserves. - If necessary, create a course. - View the details of the course. - Confirm that the list of details looks correct. - Test with all the optional fields empty: Section, term, instructor, staff note, public note. There should not be empty lines for these fields in the course details. - "Number of students" should show "0" if you left the field empty. - Add multiple instructors to confirm that they are displayed in alignment with other course details. - The page heading should match the page breadcrumb. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177918|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 179054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179054&action=edit Bug 38351: (follow-up) Tweaks to list and form alignment Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: William Lavoie <william.lavoie@inLibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy |additional_work_needed --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The release notes seem to have some non-mark-down mark-up, can you please check and revise? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement to the |This enhancement improves release notes|course reserves layout: |the layout of course |- |reserves pages. |Replaces the "Reserves" | |heading with "Courses" for |For the |the list of courses. |list of courses, it changes |- |the "Reserves" heading to |Improves the course details |"Courses". |page: | | . Replaces the |For the course |"Reserves" heading with the |details page it: |course name, |- Replaces | matching |the "Reserves" heading with |the breadcrumbs and page |the course name, |title. | | . Adds separator |matching the breadcrumbs |lines between fields. |and page title. | . |- Adds |Adds colons after labels. |separator lines between | |fields. |. Fixes some alignment |- Adds colons after |issues. |labels. | . Only displays |- Fixes some |fields with values. |alignment issues. | . |- Only |"Number of students" now |displays fields with |shows as "0" if no value |values. |added. |- Now shows "0" for | |the "Number of students" if | |no value is added. --- Comment #14 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #12)
The release notes seem to have some non-mark-down mark-up, can you please check and revise?
I didn't release we could use markdown "markup". Is there any specific guidance about this (markdown flavour, what works and what doesn't)? I've simplified the list of improvements a bit, if this helps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38351 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org