https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 61938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61938&action=edit Bug 18394: Add an option to item search to export a barcodes file Test plan: 1. Go to item search (/cgi-bin/koha/catalogue/itemsearch.pl) 2. Fill the form with whatever you want 3. Leave the 'Output' option to 'Screen' and click 'Search' 4. Verify that the search still works 5. Click on 'Edit search' and set 'Output' to 'Barcodes file', click 'Search' 6. You should be able to download a 'barcodes.txt' file, open it and compare it to the previous search results 7. Now click on the 'Export results to barcodes file' button above the results, you should have the same result as in step 5 8. Verify that the CSV export still works -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Step 5 and Step 7 don't work for me. I expect the browser to start the download of a text file, but the page reloads without any prompt. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Sorry, it must have been a problem with my setup. It looks like it's working now. I'll continue testing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 62007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62007&action=edit [SIGNED-OFF] Bug 18394: Add an option to item search to export a barcodes file Test plan: 1. Go to item search (/cgi-bin/koha/catalogue/itemsearch.pl) 2. Fill the form with whatever you want 3. Leave the 'Output' option to 'Screen' and click 'Search' 4. Verify that the search still works 5. Click on 'Edit search' and set 'Output' to 'Barcodes file', click 'Search' 6. You should be able to download a 'barcodes.txt' file, open it and compare it to the previous search results 7. Now click on the 'Export results to barcodes file' button above the results, you should have the same result as in step 5 8. Verify that the CSV export still works Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to delaye from comment #8)

The number of exported barcodes remains unchanged despite the use of filters in the result table

Yes right, but this behavior already existed when exporting as CSV. Julian, any chances to see you fix that on another bug report? :) Passing QA this one. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62006|0 |1 is obsolete| | Attachment #62007|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62068&action=edit Bug 18394: Remove useless code from item search The item search was originally designed to work even with JS disabled. Since bug 15111, the staff interface does not work at all without JS, so some parts of this code are useless and should be removed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #9)

(In reply to delaye from comment #8)

...

The number of exported barcodes remains unchanged despite the use of filters in the result table

Yes right, but this behavior already existed when exporting as CSV.

Julian, any chances to see you fix that on another bug report? :)

Passing QA this one.

Thanks. That's probably what I'll do -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18433 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 [Bug 18433] Allow to select results to export in item search -- You are receiving this mail because: You are watching all bug changes.