[Bug 28154] New: Translate script faces encoding issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 Bug ID: 28154 Summary: Translate script faces encoding issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: I18N/L10N Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr % gulp po:update --lang pl-PL misc/translator/Koha-pref.pot:5085:37: invalid multibyte sequence misc/translator/Koha-pref.pot:5245:107: invalid multibyte sequence misc/translator/Koha-pref.pot:5253:78: invalid multibyte sequence misc/translator/Koha-pref.pot:5261:82: invalid multibyte sequence msgmerge: found 4 fatal errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27623 Depends on| |22824 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Git bisect blames commit d6d01169509999e22fbf33d839a41e402cb93a38 Bug 22824: Replace YAML::Syck with YAML::XS Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 [Bug 22824] Replace YAML::Syck with YAML::XS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 [Bug 27623] Remove pl-PL installer data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- % file misc/translator/Koha-pref.pot misc/translator/Koha-pref.pot: GNU gettext message catalogue, Non-ISO extended-ASCII text, with very long lines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25067 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067 [Bug 25067] Move PO file manipulation code into gulp tasks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119636&action=edit Bug 28154: Fix encoding issues on Koha-pref.pot -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Maybe this occurrence needs to be fixed as well: misc/translator/xgettext-installer:Locale::PO->save_file_fromhash($output, $pot); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi, | |julian.maurice@biblibre.com --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Cannot focus more on this one for today. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119636|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 119695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119695&action=edit Bug 28154: Fix encoding issues on Koha-pref.pot Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 119696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119696&action=edit Bug 28154: Fix encoding issues on Koha-installer.pot Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #4)
Maybe this occurrence needs to be fixed as well: misc/translator/xgettext-installer:Locale::PO->save_file_fromhash($output, $pot);
Yep, you were right. Fixed in the 2nd patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119695|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119709&action=edit Bug 28154: Fix encoding issues on Koha-pref.pot Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119696|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119710&action=edit Bug 28154: Fix encoding issues on Koha-installer.pot Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Julian Maurice from comment #8)
(In reply to Jonathan Druart from comment #4)
Maybe this occurrence needs to be fixed as well: misc/translator/xgettext-installer:Locale::PO->save_file_fromhash($output, $pot);
Yep, you were right. Fixed in the 2nd patch
Can you detail what it fixes? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #12)
Can you detail what it fixes?
There is no real problem right now as there is no non-ASCII character in installer files, but if you add one you will see encoding issues. For instance, add a 'é' to installer/data/mysql/en/mandatory/auth_values.yml - "Default Koha system authorised values é" and run `gulp po:update --lang pl-PL You should see misc/translator/Koha-installer.pot:972:46: Séquence d'octets multiples invalide msgmerge: 1 erreur fatale trouvée [14:55:39] Finished 'po_update_installer' after 152 ms After the patch, there should be no errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Right, thanks! I've tried yesterday with an other file and not in the description. Now I recreate it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Can this be pushed to 20.11.x even it does not contain Bug 22824 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28281 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org