[Bug 30545] New: Replace the use of jQueryUI Accordion on the notices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Bug ID: 30545 Summary: Replace the use of jQueryUI Accordion on the notices page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 30494 Blocks: 29224 As part of Bug 29224, "OMNIBUS: Replace the use of jQueryUI Accordion" we should replace the use of the jQueryUI accordion component on the notices page with Bootstrap's Collapse component. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29224 [Bug 29224] OMNIBUS: Replace the use of jQueryUI Accordion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494 [Bug 30494] Replace the use of jQueryUI Accordion on the table settings page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133331&action=edit Bug 30545: Replace the use of jQueryUI Accordion on the notices page This patch updates the notices edit interface in order to replace jQueryUI accordion and tabs widgets with Bootstrap collapse and tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Set the TranslateNotices system preference to "Don't allow." - Go to Tools -> Notices and edit any notice. - On the "Modify notice" page you should see three collapsed sections: Email, Print, and SMS. - Clicking the section headings should expand and collapse the panels. - With one of the panels open, click Save -> Save and continue editing. - When the page reloads the same panel should be expanded. - Enable the TranslateNotices system preference. - Return to the edit interface for one of your notices. - You should now see at least two tabs: Default and English. - The sections under each tab should continue to work correctly. - Test the "Save and continue" functionality again. When redirected you should return to both the correct tab and the correct panel, e.g. the "Print" section under the "English (en)" tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133331|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 133408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133408&action=edit Bug 30545: Replace the use of jQueryUI Accordion on the notices page This patch updates the notices edit interface in order to replace jQueryUI accordion and tabs widgets with Bootstrap collapse and tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Set the TranslateNotices system preference to "Don't allow." - Go to Tools -> Notices and edit any notice. - On the "Modify notice" page you should see three collapsed sections: Email, Print, and SMS. - Clicking the section headings should expand and collapse the panels. - With one of the panels open, click Save -> Save and continue editing. - When the page reloads the same panel should be expanded. - Enable the TranslateNotices system preference. - Return to the edit interface for one of your notices. - You should now see at least two tabs: Default and English. - The sections under each tab should continue to work correctly. - Test the "Save and continue" functionality again. When redirected you should return to both the correct tab and the correct panel, e.g. the "Print" section under the "English (en)" tab. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Really nice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133408|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133408|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I mistakenly marked this as PQA. It doesn't apply anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133408|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133473&action=edit Bug 30545: Replace the use of jQueryUI Accordion on the notices page This patch updates the notices edit interface in order to replace jQueryUI accordion and tabs widgets with Bootstrap collapse and tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Set the TranslateNotices system preference to "Don't allow." - Go to Tools -> Notices and edit any notice. - On the "Modify notice" page you should see three collapsed sections: Email, Print, and SMS. - Clicking the section headings should expand and collapse the panels. - With one of the panels open, click Save -> Save and continue editing. - When the page reloads the same panel should be expanded. - Enable the TranslateNotices system preference. - Return to the edit interface for one of your notices. - You should now see at least two tabs: Default and English. - The sections under each tab should continue to work correctly. - Test the "Save and continue" functionality again. When redirected you should return to both the correct tab and the correct panel, e.g. the "Print" section under the "English (en)" tab. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133473|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133487&action=edit Bug 30545: Replace the use of jQueryUI Accordion on the notices page This patch updates the notices edit interface in order to replace jQueryUI accordion and tabs widgets with Bootstrap collapse and tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Set the TranslateNotices system preference to "Don't allow." - Go to Tools -> Notices and edit any notice. - On the "Modify notice" page you should see three collapsed sections: Email, Print, and SMS. - Clicking the section headings should expand and collapse the panels. - With one of the panels open, click Save -> Save and continue editing. - When the page reloads the same panel should be expanded. - Enable the TranslateNotices system preference. - Return to the edit interface for one of your notices. - You should now see at least two tabs: Default and English. - The sections under each tab should continue to work correctly. - Test the "Save and continue" functionality again. When redirected you should return to both the correct tab and the correct panel, e.g. the "Print" section under the "English (en)" tab. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is great.. Passing QA Minor annoyance that predates this though.. when you switch the language tab, we don't keep the context of the open accordion.. would be great if we could.. but that can wait on another bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Bug 30545 depends on bug 30494, which changed state. Bug 30494 Summary: Replace the use of jQueryUI Accordion on the table settings page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org