[Bug 26962] New: Koha notice/slips/receipts should print in pure black
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Bug ID: 26962 Summary: Koha notice/slips/receipts should print in pure black Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Many people have been complaining about poor print quality in Koha. A solution that I have found to work is changing the shade of black from either #333333 or #000066 to #000000 (pure black). We can do this for just print by updating /koha-tmpl/intranet-tmpl/prog/css/print.css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Alex C <alexanderchen530@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexanderchen530@gmail.com --- Comment #1 from Alex C <alexanderchen530@gmail.com> --- Just to add some info here for reference. The issue doesn't affect normal printing on letter sized paper on regular laser/ink printers, but on thermal POS printers it becomes like a fuzzy dotted print. Our printers are Star TSP100 series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 113281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113281&action=edit Bug 26962: Make print.css pure black Test plan: 1. Generate some different notice/slips like ISSUESLIP, HOLD_SLIP, any slip you like 2. Inspect and see that body, p tags and see that the computed color is #333333 or #000066. 3. Apply patch 4. The computed style for color should not be #00000 5. This prints much better, especially on thermal/receipt printers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |lucas@bywatersolutions.com |u | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha notice/slips/receipts |Koha notice/slips/receipts |should print in pure black |should print in true black | |(#000000) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113281|0 |1 is obsolete| | --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 113336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113336&action=edit Bug 26962: Make print.css pure black Test plan: 1. Generate some different notice/slips like ISSUESLIP, HOLD_SLIP, any slip you like 2. Inspect and see that body, p tags and see that the computed color is #333333 or #000066. 3. Apply patch 4. The computed style for color should not be #00000 5. This prints much better, especially on thermal/receipt printers Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- I could not find a way to follow the test plan in Chrome due to the Chrome print pop-up, but visually it looked good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 --- Comment #5 from Alex C <alexanderchen530@gmail.com> --- Just for documentation purposes I'm posting the original solution I found on StackOverflow and sent a ticket to ByWater: https://stackoverflow.com/questions/27203571/receipt-printing-in-chrome-bad-... The original StackOverflow thread was in a different environment but he is using the same printer and the same receipt paper we have. Thanks Lucas for making the solution work in Koha~ :) Lucas/David - after this is all finished in Koha proper instead of using "@media print", I can test it on real receipt printers for you guys (actually I already tested while Lucas and I were playing around with it, it looks good with #000000). Also a small thing that David's mentioning of Chrome pop-up reminded me to write this down too: we use Chrome's --kioskprinting" switch to bypass the "select a printer" pop-up and shoot out the receipts directly. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Great additional context, Alex! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113336|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 114996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114996&action=edit Bug 26962: Make print.css pure black Test plan: 1. Generate some different notice/slips like ISSUESLIP, HOLD_SLIP, any slip you like 2. Inspect and see that body, p tags and see that the computed color is #333333 or #000066. 3. Apply patch 4. The computed style for color should not be #00000 5. This prints much better, especially on thermal/receipt printers Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27407 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27407 [Bug 27407] Update intranet-tmpl/prog/en/modules/reserve/request.tt for ACC2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 [Bug 27408] Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27409 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27409 [Bug 27409] Update intranet-tmpl/prog/en/modules/members/boraccount.tt for ACC2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27410 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 [Bug 27410] Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to reflect ACC2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27411 [Bug 27411] Update intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt to reflect ACC2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27412 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 [Bug 27412] Update intranet-tmpl/prog/en/modules/tools/overduerules.tt to adhere to ACC2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27407 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27407 [Bug 27407] Update intranet-tmpl/prog/en/modules/reserve/request.tt for ACC2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27408 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 [Bug 27408] Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27409 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27409 [Bug 27409] Update intranet-tmpl/prog/en/modules/members/boraccount.tt for ACC2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27410 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 [Bug 27410] Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to reflect ACC2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27411 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27411 [Bug 27411] Update intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt to reflect ACC2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27412 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 [Bug 27412] Update intranet-tmpl/prog/en/modules/tools/overduerules.tt to adhere to ACC2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why not the other occurrences? % git grep -l -c 000066 At least those 3 seem relevant: koha-tmpl/intranet-tmpl/prog/css/print.css koha-tmpl/intranet-tmpl/prog/css/printreceiptinvoice.css koha-tmpl/opac-tmpl/bootstrap/css/src/print.scss No idea about: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #8)
Why not the other occurrences?
% git grep -l -c 000066
At least those 3 seem relevant: koha-tmpl/intranet-tmpl/prog/css/print.css koha-tmpl/intranet-tmpl/prog/css/printreceiptinvoice.css koha-tmpl/opac-tmpl/bootstrap/css/src/print.scss
No idea about: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt
Good point, I will submit a follow up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 115104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115104&action=edit Bug 26962: (follow-up) Catch other #000066 occurrences Addtional test steps: -Check printing an invoice, inscept the page and make sure none of the colors are set to #000066 -For the OPAC you must rebuild the CSS ((https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) -Look at some areas where you might print in the OPAC (try a list), inscept the page and make sure there is no colors set to #000066 -You can also use Jonathan's method of 'git grep -l -c 000066' to make sure no occurrences are left. -I left macles.tt as is because I am not sure about that template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small enhancement applies on 20.11, I choose to backport. Pushed to 20.11.x for 20.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Almost black color in CSS release notes| |rules (like #000066) are | |now replaced by true black | |color #000000 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Enhancement, not backporting to 20.05. Please ask if needed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org