[Bug 30265] New: Hide 'Log into your account' in OPAC authentication page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 Bug ID: 30265 Summary: Hide 'Log into your account' in OPAC authentication page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Created attachment 131536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131536&action=edit Screenshot showing double auth form If not logged in, in OPAC header there is link 'Log into your account'. Using it shows a popup with authentication form. In authentication page /cgi-bin/koha/opac-user.pl this double authentication form feels not ergonomic. It may lead to misunderstanding. We can simply hide this link in this special page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 131537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131537&action=edit Bug 30265 - Hide 'Log into your account' in OPAC authentication page If not logged in, in OPAC header there is link 'Log into your account'. Using it shows a popup with authentication form. In authentication page /cgi-bin/koha/opac-user.pl this double authentication form feels not ergonomic. It may lead to misunderstanding. We can simply hide this link in this special page. Test plan : 1) Go to OPAC not logged in 2) Go to main page => You see link 'Log into your account' 3) Go to /cgi-bin/koha/opac-user.pl => You don't see 'Log into your account' 4) Authenticate 5) You are still in /cgi-bin/koha/opac-user.pl => You see link 'Welcome, XXX' 6) Go to main page => You see link 'Welcome, XXX' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 131545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131545&action=edit Bug 30077: Add system preference IntranetAddMastheadLibraryPulldown To test: 1. Apply patch, updatedatabase, restart_all 2. Search for the system pref 'IntranetAddMastheadLibraryPulldown' 3. Set it to 'Show'. 4. Go to any page that contains header search box and click on 'Search the catalog'. 5. To the left of the search bar you should see a dropdown for branches. 6. This should be defaulted to 'All libraries'. 7. In the dropdown choose any branch and do a search and make sure it is correctly limiting to that branch. 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch BUT it should also default back to 'All libraries' for the next search. 9. Try selecting 'All libraries' from the top of the dropdown and make sure it is correctly searching all branches. 10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it looks nice with both of those dropdowns and functions when you use limiters from both dropdowns. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131537|0 |1 is obsolete| | --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 131546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131546&action=edit Bug 30265 - Hide 'Log into your account' in OPAC authentication page If not logged in, in OPAC header there is link 'Log into your account'. Using it shows a popup with authentication form. In authentication page /cgi-bin/koha/opac-user.pl this double authentication form feels not ergonomic. It may lead to misunderstanding. We can simply hide this link in this special page. Test plan : 1) Go to OPAC not logged in 2) Go to main page => You see link 'Log into your account' 3) Go to /cgi-bin/koha/opac-user.pl => You don't see 'Log into your account' 4) Authenticate 5) You are still in /cgi-bin/koha/opac-user.pl => You see link 'Welcome, XXX' 6) Go to main page => You see link 'Welcome, XXX' Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #4 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works great, so signed off - thanks Fridolin. Apologies for the extra patch; I was signing off multiple bugs on a sandbox. Should've reloaded :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131545|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Thanks a lot for testing Sally ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am not sure about this change. We are introducing an inconsistency IMO. If you are used to click on the login button on the header, you will simply click it, no matter on which page you are. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Joubu> oleonard What's your opinion on bug 30265? oleonard> Joubu I don't think it's that confusing, but I don't object to the patch. Better safe than confusing. Joubu> To me it's confusing with the patch :) oleonard> Because you think folks will look for the link in the header and not find it? Joubu> yes oleonard> I think we'd have to do actual user testing to be sure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- An example of this behavior : We don't show catalog search form in advanced search. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |In Discussion --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- I see the two forms as a feature, not a bug We have users that customise the two forms and use them differently, or have JS to make the header link a direct link to SSO, and use the form for local only users - removing this is going to cause confusion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens from comment #9)
I see the two forms as a feature, not a bug
We have users that customise the two forms and use them differently, or have JS to make the header link a direct link to SSO, and use the form for local only users - removing this is going to cause confusion
Reading that... we do somethig similar and I think I'd also like to keep the link on top. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- OK lets keep it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|CLOSED |REOPENED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Hi, I reopen because I found a JS in actual code : In opac-auth.tt <script> // Hide circular 'Log in to Your Account' link in opac-auth.pl $(document).ready(function() { if ( $("#auth" ) ) { $("#members ul li a").hide(); } }); </script> https://git.koha-community.org/Koha-community/Koha/src/commit/3dcdd6db788b2c... It does actually not work because the id="members" is now on ul itself. If we decide to keep the actual behavior we should remove this JS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Owen, what's your opinion on this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #11)
OK lets keep it.
+1 Should we remove the non-functional JS then? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org