https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #372 from David Gustafsson <glasklas@gmail.com> --- (In reply to Jonathan Druart from comment #369)

I've spent a lost of time on this patch set to make it part of 21.05. Added follow-ups and written test.

Then I had some questions, and didn't get the answers I needed to write the missing bit. I was not asking anybody else to write anything.

I wish I had people asking me to write follow-up for my patches..

Sorry I missed some of those questions (i for some reason read comment 221-333 so I was not referring to you regarding requesting new features). Regarding the question in comment 324:

4. We need a wiki page, or at least more info/examples for the release notes. There is only 2 very succinct example in the test plan but the feature allows much more.

I have written a manual entry, it might now be partly out dated since it was 2 years ago, there are some links to it further up in the thread: https://gitlab.com/gnucifer/koha-manual/-/commit/eb07dd1abcb357de27d294cee49... The reason I pointed out that we have been running this in production for a long time is that there appears to be great hesitancy in merging this which is understandable due to the large surface area of changes and and relative high complexity. That serious bugs could lurk is not impossible, but is highly unlikely as we would probably have encountered them by now. There are for example certain contexts that we do not use, like batchmod, z3950 and import_lexile, but it can be good to know that the core functionality appears to be pretty solid. The scariest part of this by far is the potential for unexpected data loss or corruption when records are taken apart and put back together again, and that part appears to be solid. As a side note I don't really get why MergeRules were renamed to OverlayRules, it's not that much worse than merge, but is it really better? To me merge is more intuitive as we basically have to revisions of a record and use certain rules to resolve the diff, merging the two. -- You are receiving this mail because: You are watching all bug changes.