[Bug 26507] New: New items not indexed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Bug ID: 26507 Summary: New items not indexed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com When adding a new item under ES, that item is not automatically indexed. It is indexed if subsequently edited and saved. To recreate: - find/create a bib with no items - add an item with barcode "abc123" - do a general keyword search for "abc123," see your bib is not in the results - perform a search that includes your bib in the results, confirm it shows as having no items - click through to bib details, confirm it shows your item here - edit and save your item - confirm barcode is now searchable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25265 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 110558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110558&action=edit Bug 26507: Index records after storing new item Currently Item->store indexes the record before the DB update - that is wrong To test: 1 - Find/create a bib with no items 2 - add an item with barcode "abc123" 3 - do a general keyword search for "abc123," see your bib is not in the results 4 - perform a search that includes your bib in the results, confirm it shows as having no items 5 - click through to bib details, confirm it shows your item here 6 - edit and save your item 7 - confirm barcode is now searchable 8 - apply patches 9 - Add a new item "cde456" 10 - Confirm it returns in searches 11 - Edit 'cde456' and change barcode to 'fgh789' 12 - Confirm the new abrcode is searchable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110558|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 110567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110567&action=edit Bug 26507: Index records after storing new item Currently Item->store indexes the record before the DB update - that is wrong To test: 1 - Find/create a bib with no items 2 - add an item with barcode "abc123" 3 - do a general keyword search for "abc123," see your bib is not in the results 4 - perform a search that includes your bib in the results, confirm it shows as having no items 5 - click through to bib details, confirm it shows your item here 6 - edit and save your item 7 - confirm barcode is now searchable 8 - apply patches 9 - Add a new item "cde456" 10 - Confirm it returns in searches 11 - Edit 'cde456' and change barcode to 'fgh789' 12 - Confirm the new abrcode is searchable Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110620&action=edit Bug 26507: Elasticsearch - Index records after storing new item Currently Item->store indexes the record before the DB update - that is wrong To test: 1 - Find/create a bib with no items 2 - add an item with barcode "abc123" 3 - do a general keyword search for "abc123," see your bib is not in the results 4 - perform a search that includes your bib in the results, confirm it shows as having no items 5 - click through to bib details, confirm it shows your item here 6 - edit and save your item 7 - confirm barcode is now searchable 8 - apply patches 9 - Add a new item "cde456" 10 - Confirm it returns in searches 11 - Edit 'cde456' and change barcode to 'fgh789' 12 - Confirm the new abrcode is searchable Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110567|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23463 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 chad@pennmanor.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chad@pennmanor.net --- Comment #5 from chad@pennmanor.net --- Any chance this will be backported to 20.05.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to chad from comment #5)
Any chance this will be backported to 20.05.x?
It' always up to the RMaints, but the usual rule of thumb is that bug fixes will be backported if the bug exists in the earlier version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- does not apply cleanly to 20.05.x, if needed please rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 110879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110879&action=edit Bug 26507: [20.05.x] Elasticsearch - Index records after storing new item Currently Item->store indexes the record before the DB update - that is wrong To test: 1 - Find/create a bib with no items 2 - add an item with barcode "abc123" 3 - do a general keyword search for "abc123," see your bib is not in the results 4 - perform a search that includes your bib in the results, confirm it shows as having no items 5 - click through to bib details, confirm it shows your item here 6 - edit and save your item 7 - confirm barcode is now searchable 8 - apply patches 9 - Add a new item "cde456" 10 - Confirm it returns in searches 11 - Edit 'cde456' and change barcode to 'fgh789' 12 - Confirm the new abrcode is searchable Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.05 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This caused bug 26972. Nick, can you have a look please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26972 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26972 [Bug 26972] Test suite does not pass with Elasticsearch for Item.t test -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org