[Bug 35610] New: Missing FK on old_reserves.branchcode?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Bug ID: 35610 Summary: Missing FK on old_reserves.branchcode? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 5334 Why don't we have a foreign key on this column? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl, | |nick@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe we don't have strict FK on the statistic tables like statistics and action_logs and as old_reserves is also used mainly for statistics, it makes kind of sense. If we decide to merge reserve and old_reserves into a holds table, that will probably have to change. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160097&action=edit Bug 35610: Add FK on old_reserves.branchcode -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160097|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160098&action=edit Bug 35610: Add FK on old_reserves.branchcode -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35560 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 [Bug 35560] Use the REST API for holds history -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #1)
I believe we don't have strict FK on the statistic tables like statistics and action_logs and as old_reserves is also used mainly for statistics, it makes kind of sense.
FK can be NULL. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Do you mean we want to keep the branchcode values for deleted libraries? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #5)
Do you mean we want to keep the branchcode values for deleted libraries?
It might be something people query, but I am not sure how often branches are closed etc. I was thinking maybe a better moment to fix might be when merging, because we could advertise that change a bit more. But if there is a need now, maybe it's ok. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Teertha Chatterjee <teerthacha1993@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |teerthacha1993@gmail.com --- Comment #7 from Teertha Chatterjee <teerthacha1993@gmail.com> --- For academic libraries in India we have seen several instances of library branch re-organisation due to accreditation compliance purpose. In such cases, we are often faced with a the need for a mechanism to track such changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Teertha Chatterjee from comment #7)
For academic libraries in India we have seen several instances of library branch re-organisation due to accreditation compliance purpose. In such cases, we are often faced with a the need for a mechanism to track such changes.
Action logs and statistics exist for that very reason. All other tables need to have proper FK constraints. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160098|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 161540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161540&action=edit Bug 35610: Add FK on old_reserves.branchcode Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |victor@tuxayo.net --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- As expected, doing an upgrade when there is 1. a hold on a library with no data linked (for easy deletion) in sample data: Liberty 2. cancel the hold 3. delete the library 4. apply the patch 5. run updatedatabase fails with: DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35610.pl [01:44:28]: Bug 35610 - Add FK on old_reserves.branchcode ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`#sql-alter-1-2f`, CONSTRAINT `old_reserves_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) at /kohadevbox/koha/C4/Installer.pm line 741 That's a rough to have such an upgrade requiring manual DB fixes. And it's not a weird workflow that can be considered messing with the DB. There doesn't seem to be a mention about how to handle that in bug 25260. How about before adding the FK having an UPDATE that NULLs the old_reserves.branchcode that don't match an existing branch? Or another approach? --- (In reply to Katrin Fischer from comment #6)
I was thinking maybe a better moment to fix might be when merging, because we could advertise that change a bit more.
What would be needed to advertise in advance? Like if they are using old_reserves for stats they should stop, use action logs/statistics and backup old_reserve before the future upgrade for past data? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163827&action=edit Bug 35610: Set branchcode to NULL before adding the FK -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #10)
As expected, doing an upgrade when there is 1. a hold on a library with no data linked (for easy deletion) in sample data: Liberty 2. cancel the hold 3. delete the library 4. apply the patch 5. run updatedatabase
fails with:
DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35610.pl [01:44:28]: Bug 35610 - Add FK on old_reserves.branchcode ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`#sql-alter-1-2f`, CONSTRAINT `old_reserves_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) at /kohadevbox/koha/C4/Installer.pm line 741
Fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35353 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35353 [Bug 35353] Add API endpoint to fetch patron's previous holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35560 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 [Bug 35560] Use the REST API for holds history -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161540|0 |1 is obsolete| | --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 163966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163966&action=edit Bug 35610: Add FK on old_reserves.branchcode Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163827|0 |1 is obsolete| | --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 163967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163967&action=edit Bug 35610: Set branchcode to NULL before adding the FK Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 163968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163968&action=edit Bug 35610: (QA follow-up): tidy up code -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) Test with comment 10 and checked that before the patch, orphan branchcodes where left and that after the patch, existing ones where handled and it was not possible to create new ones. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Missing FK on |Missing FK on |old_reserves.branchcode? |old_reserves.branchcode -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree with this change, but please add a note/warning in the release notes so people are aware on update that this might "lose" them data by setting the deleted branchcodes to NULL. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Keywords| |additional_work_needed Version|unspecified |master --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sadly, this broke several tests... prove t/db_dependent/Koha/Old/Hold.t prove t/db_dependent/Koha/Old/Hold.t t/db_dependent/Koha/Old/Hold.t .. # Looks like you planned 8 tests but ran 1. t/db_dependent/Koha/Old/Hold.t .. 1/2 # Failed test 'anonymize() tests' # at t/db_dependent/Koha/Old/Hold.t line 82. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`old_reserves`, CONSTRAINT `old_reserves_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) at /kohadevbox/koha/t/lib/TestBuilder.pm line 384 # Looks like your test exited with 255 just after 1. t/db_dependent/Koha/Old/Hold.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- prove t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patrons.t .. 30/43 # Looks like you planned 113 tests but ran 69. t/db_dependent/Koha/Patrons.t .. 31/43 # Failed test 'Test Koha::Patrons::merge' # at t/db_dependent/Koha/Patrons.t line 1844. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`old_reserves`, CONSTRAINT `old_reserves_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) at /kohadevbox/koha/t/lib/TestBuilder.pm line 384 # Looks like your test exited with 11 just after 31. t/db_dependent/Koha/Patrons.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 13/43 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 2816 Tests: 31 Failed: 1) Failed test: 31 Non-zero exit status: 11 Parse errors: Bad plan. You planned 43 tests but ran 31. Files=1, Tests=31, 12 wallclock secs ( 0.04 usr 0.01 sys + 8.47 cusr 1.94 csys = 10.46 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- prove t/db_dependent/UsageStats.t t/db_dependent/UsageStats.t .. 1/4 # No tests run! # Failed test 'No tests run for subtest "BuildReport() tests"' # at t/db_dependent/UsageStats.t line 138. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`old_reserves`, CONSTRAINT `old_reserves_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) at /kohadevbox/koha/t/lib/TestBuilder.pm line 384 # Looks like your test exited with 255 just after 4. t/db_dependent/UsageStats.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/4 subtests Test Summary Report ------------------- t/db_dependent/UsageStats.t (Wstat: 65280 Tests: 4 Failed: 1) Failed test: 4 Non-zero exit status: 255 Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.87 cusr 0.11 csys = 1.00 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- prove t/db_dependent/Koha/Old/Holds.t t/db_dependent/Koha/Old/Holds.t .. # Looks like you planned 10 tests but ran 4. t/db_dependent/Koha/Old/Holds.t .. 1/2 # Failed test 'anonymize() tests' # at t/db_dependent/Koha/Old/Holds.t line 114. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`old_reserves`, CONSTRAINT `old_reserves_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) at /kohadevbox/koha/t/lib/TestBuilder.pm line 384 # Looks like your test exited with 255 just after 1. t/db_dependent/Koha/Old/Holds.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests Test Summary Report ------------------- t/db_dependent/Koha/Old/Holds.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Parse errors: Bad plan. You planned 2 tests but ran 1. Files=1, Tests=1, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.83 cusr 0.08 csys = 0.92 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- HELP... prove t/db_dependent/TestBuilder.t t/db_dependent/TestBuilder.t .. 1/16 # Failed test 'TestBuilder should be able to create an object for every source' # at t/db_dependent/TestBuilder.t line 85. # got: '1' # expected: '0' # The following sources have not been generated correctly: OldReserve # Looks like you failed 1 test of 1. t/db_dependent/TestBuilder.t .. 3/16 # Failed test 'Build all sources' # at t/db_dependent/TestBuilder.t line 93. t/db_dependent/TestBuilder.t .. 7/16 # Looks like you planned 5 tests but ran 4. t/db_dependent/TestBuilder.t .. 12/16 # Failed test 'build_object() tests' # at t/db_dependent/TestBuilder.t line 473. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`old_reserves`, CONSTRAINT `old_reserves_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) at /kohadevbox/koha/t/lib/TestBuilder.pm line 384 # Looks like your test exited with 11 just after 12. t/db_dependent/TestBuilder.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 6/16 subtests Test Summary Report ------------------- t/db_dependent/TestBuilder.t (Wstat: 2816 Tests: 12 Failed: 2) Failed tests: 3, 12 Non-zero exit status: 11 Parse errors: Bad plan. You planned 16 tests but ran 12. Files=1, Tests=12, 16 wallclock secs ( 0.01 usr 0.01 sys + 11.46 cusr 3.43 csys = 14.91 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- You forget the DBIC changes. It fixed all the failures. I pushed it to master. "Bug 35610: DBIC schema changes" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #24)
You forget the DBIC changes. It fixed all the failures. I pushed it to master.
"Bug 35610: DBIC schema changes"
I like easy fixes, thanks for the help :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Add a foreign key on the release notes| |old_reserves.branchcode | |database column. This link | |was missing and the column | |may contain incorrect | |data/branchcode. | |Note that | |the values will now be set | |to NULL when the branchcode | |is incorrect. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #26 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #27 from Lucas Gass <lucas@bywatersolutions.com> --- This 23.05.x dependencies, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org