[Bug 16144] New: Patron search fails when using some languages (eg: korean)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 Bug ID: 16144 Summary: Patron search fails when using some languages (eg: korean) Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com I bumped into a rather strange and obscure bug when using the 'Korean' language in staff Here are the steps to replicate... 1/ set you lang to 'en' 2/ do a member search on any string (that returns multiple results) observe that results are displayed OK (see pic 1) 3/ set your language to Korean 4/ repeat step 2, and observe the following datatables error, (see pic2) "DataTables warning: table id=memberresultst - Requested unknown parameter 'dt_cardnumber' for row 0. For more information about this error, please see http://datatables.net/tn/4" I noticed that the error does not occur using the 'french' language (see pic 3) Bug discovered in 3.20.6 - i've not confirmed in master (yet) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 49506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49506&action=edit pic 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 --- Comment #2 from Mason James <mtj@kohaaloha.com> --- Created attachment 49507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49507&action=edit pic 2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 49508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49508&action=edit pic 3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #0)
I bumped into a rather strange and obscure bug when using the 'Korean' language in staff
Here are the steps to replicate... 1/ set you lang to 'en'
2/ do a member search on any string (that returns multiple results) observe that results are displayed OK (see pic 1)
3/ set your language to Korean
4/ repeat step 2, and observe the following datatables error, (see pic2)
"DataTables warning: table id=memberresultst - Requested unknown parameter 'dt_cardnumber' for row 0. For more information about this error, please see http://datatables.net/tn/4"
I imagine there may be other similar datatable errors, using other languages in Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's a translation issue: 130 #. %1$s: END. 131 #. %2$s: data.cardnumber | html. 132 #: intranet-tmpl/prog/en/modules/members/tables/members_results.tt:12 133 #, c-format 134 msgid "\", %s \"dt_cardnumber\": \"%s\", \"dt_name\": \"" 135 msgstr "\", %s \"dt_카드숫자\": \"%s\", \"dt_이름\": \"" dt_cardnumber and dt_name should not have been translated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #5)
It's a translation issue:
130 #. %1$s: END. 131 #. %2$s: data.cardnumber | html. 132 #: intranet-tmpl/prog/en/modules/members/tables/members_results.tt:12 133 #, c-format 134 msgid "\", %s \"dt_cardnumber\": \"%s\", \"dt_name\": \"" 135 msgstr "\", %s \"dt_카드숫자\": \"%s\", \"dt_이름\": \""
dt_cardnumber and dt_name should not have been translated.
aah yes, of course! folks, what's the best way for me to correct this typo? i can't seem to correct this typo via 'pootle', is it possible? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron search fails when |Patron search fails when |using some languages (eg: |using Korean |korean) |(pootle/translate error) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As the error is in the po file, it can be corrected via Pootle - but you might not be able to submit your change directly, depending on permissions. Maybe bring it to the koha-translate mailing list? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |translate.koha-community.or | |g Version|3.20 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 49868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49868&action=edit Bug 16144: Remove 'dt_*' from translation strings when possible This patch removes strings form translation files that have 'dt_*' variables besides puntuation, html constructs, etc. To test: 1) Update strings for any language 2) Check for strings with 'dt_*', eg. for es-ES msgcat --no-wrap po/es-ES-staff-prog.po | egrep ^msgid | egrep "dt_" 3) Apply the patch & update again 4) Compare similar strings, there are now a few less strings This does not remove all occurrences, there's no easy way to do that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49868|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 49869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49869&action=edit Bug 16144: Remove 'dt_*' from translation strings when possible This patch removes strings form translation files that have 'dt_*' variables besides puntuation, html constructs, etc. To test: 1) Update strings for any language 2) Check for strings with 'dt_*', eg. for es-ES msgcat --no-wrap po/es-ES-staff-prog.po | egrep ^msgid | egrep "dt_" 3) Apply the patch & update again 4) Compare similar strings, there are now a few less strings This does not remove all occurrences, there's no easy way to do that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel@gmail.com Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- My patch remove some of the problematic strings, but not all. To fix this you need to edit translation file in pootle, I can help to identify those strings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Bernardo, I don't know if we should manage these kind of exceptions. Especially when it does not catch all the strings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #11)
Bernardo, I don't know if we should manage these kind of exceptions. Especially when it does not catch all the strings.
I think you are right, it only catch ~5 strings. Switch to wontfix? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Bernardo Gonzalez Kriegel from comment #12)
(In reply to Jonathan Druart from comment #11)
Bernardo, I don't know if we should manage these kind of exceptions. Especially when it does not catch all the strings.
I think you are right, it only catch ~5 strings. Switch to wontfix?
If it has been fixed on pootle, we can mark it as resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 --- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #13)
If it has been fixed on pootle, we can mark it as resolved.
Yes, those entries have been marked as fuzzy on pootle for 3.20 & 3.22 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org