https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Expose MARC21 tag 765 - |Show MARC21 tag 765 - |Original Language Entry |Original Language Entry -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149588&action=edit Bug 29185: Facilitate searching for cnum Instead of typing the case sensitive Control-number each time. 4 strikes instead of 15 on your keyboard. Wow! Gain of 73%. Test plan: Copy ccl.properties to /etc/koha/zebradb, restart Zebra and search for cnum=SOME_ID in opac or intranet. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149590&action=edit Bug 29185: Display MARC tag 765 in OPAC and intranet XSLT Test plan: ** For OPAC [1] Pick a biblio record A as original entry, fill $001/$003. [2] Pick another biblio record B as translation, add 765 with $t, $a and $d. Put (orgcode)cnum from A into $w. [3] Disable UseControlNumber. [4] Goto OPAC detail page of B. Check link; should be title based. [5] Enable UseControlNumber. [6] Goto OPAC detail page of B. Check link; should incl orgcode and cnum. [7] Edit B. Replace $w with cnum of A only. [8] Goto OPAC detail page of B. Check link; should incl cnum only. ** For staff client [9] Goto staff detail page of B. Check link again. [10] Edit B. Set 765 ind2 to 8, fill $i. [11] Goto staff detail page of B. You should see different label. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33515 [Bug 33515] XSLT: Use GetCnumSearchURL utility template in other places -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149588|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 149906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149906&action=edit Bug 29185: Facilitate searching for cnum Instead of typing the case sensitive Control-number each time. 4 strikes instead of 15 on your keyboard. Wow! Gain of 73%. Test plan: Copy ccl.properties to /etc/koha/zebradb, restart Zebra and search for cnum=SOME_ID in opac or intranet. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149590|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 149908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149908&action=edit Bug 29185: Display MARC tag 765 in OPAC and intranet XSLT Test plan: ** For OPAC [1] Pick a biblio record A as original entry, fill $001/$003. [2] Pick another biblio record B as translation, add 765 with $t, $a and $d. Put (orgcode)cnum from A into $w. [3] Disable UseControlNumber. [4] Goto OPAC detail page of B. Check link; should be title based. [5] Enable UseControlNumber. [6] Goto OPAC detail page of B. Check link; should incl orgcode and cnum. [7] Edit B. Replace $w with cnum of A only. [8] Goto OPAC detail page of B. Check link; should incl cnum only. ** For staff client [9] Goto staff detail page of B. Check link again. [10] Edit B. Set 765 ind2 to 8, fill $i. [11] Goto staff detail page of B. You should see different label. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #7)

Signed-off-by: David Nind <david@davidnind.com>

Thx David. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nick said: "The only bit I am not sure about is the indexing, there is some massaging it looks like in the utils - and I don't see where we have an equivalent in ES" So, that confirms my suspicions that we might need to do more for this to work with ES -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149907|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150358&action=edit Bug 29185: Groundwork: add template GetCnumSearchURL in Utils Note for QA: Opened bug 33515 to see if we can use this same function in a few other places too. Would probably reduce code and increase consistency. Test plan: See next patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, confirms we're only adding an alias here and elasticsearch is handled. Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #15)

OK, confirms we're only adding an alias here and elasticsearch is handled.

Passing QA

Thanks -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #20)

I think quoting here is a bit naive... Can we make it use the quote_search_terms XSLT template we have:

https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha- tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl#L589

Example usage: https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha- tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl#L219-L223

Could you elaborate on this one please? Which construction do you object to ? <xsl:value-of select="normalize-space(translate(substring-before(marc:subfield[@code=$cnum_subfield],')'),'()',''))"/> OR <xsl:value-of select="str:encode-uri(concat($scriptname,'?q=ti,phr:',translate(marc:subfield[@code=$title_subfield], '()', '')),false())"/> In both cases it is not just about quoting a URI part. Note that they are not completely new inventions, but adjusted existent constructs moved to a central template. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #23) 17:02] <tcohen> the latter

<tcohen> you are manually quoting something that comes from the record [17:02] <tcohen> and could in theory contain quote chars

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 151009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151009&action=edit Bug 29185: (QA follow-up) Quote title search in GetCnumSearchURL Test plan: Disable UseControlNumber Change biblio title to something like: Hamlet or CHINESE_CHARS where you add some nice Chinese chars. Create a 765 looking for that title in another biblio record. Without this patch, the link at detail page finds both records, since it looks for ti-phr:Hamlet OR the Chinese chars. With this patch, the link at detail uses quotes and finds only one, since the OR is now part of the ti-phr search. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |aude.charillon@ptfs-europe. | |com Status|Needs documenting |RESOLVED --- Comment #28 from Aude Charillon <aude.charillon@ptfs-europe.com> --- No update to Koha Manual needed. -- You are receiving this mail because: You are watching all bug changes.