[Bug 16082] New: Empty patron detail page is displayed if the patron does not exist - circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 Bug ID: 16082 Summary: Empty patron detail page is displayed if the patron does not exist - circulation.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Circulation Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com On circulation.pl, an empty patron detail page is displayed if the patron does not exist. A friendly message should be displayed instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16073 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches from bug 16073 must be applied before. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 [Bug 16073] Circulation is completely broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16029 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49205&action=edit Bug 16082: Display a friendly "patron does not exist" message if that's the case - circulation.pl The major part of pages you can access from a patron detail page (menu) does not take into consideration the 'patron does not exist' case. If the borrowernumber is linked to a deleted patron, a friendly message should be displayed instead of an empty patron detail page. Test plan: Go on circ/circulation.pl?borrowernumber=424242 and circ/circulation.pl?borrowernumber=424242&batch=1 Notice the difference before and after this patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49205|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 49211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49211&action=edit Bug 16082: Display a friendly "patron does not exist" message if that's the case - circulation.pl The major part of pages you can access from a patron detail page (menu) does not take into consideration the 'patron does not exist' case. If the borrowernumber is linked to a deleted patron, a friendly message should be displayed instead of an empty patron detail page. Test plan: Go on circ/circulation.pl?borrowernumber=424242 and circ/circulation.pl?borrowernumber=424242&batch=1 Notice the difference before and after this patch Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49211|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49332&action=edit [PASSED QA] Bug 16082: Display a friendly "patron does not exist" message if that's the case - circulation.pl The major part of pages you can access from a patron detail page (menu) does not take into consideration the 'patron does not exist' case. If the borrowernumber is linked to a deleted patron, a friendly message should be displayed instead of an empty patron detail page. Test plan: Go on circ/circulation.pl?borrowernumber=424242 and circ/circulation.pl?borrowernumber=424242&batch=1 Notice the difference before and after this patch Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 Bug 16082 depends on bug 16073, which changed state. Bug 16073 Summary: Circulation is completely broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16073 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16240 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16240 [Bug 16240] Regression: Bug 16082 causes message to be displayed even when no borrowernumber is passed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org