[Bug 20600] New: Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Bug ID: 20600 Summary: Provide the ability for users to filter ILL requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com Currently when a staff member is viewing a list of ILL requests, it is only possible to sort the results by column. This bug proposes providing the ability to filter the ILL request list via values displayed in the table columns. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- The work done in this bug will need to be revisited once bug 20581 makes it into master as the filters will need to be adapted to allow for the status alias that requests can have. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 74640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74640&action=edit Bug 20600: API - Format dates according to syspref Dates supplied by the /api/v1/illrequests API route were not conforming to the preference specified by the dateformat syspref. This patch addresses that. It has been addressed as part of this bug since we are adding filtering of requests by some date fields and, therefore, needed dates in a predictable format. To test: 1) Apply the patch 2) Ensure you have at least one ILL request created 3) Make a request to the /api/v1/illrequests endpoint 4) Observe that dates supplied for "placed" & "updated" conform to your dateformat syspref. 5) Change your date format syspref, repeat steps 3 & 4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 74641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74641&action=edit Bug 20600: Add filtering of ILL requests in list This patch adds the ability for the ILL request list in the staff interface to be filtered by a number of criteria: - Status - Date placed - Date modified - Pickup branch - Borrower card number To test: 1) Apply patch 2) Ensure you have a reasonable range of ILL requests created 3) Navigate to the "View ILL requests" page 4) Choose one or more filtering criteria 5) Click "Search" 6) Observe the results are filtered to match the selected criteria 7) Click "Clear" 8) Observe your results are returned to their initial state 9) Repeat steps 4 -> 6 until you are happy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Joe McGlynn <joe.mcglynn@educampus.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joe.mcglynn@educampus.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |magnus@libriotech.no --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- There is a problem with the status_name variable. The error in the Chromium console is this: Uncaught ReferenceError: status_name is not defined at getStatusName (ill-requests.pl:674) at createStatus (ill-requests.pl:649) at jquery.dataTables.min.js:18 at Object.b.fnGetData (jquery.dataTables.min.js:12) at B (jquery.dataTables.min.js:16) at Ia (jquery.dataTables.min.js:14) at mb (jquery.dataTables.min.js:66) at T (jquery.dataTables.min.js:30) at ia (jquery.dataTables.min.js:48) at HTMLTableElement.<anonymous> (jquery.dataTables.min.js:95) status_name is defined on line 281, and used again on line 309: 277 // Render function for request status 278 var createStatus = function(data, type, row, meta) { 279 var origData = meta.settings.oInit.originalData; 280 if (origData.length > 0) { 281 var status_name = meta.settings.oInit.originalData[0].capabilities[ 282 row.status 283 ].name; 284 return getStatusName(status_name); 285 } else { 286 return ''; 287 } 288 }; 289 290 var getStatusName = function(origName) { 291 switch( origName ) { 292 case "New request": 293 return _("New request"); 294 case "Requested": 295 return _("Requested"); 296 case "Requested from partners": 297 return _("Requested from partners"); 298 case "Request reverted": 299 return _("Request reverted"); 300 case "Queued request": 301 return _("Queued request"); 302 case "Cancellation requested": 303 return _("Cancellation requested"); 304 case "Completed": 305 return _("Completed"); 306 case "Delete request": 307 return _("Delete request"); 308 default: 309 return status_name; 310 } 311 }; I think it should either be declared outside the function that starts on line 278, or status_name on line 309 should really be origName? Also, there is a mismatch between some of the names used in the "Filters" box and those used in the table: Date modified = Updated on Pickup branch = Library(?) Borrower card number = Patron barcode This will be a really good enhancement! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #5 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Good spot Magnuse, thanks for that. I'll submit a replacement patch to fix this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74640|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74641|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #6 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 75202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75202&action=edit Bug 20600: Add filtering of ILL requests in list This patch adds the ability for the ILL request list in the staff interface to be filtered by a number of criteria: - Status - Date placed - Date modified - Pickup branch - Borrower card number To test: 1) Apply patch 2) Ensure you have a reasonable range of ILL requests created 3) Navigate to the "View ILL requests" page 4) Choose one or more filtering criteria 5) Click "Search" 6) Observe the results are filtered to match the selected criteria 7) Click "Clear" 8) Observe your results are returned to their initial state 9) Repeat steps 4 -> 6 until you are happy. Dates supplied by the /api/v1/illrequests API route were not conforming to the preference specified by the dateformat syspref. This patch addresses that. It has been addressed as part of this bug since we are adding filtering of requests by some date fields and, therefore, needed dates in a predictable format. To test: 1) Apply the patch 2) Ensure you have at least one ILL request created 3) Make a request to the /api/v1/illrequests endpoint 4) Observe that dates supplied for "placed_formatted" & "updated_formatted" conform to your dateformat syspref. 5) Change your date format syspref, repeat steps 3 & 4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75202|0 |1 is obsolete| | --- Comment #7 from Magnus Enger <magnus@libriotech.no> --- Created attachment 75276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75276&action=edit Bug 20600: Add filtering of ILL requests in list This patch adds the ability for the ILL request list in the staff interface to be filtered by a number of criteria: - Status - Date placed - Date modified - Pickup branch - Borrower card number To test: 1) Apply patch 2) Ensure you have a reasonable range of ILL requests created 3) Navigate to the "View ILL requests" page 4) Choose one or more filtering criteria 5) Click "Search" 6) Observe the results are filtered to match the selected criteria 7) Click "Clear" 8) Observe your results are returned to their initial state 9) Repeat steps 4 -> 6 until you are happy. Dates supplied by the /api/v1/illrequests API route were not conforming to the preference specified by the dateformat syspref. This patch addresses that. It has been addressed as part of this bug since we are adding filtering of requests by some date fields and, therefore, needed dates in a predictable format. To test: 1) Apply the patch 2) Ensure you have at least one ILL request created 3) Make a request to the /api/v1/illrequests endpoint 4) Observe that dates supplied for "placed_formatted" & "updated_formatted" conform to your dateformat syspref. 5) Change your date format syspref, repeat steps 3 & 4 Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. Nice enh! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. Do not use loop variable $_ + foreach(@req_list) { + foreach my $field(@format_dates) { + if (defined $_->{$field}) { + $_->{$field . "_formatted"} = format_sqldatetime( 2. Why do not you use the datepicker plugin as we use it elsewhere? :) 3. For dates in datatables we usually do not use it that way, search for "title-string" in the *.tt files I am not sure you need the 2 *_formatted variables. 4. Is it really useful to provide only a specific dates and not a date range? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #9 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 75734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75734&action=edit Bug 20600: (follow-up) Do not use $_ in loop -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #10 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 75735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75735&action=edit Bug 20600: (follow-up) Remove date formatting It is not required -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #11 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Jonathan Thanks for your feedback. 1. OK, addressed in https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75734 2. OK, addressed in https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75735 3. Thanks for the pointer towards title-string. I have used the *_formatted fields to allow me to display the date fields in the datatable according to the date format set in the sysprefs. Since the data is coming in to the datatable from an API call, I'm not sure how else I can do it. $KohaDates obviously won't work, I couldn't get title-string to either, though, having done some research, it appears it is used to control sorting, rather than display formatting. 4. Good point, I'll create a follow-up patch and submit it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is a date range filter example in serials/claims.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #13 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 75753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75753&action=edit Bug 20600: (follow-up) Add date range filtering It makes more sense to be able to filter placed and updated dates by range. This patch adds that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #14 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Jonathan I've now added a follow-up patch to add the date range filtering. I ended up not following the example you cited, it appears to take a very manual approach of hiding all table rows and then showing them depending on whether they pass the filter test. Doing some research, Datatables has an API that allows custom filters to be defined, it felt cleaner to do this the proper Datatables way. Anyway, thanks for your help on this! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75753|0 |1 is obsolete| | --- Comment #15 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 75755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75755&action=edit Bug 20600: (follow-up) Add date range filtering It makes more sense to be able to filter placed and updated dates by range. This patch adds that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I had not time to test, but wondering if this will work with our various dateformat settings? Adding Owen to take a look :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #16)
I had not time to test, but wondering if this will work with our various dateformat settings?
Filtering by date didn't work for me when the dateformat preference was set to dmydot or metric. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #18 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 75844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75844&action=edit Bug 20600: (follow-up) Fix filtering There was a bug whereby filtering by date would fail if the selected date syspref was set to dmydot or metric. Rather than use the display date value, We now use the non-display date value that is always in a predictable ISO8601 format to construct the Date objects used for comparison. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Oooh, good spot Owen, thanks! I've just attached a follow-up patch that should address this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #20 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 75845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75845&action=edit Bug 20600: (follow-up) Remove console.log! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75276|0 |1 is obsolete| | --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75848&action=edit Bug 20600: Add filtering of ILL requests in list This patch adds the ability for the ILL request list in the staff interface to be filtered by a number of criteria: - Status - Date placed - Date modified - Pickup branch - Borrower card number To test: 1) Apply patch 2) Ensure you have a reasonable range of ILL requests created 3) Navigate to the "View ILL requests" page 4) Choose one or more filtering criteria 5) Click "Search" 6) Observe the results are filtered to match the selected criteria 7) Click "Clear" 8) Observe your results are returned to their initial state 9) Repeat steps 4 -> 6 until you are happy. Dates supplied by the /api/v1/illrequests API route were not conforming to the preference specified by the dateformat syspref. This patch addresses that. It has been addressed as part of this bug since we are adding filtering of requests by some date fields and, therefore, needed dates in a predictable format. To test: 1) Apply the patch 2) Ensure you have at least one ILL request created 3) Make a request to the /api/v1/illrequests endpoint 4) Observe that dates supplied for "placed_formatted" & "updated_formatted" conform to your dateformat syspref. 5) Change your date format syspref, repeat steps 3 & 4 Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. Nice enh! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75734|0 |1 is obsolete| | --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75849&action=edit Bug 20600: (follow-up) Do not use $_ in loop Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75735|0 |1 is obsolete| | --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75850&action=edit Bug 20600: (follow-up) Remove date formatting It is not required Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75755|0 |1 is obsolete| | --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75851&action=edit Bug 20600: (follow-up) Add date range filtering It makes more sense to be able to filter placed and updated dates by range. This patch adds that. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75844|0 |1 is obsolete| | --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75852&action=edit Bug 20600: (follow-up) Fix filtering There was a bug whereby filtering by date would fail if the selected date syspref was set to dmydot or metric. Rather than use the display date value, We now use the non-display date value that is always in a predictable ISO8601 format to construct the Date objects used for comparison. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75845|0 |1 is obsolete| | --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75853&action=edit Bug 20600: (follow-up) Remove console.log! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75854&action=edit Bug 20600: (follow-up) Move template JavaScript to the footer This patch moves the ILL requests template's JavaScript to the footer. Also changed: - Removed unused jQuery checkboxes plugin - Some <input> tags have been corrected to be self-closing. - Title tag has been corrected - Table row limit of 10 has been removed in favor of accepting default used elsewhere. To test, apply the patch and follow the original test plan for this bug. Everything should work as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75854|0 |1 is obsolete| | CC| |andrew.isherwood@ptfs-europ | |e.com --- Comment #28 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 75871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75871&action=edit Bug 20600: (sign-off) Move template JavaScript to the footer Works great, thanks very much for that Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Well, yes it works, but I do not think it is the way to do. I still think we should use the standard title-string sort method. I am not going to consider it as blocker anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Bug 20600 depends on bug 7317, which changed state. Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75848|0 |1 is obsolete| | Attachment #75849|0 |1 is obsolete| | Attachment #75850|0 |1 is obsolete| | Attachment #75851|0 |1 is obsolete| | Attachment #75852|0 |1 is obsolete| | Attachment #75853|0 |1 is obsolete| | Attachment #75871|0 |1 is obsolete| | --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77691&action=edit Bug 20600: Add filtering of ILL requests in list This patch adds the ability for the ILL request list in the staff interface to be filtered by a number of criteria: - Status - Date placed - Date modified - Pickup branch - Borrower card number To test: 1) Apply patch 2) Ensure you have a reasonable range of ILL requests created 3) Navigate to the "View ILL requests" page 4) Choose one or more filtering criteria 5) Click "Search" 6) Observe the results are filtered to match the selected criteria 7) Click "Clear" 8) Observe your results are returned to their initial state 9) Repeat steps 4 -> 6 until you are happy. Dates supplied by the /api/v1/illrequests API route were not conforming to the preference specified by the dateformat syspref. This patch addresses that. It has been addressed as part of this bug since we are adding filtering of requests by some date fields and, therefore, needed dates in a predictable format. To test: 1) Apply the patch 2) Ensure you have at least one ILL request created 3) Make a request to the /api/v1/illrequests endpoint 4) Observe that dates supplied for "placed_formatted" & "updated_formatted" conform to your dateformat syspref. 5) Change your date format syspref, repeat steps 3 & 4 Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. Nice enh! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #31 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77692&action=edit Bug 20600: (follow-up) Do not use $_ in loop Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77693&action=edit Bug 20600: (follow-up) Remove date formatting It is not required Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #33 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77694&action=edit Bug 20600: (follow-up) Add date range filtering It makes more sense to be able to filter placed and updated dates by range. This patch adds that. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77695&action=edit Bug 20600: (follow-up) Fix filtering There was a bug whereby filtering by date would fail if the selected date syspref was set to dmydot or metric. Rather than use the display date value, We now use the non-display date value that is always in a predictable ISO8601 format to construct the Date objects used for comparison. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #35 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77696&action=edit Bug 20600: (follow-up) Remove console.log! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77697&action=edit Bug 20600: (follow-up) Move template JavaScript to the footer This patch moves the ILL requests template's JavaScript to the footer. Also changed: - Removed unused jQuery checkboxes plugin - Some <input> tags have been corrected to be self-closing. - Title tag has been corrected - Table row limit of 10 has been removed in favor of accepting default used elsewhere. To test, apply the patch and follow the original test plan for this bug. Everything should work as expected. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #37 from Owen Leonard <oleonard@myacpl.org> --- I've rebased these patches and moved the changes in staff-global.css to staff-global.scss. Staff client CSS will have to be recompiled for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77691|0 |1 is obsolete| | --- Comment #38 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78439&action=edit Bug 20600: Add filtering of ILL requests in list This patch adds the ability for the ILL request list in the staff interface to be filtered by a number of criteria: - Status - Date placed - Date modified - Pickup branch - Borrower card number To test: 1) Apply patch 2) Ensure you have a reasonable range of ILL requests created 3) Navigate to the "View ILL requests" page 4) Choose one or more filtering criteria 5) Click "Search" 6) Observe the results are filtered to match the selected criteria 7) Click "Clear" 8) Observe your results are returned to their initial state 9) Repeat steps 4 -> 6 until you are happy. Dates supplied by the /api/v1/illrequests API route were not conforming to the preference specified by the dateformat syspref. This patch addresses that. It has been addressed as part of this bug since we are adding filtering of requests by some date fields and, therefore, needed dates in a predictable format. To test: 1) Apply the patch 2) Ensure you have at least one ILL request created 3) Make a request to the /api/v1/illrequests endpoint 4) Observe that dates supplied for "placed_formatted" & "updated_formatted" conform to your dateformat syspref. 5) Change your date format syspref, repeat steps 3 & 4 Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. Nice enh! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78439|0 |1 is obsolete| | --- Comment #39 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78440&action=edit Bug 20600: Add filtering of ILL requests in list This patch adds the ability for the ILL request list in the staff interface to be filtered by a number of criteria: - Status - Date placed - Date modified - Pickup branch - Borrower card number To test: 1) Apply patch 2) Ensure you have a reasonable range of ILL requests created 3) Navigate to the "View ILL requests" page 4) Choose one or more filtering criteria 5) Click "Search" 6) Observe the results are filtered to match the selected criteria 7) Click "Clear" 8) Observe your results are returned to their initial state 9) Repeat steps 4 -> 6 until you are happy. Dates supplied by the /api/v1/illrequests API route were not conforming to the preference specified by the dateformat syspref. This patch addresses that. It has been addressed as part of this bug since we are adding filtering of requests by some date fields and, therefore, needed dates in a predictable format. To test: 1) Apply the patch 2) Ensure you have at least one ILL request created 3) Make a request to the /api/v1/illrequests endpoint 4) Observe that dates supplied for "placed_formatted" & "updated_formatted" conform to your dateformat syspref. 5) Change your date format syspref, repeat steps 3 & 4 Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. Nice enh! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77692|0 |1 is obsolete| | --- Comment #40 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78441&action=edit Bug 20600: (follow-up) Do not use $_ in loop Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77693|0 |1 is obsolete| | --- Comment #41 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78442&action=edit Bug 20600: (follow-up) Remove date formatting It is not required Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77694|0 |1 is obsolete| | --- Comment #42 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78443&action=edit Bug 20600: (follow-up) Add date range filtering It makes more sense to be able to filter placed and updated dates by range. This patch adds that. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77695|0 |1 is obsolete| | --- Comment #43 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78444&action=edit Bug 20600: (follow-up) Fix filtering There was a bug whereby filtering by date would fail if the selected date syspref was set to dmydot or metric. Rather than use the display date value, We now use the non-display date value that is always in a predictable ISO8601 format to construct the Date objects used for comparison. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77696|0 |1 is obsolete| | --- Comment #44 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78445&action=edit Bug 20600: (follow-up) Remove console.log! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77697|0 |1 is obsolete| | --- Comment #45 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78446&action=edit Bug 20600: (follow-up) Move template JavaScript to the footer This patch moves the ILL requests template's JavaScript to the footer. Also changed: - Removed unused jQuery checkboxes plugin - Some <input> tags have been corrected to be self-closing. - Title tag has been corrected - Table row limit of 10 has been removed in favor of accepting default used elsewhere. To test, apply the patch and follow the original test plan for this bug. Everything should work as expected. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78440|0 |1 is obsolete| | --- Comment #46 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78463&action=edit Bug 20600: Add filtering of ILL requests in list This patch adds the ability for the ILL request list in the staff interface to be filtered by a number of criteria: - Status - Date placed - Date modified - Pickup branch - Borrower card number To test: 1) Apply patch 2) Ensure you have a reasonable range of ILL requests created 3) Navigate to the "View ILL requests" page 4) Choose one or more filtering criteria 5) Click "Search" 6) Observe the results are filtered to match the selected criteria 7) Click "Clear" 8) Observe your results are returned to their initial state 9) Repeat steps 4 -> 6 until you are happy. Dates supplied by the /api/v1/illrequests API route were not conforming to the preference specified by the dateformat syspref. This patch addresses that. It has been addressed as part of this bug since we are adding filtering of requests by some date fields and, therefore, needed dates in a predictable format. To test: 1) Apply the patch 2) Ensure you have at least one ILL request created 3) Make a request to the /api/v1/illrequests endpoint 4) Observe that dates supplied for "placed_formatted" & "updated_formatted" conform to your dateformat syspref. 5) Change your date format syspref, repeat steps 3 & 4 Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. Nice enh! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78441|0 |1 is obsolete| | --- Comment #47 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78464&action=edit Bug 20600: (follow-up) Do not use $_ in loop Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78442|0 |1 is obsolete| | --- Comment #48 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78465&action=edit Bug 20600: (follow-up) Remove date formatting It is not required Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78443|0 |1 is obsolete| | --- Comment #49 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78466&action=edit Bug 20600: (follow-up) Add date range filtering It makes more sense to be able to filter placed and updated dates by range. This patch adds that. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78444|0 |1 is obsolete| | --- Comment #50 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78467&action=edit Bug 20600: (follow-up) Fix filtering There was a bug whereby filtering by date would fail if the selected date syspref was set to dmydot or metric. Rather than use the display date value, We now use the non-display date value that is always in a predictable ISO8601 format to construct the Date objects used for comparison. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78445|0 |1 is obsolete| | --- Comment #51 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78468&action=edit Bug 20600: (follow-up) Remove console.log! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78446|0 |1 is obsolete| | --- Comment #52 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78469&action=edit Bug 20600: (follow-up) Move template JavaScript to the footer This patch moves the ILL requests template's JavaScript to the footer. Also changed: - Removed unused jQuery checkboxes plugin - Some <input> tags have been corrected to be self-closing. - Title tag has been corrected - Table row limit of 10 has been removed in favor of accepting default used elsewhere. To test, apply the patch and follow the original test plan for this bug. Everything should work as expected. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #53 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78470&action=edit Bug 20600: (follow-up) Fix bad rebase Rebasing didn't do the right thing, so this patch fixes it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78470|0 |1 is obsolete| | --- Comment #54 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79183&action=edit Bug 20600: (follow-up) Fix bad rebase Rebasing didn't do the right thing, so this patch fixes it Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 18590 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79183|0 |1 is obsolete| | --- Comment #56 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80468&action=edit Bug 20600: (follow-up) Fix bad rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20581 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 [Bug 20581] Allow manual selection of custom ILL request statuses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #57 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 78463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78463 Bug 20600: Add filtering of ILL requests in list Review of attachment 78463: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20600&attachment=78463) ----------------------------------------------------------------- ::: Koha/REST/V1/Illrequests.pm @@ +65,5 @@
} + + # Create new "formatted" columns for each date column + # that needs formatting + foreach(@req_list) {
I do not like this. The date should not be formatted on API level. It should be left to client/UI. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #58 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Josef Moravec from comment #57)
Comment on attachment 78463 [details] [review] Bug 20600: Add filtering of ILL requests in list
Review of attachment 78463 [details] [review]: -----------------------------------------------------------------
::: Koha/REST/V1/Illrequests.pm @@ +65,5 @@
} + + # Create new "formatted" columns for each date column + # that needs formatting + foreach(@req_list) {
I do not like this. The date should not be formatted on API level. It should be left to client/UI.
Thanks for this. I don't like it either. But, having spent a long time trying to figure out how, I came to the conclusion that there's no way of sanely using the date formatting syspref setting from Javascript. Hence me having to pre-format at the server end. There is a precedent for this, though I didn't know it when I implemented it in Illrequests.pm svc/checkouts does exactly the same thing in order to pre-format dates for the API response used in checkouts.js: https://github.com/PTFS-Europe/koha/blob/master/svc/checkouts#L207-L218 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 [Bug 20640] Allow migrating a request between backends -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20581 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 [Bug 20581] Allow manual selection of custom ILL request statuses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18589 |20581 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 [Bug 20581] Allow manual selection of custom ILL request statuses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Depends on|7317 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21482 [Bug 21482] Create a "landing page" for ILL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #59 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 81992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81992&action=edit Bug 20600: (follow-up) Rebase on current master Significant things have changed in master due to ILL enhancement patches being pushed. This patch rebases this bug on top of them -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #60 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 81993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81993&action=edit Bug 20600: (follow-up) Fix errant tabs How on earth these tabs crept in I have no idea... <sigh> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78463|0 |1 is obsolete| | --- Comment #61 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82032&action=edit Bug 20600: Add filtering of ILL requests in list This patch adds the ability for the ILL request list in the staff interface to be filtered by a number of criteria: - Status - Date placed - Date modified - Pickup branch - Borrower card number To test: 1) Apply patch 2) Ensure you have a reasonable range of ILL requests created 3) Navigate to the "View ILL requests" page 4) Choose one or more filtering criteria 5) Click "Search" 6) Observe the results are filtered to match the selected criteria 7) Click "Clear" 8) Observe your results are returned to their initial state 9) Repeat steps 4 -> 6 until you are happy. Dates supplied by the /api/v1/illrequests API route were not conforming to the preference specified by the dateformat syspref. This patch addresses that. It has been addressed as part of this bug since we are adding filtering of requests by some date fields and, therefore, needed dates in a predictable format. To test: 1) Apply the patch 2) Ensure you have at least one ILL request created 3) Make a request to the /api/v1/illrequests endpoint 4) Observe that dates supplied for "placed_formatted" & "updated_formatted" conform to your dateformat syspref. 5) Change your date format syspref, repeat steps 3 & 4 Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. Nice enh! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78464|0 |1 is obsolete| | --- Comment #62 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82033&action=edit Bug 20600: (follow-up) Do not use $_ in loop Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78465|0 |1 is obsolete| | --- Comment #63 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82034&action=edit Bug 20600: (follow-up) Remove date formatting It is not required Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78466|0 |1 is obsolete| | --- Comment #64 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82035&action=edit Bug 20600: (follow-up) Add date range filtering It makes more sense to be able to filter placed and updated dates by range. This patch adds that. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78467|0 |1 is obsolete| | --- Comment #65 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82036&action=edit Bug 20600: (follow-up) Fix filtering There was a bug whereby filtering by date would fail if the selected date syspref was set to dmydot or metric. Rather than use the display date value, We now use the non-display date value that is always in a predictable ISO8601 format to construct the Date objects used for comparison. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78468|0 |1 is obsolete| | --- Comment #66 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82037&action=edit Bug 20600: (follow-up) Remove console.log! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78469|0 |1 is obsolete| | --- Comment #67 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82038&action=edit Bug 20600: (follow-up) Move template JavaScript to the footer This patch moves the ILL requests template's JavaScript to the footer. Also changed: - Removed unused jQuery checkboxes plugin - Some <input> tags have been corrected to be self-closing. - Title tag has been corrected - Table row limit of 10 has been removed in favor of accepting default used elsewhere. To test, apply the patch and follow the original test plan for this bug. Everything should work as expected. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81992|0 |1 is obsolete| | --- Comment #68 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82039&action=edit Bug 20600: (follow-up) Rebase on current master Significant things have changed in master due to ILL enhancement patches being pushed. This patch rebases this bug on top of them -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80468|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81993|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #69 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82062&action=edit Bug 20600: (follow-up) Restore patron name fix The fix for patron name display when no first name is specified was lost in the rebase. This patch restores it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #70 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82170&action=edit Bug 20600: (follow-up) Fix API spec We now return placed_formatted and updated_formatted, the API spec should reflect this -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #71 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82171&action=edit Bug 20600: (follow-up) Fix unit tests The unit tests now need to be aware of the calculated placed_formatted and updated_formatted properties in the API response object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82032|0 |1 is obsolete| | --- Comment #72 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82432&action=edit Bug 20600: Add filtering of ILL requests in list This patch adds the ability for the ILL request list in the staff interface to be filtered by a number of criteria: - Status - Date placed - Date modified - Pickup branch - Borrower card number To test: 1) Apply patch 2) Ensure you have a reasonable range of ILL requests created 3) Navigate to the "View ILL requests" page 4) Choose one or more filtering criteria 5) Click "Search" 6) Observe the results are filtered to match the selected criteria 7) Click "Clear" 8) Observe your results are returned to their initial state 9) Repeat steps 4 -> 6 until you are happy. Dates supplied by the /api/v1/illrequests API route were not conforming to the preference specified by the dateformat syspref. This patch addresses that. It has been addressed as part of this bug since we are adding filtering of requests by some date fields and, therefore, needed dates in a predictable format. To test: 1) Apply the patch 2) Ensure you have at least one ILL request created 3) Make a request to the /api/v1/illrequests endpoint 4) Observe that dates supplied for "placed_formatted" & "updated_formatted" conform to your dateformat syspref. 5) Change your date format syspref, repeat steps 3 & 4 Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. Nice enh! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82033|0 |1 is obsolete| | --- Comment #73 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82433&action=edit Bug 20600: (follow-up) Do not use $_ in loop Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82034|0 |1 is obsolete| | --- Comment #74 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82434&action=edit Bug 20600: (follow-up) Remove date formatting It is not required Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82035|0 |1 is obsolete| | --- Comment #75 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82435&action=edit Bug 20600: (follow-up) Add date range filtering It makes more sense to be able to filter placed and updated dates by range. This patch adds that. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82036|0 |1 is obsolete| | --- Comment #76 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82436&action=edit Bug 20600: (follow-up) Fix filtering There was a bug whereby filtering by date would fail if the selected date syspref was set to dmydot or metric. Rather than use the display date value, We now use the non-display date value that is always in a predictable ISO8601 format to construct the Date objects used for comparison. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82037|0 |1 is obsolete| | --- Comment #77 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82437&action=edit Bug 20600: (follow-up) Remove console.log! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82038|0 |1 is obsolete| | --- Comment #78 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82438&action=edit Bug 20600: (follow-up) Move template JavaScript to the footer This patch moves the ILL requests template's JavaScript to the footer. Also changed: - Removed unused jQuery checkboxes plugin - Some <input> tags have been corrected to be self-closing. - Title tag has been corrected - Table row limit of 10 has been removed in favor of accepting default used elsewhere. To test, apply the patch and follow the original test plan for this bug. Everything should work as expected. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82039|0 |1 is obsolete| | --- Comment #79 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82439&action=edit Bug 20600: (follow-up) Rebase on current master Significant things have changed in master due to ILL enhancement patches being pushed. This patch rebases this bug on top of them -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82062|0 |1 is obsolete| | --- Comment #80 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82440&action=edit Bug 20600: (follow-up) Restore patron name fix The fix for patron name display when no first name is specified was lost in the rebase. This patch restores it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82170|0 |1 is obsolete| | --- Comment #81 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82441&action=edit Bug 20600: (follow-up) Fix API spec We now return placed_formatted and updated_formatted, the API spec should reflect this -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82171|0 |1 is obsolete| | --- Comment #82 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82442&action=edit Bug 20600: (follow-up) Fix unit tests The unit tests now need to be aware of the calculated placed_formatted and updated_formatted properties in the API response object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #83 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, here some first findings: 1) Unit tests failing: t/db_dependent/api/v1/illrequests.t .. # Failed test 'exact match for JSON Pointer ""' # at t/db_dependent/api/v1/illrequests.t line 108. # Structures begin differing at: # $got->[0]{id_prefix} = '' # $expected->[0]{id_prefix} = Does not exist # Failed test 'exact match for JSON Pointer ""' # at t/db_dependent/api/v1/illrequests.t line 143. # Structures begin differing at: # $got->[0]{id_prefix} = '' # $expected->[0]{id_prefix} = Does not exist # Looks like you failed 2 tests of 18. t/db_dependent/api/v1/illrequests.t .. 1/1 # Failed test 'list() tests' # at t/db_dependent/api/v1/illrequests.t line 155. # Looks like you failed 1 test of 1. 2) QA tool complaining: FAIL Koha/REST/V1/Illrequests.pm FAIL critic # Variables::ProhibitUnusedVariables: Got 1 violation(s). I am having some issues with my yarn... so couldn't test further yet. Can you please have a look at the above? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #84 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 83882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83882&action=edit Bug 20600: (follow-up) Fix tests Some silly variable name typos in the tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #85 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #83)
1) Unit tests failing:
Silly mistake in the test script, latest patch fixes it
2) QA tool complaining:
FAIL Koha/REST/V1/Illrequests.pm FAIL critic # Variables::ProhibitUnusedVariables: Got 1 violation(s).
I can't replicate this, I ran: koha-qa.pl -v 2 -c 8 and didn't get any failures. What command did you run and did the error give any indication of what the unused variable was? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83887&action=edit Bug 20600: (follow-up) Fix critic error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorted the critic error for you.. setting back to SO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Bug 20600 depends on bug 20640, which changed state. Bug 20640 Summary: Allow migrating a request between backends https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22268 [Bug 22268] Data displayed in request list datatable is not sanitized -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20640 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 [Bug 20640] Allow migrating a request between backends -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82432|0 |1 is obsolete| | --- Comment #88 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84736&action=edit Bug 20600: Add filtering of ILL requests in list This patch adds the ability for the ILL request list in the staff interface to be filtered by a number of criteria: - Status - Date placed - Date modified - Pickup branch - Borrower card number To test: 1) Apply patch 2) Ensure you have a reasonable range of ILL requests created 3) Navigate to the "View ILL requests" page 4) Choose one or more filtering criteria 5) Click "Search" 6) Observe the results are filtered to match the selected criteria 7) Click "Clear" 8) Observe your results are returned to their initial state 9) Repeat steps 4 -> 6 until you are happy. Dates supplied by the /api/v1/illrequests API route were not conforming to the preference specified by the dateformat syspref. This patch addresses that. It has been addressed as part of this bug since we are adding filtering of requests by some date fields and, therefore, needed dates in a predictable format. To test: 1) Apply the patch 2) Ensure you have at least one ILL request created 3) Make a request to the /api/v1/illrequests endpoint 4) Observe that dates supplied for "placed_formatted" & "updated_formatted" conform to your dateformat syspref. 5) Change your date format syspref, repeat steps 3 & 4 Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. Nice enh! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82433|0 |1 is obsolete| | --- Comment #89 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84737&action=edit Bug 20600: (follow-up) Do not use $_ in loop Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82434|0 |1 is obsolete| | --- Comment #90 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84738&action=edit Bug 20600: (follow-up) Remove date formatting It is not required Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82435|0 |1 is obsolete| | --- Comment #91 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84739&action=edit Bug 20600: (follow-up) Add date range filtering It makes more sense to be able to filter placed and updated dates by range. This patch adds that. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82436|0 |1 is obsolete| | --- Comment #92 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84740&action=edit Bug 20600: (follow-up) Fix filtering There was a bug whereby filtering by date would fail if the selected date syspref was set to dmydot or metric. Rather than use the display date value, We now use the non-display date value that is always in a predictable ISO8601 format to construct the Date objects used for comparison. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82437|0 |1 is obsolete| | --- Comment #93 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84741&action=edit Bug 20600: (follow-up) Remove console.log! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82438|0 |1 is obsolete| | --- Comment #94 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84742&action=edit Bug 20600: (follow-up) Move template JavaScript to the footer This patch moves the ILL requests template's JavaScript to the footer. Also changed: - Removed unused jQuery checkboxes plugin - Some <input> tags have been corrected to be self-closing. - Title tag has been corrected - Table row limit of 10 has been removed in favor of accepting default used elsewhere. To test, apply the patch and follow the original test plan for this bug. Everything should work as expected. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82439|0 |1 is obsolete| | --- Comment #95 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84743&action=edit Bug 20600: (follow-up) Rebase on current master Significant things have changed in master due to ILL enhancement patches being pushed. This patch rebases this bug on top of them Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82440|0 |1 is obsolete| | --- Comment #96 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84744&action=edit Bug 20600: (follow-up) Restore patron name fix The fix for patron name display when no first name is specified was lost in the rebase. This patch restores it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82441|0 |1 is obsolete| | --- Comment #97 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84745&action=edit Bug 20600: (follow-up) Fix API spec We now return placed_formatted and updated_formatted, the API spec should reflect this Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82442|0 |1 is obsolete| | --- Comment #98 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84746&action=edit Bug 20600: (follow-up) Fix unit tests The unit tests now need to be aware of the calculated placed_formatted and updated_formatted properties in the API response object Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83882|0 |1 is obsolete| | --- Comment #99 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84747&action=edit Bug 20600: (follow-up) Fix tests Some silly variable name typos in the tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83887|0 |1 is obsolete| | --- Comment #100 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84748&action=edit Bug 20600: (follow-up) Fix critic error Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #101 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84749&action=edit Bug 20600: (QA follow-up) Fix terminology and capitalization - Subject Line > Subject line - Patron barcode > Cardnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22268 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22268 [Bug 22268] Data displayed in request list datatable is not sanitized -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 [Bug 20640] Allow migrating a request between backends -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #102 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, can you please rebase? One issue was from me adding the price filter, but was not sure about the second, so it would be great if you could take a look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #103 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Even with the revert this still doesn't apply for me? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #104 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's the same issue with the datatables code I had before it looks like, maybe the trouble was not the price patch? Please check. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84736|0 |1 is obsolete| | --- Comment #105 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 85037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85037&action=edit Bug 20600: Add filtering of ILL requests in list This patch adds the ability for the ILL request list in the staff interface to be filtered by a number of criteria: - Status - Date placed - Date modified - Pickup branch - Borrower card number To test: 1) Apply patch 2) Ensure you have a reasonable range of ILL requests created 3) Navigate to the "View ILL requests" page 4) Choose one or more filtering criteria 5) Click "Search" 6) Observe the results are filtered to match the selected criteria 7) Click "Clear" 8) Observe your results are returned to their initial state 9) Repeat steps 4 -> 6 until you are happy. Dates supplied by the /api/v1/illrequests API route were not conforming to the preference specified by the dateformat syspref. This patch addresses that. It has been addressed as part of this bug since we are adding filtering of requests by some date fields and, therefore, needed dates in a predictable format. To test: 1) Apply the patch 2) Ensure you have at least one ILL request created 3) Make a request to the /api/v1/illrequests endpoint 4) Observe that dates supplied for "placed_formatted" & "updated_formatted" conform to your dateformat syspref. 5) Change your date format syspref, repeat steps 3 & 4 Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. Nice enh! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84737|0 |1 is obsolete| | --- Comment #106 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 85038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85038&action=edit Bug 20600: (follow-up) Do not use $_ in loop Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84738|0 |1 is obsolete| | --- Comment #107 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 85039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85039&action=edit Bug 20600: (follow-up) Remove date formatting It is not required Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84739|0 |1 is obsolete| | --- Comment #108 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 85040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85040&action=edit Bug 20600: (follow-up) Add date range filtering It makes more sense to be able to filter placed and updated dates by range. This patch adds that. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84740|0 |1 is obsolete| | --- Comment #109 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 85041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85041&action=edit Bug 20600: (follow-up) Fix filtering There was a bug whereby filtering by date would fail if the selected date syspref was set to dmydot or metric. Rather than use the display date value, We now use the non-display date value that is always in a predictable ISO8601 format to construct the Date objects used for comparison. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84741|0 |1 is obsolete| | --- Comment #110 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 85042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85042&action=edit Bug 20600: (follow-up) Remove console.log! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84742|0 |1 is obsolete| | --- Comment #111 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 85043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85043&action=edit Bug 20600: (follow-up) Move template JavaScript to the footer This patch moves the ILL requests template's JavaScript to the footer. Also changed: - Removed unused jQuery checkboxes plugin - Some <input> tags have been corrected to be self-closing. - Title tag has been corrected - Table row limit of 10 has been removed in favor of accepting default used elsewhere. To test, apply the patch and follow the original test plan for this bug. Everything should work as expected. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84743|0 |1 is obsolete| | --- Comment #112 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 85044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85044&action=edit Bug 20600: (follow-up) Rebase on current master Significant things have changed in master due to ILL enhancement patches being pushed. This patch rebases this bug on top of them Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84744|0 |1 is obsolete| | --- Comment #113 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 85045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85045&action=edit Bug 20600: (follow-up) Restore patron name fix The fix for patron name display when no first name is specified was lost in the rebase. This patch restores it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84745|0 |1 is obsolete| | --- Comment #114 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 85046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85046&action=edit Bug 20600: (follow-up) Fix API spec We now return placed_formatted and updated_formatted, the API spec should reflect this Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84746|0 |1 is obsolete| | --- Comment #115 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 85047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85047&action=edit Bug 20600: (follow-up) Fix unit tests The unit tests now need to be aware of the calculated placed_formatted and updated_formatted properties in the API response object Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84747|0 |1 is obsolete| | --- Comment #116 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 85048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85048&action=edit Bug 20600: (follow-up) Fix tests Some silly variable name typos in the tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84748|0 |1 is obsolete| | --- Comment #117 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 85049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85049&action=edit Bug 20600: (follow-up) Fix critic error Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84749|0 |1 is obsolete| | --- Comment #118 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 85050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85050&action=edit Bug 20600: (QA follow-up) Fix terminology and capitalization - Subject Line > Subject line - Patron barcode > Cardnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #119 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Katrin - I've now fixed the merge conflict. It should apply cleanly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #120 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #121 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@warmlight.co.uk | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org