[Bug 41827] New: Update authority types pages to use grid layout for forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 Bug ID: 41827 Summary: Update authority types pages to use grid layout for forms Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 39780, 41823 - Administration -> Authority types - Administration -> Authority types -> Tags - Administration -> Authority types -> Subfields Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39780 [Bug 39780] Update library groups form to use grid layout https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41823 [Bug 41823] Update acquisitions admin pages to use grid layout for forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41838 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41838 [Bug 41838] Fix automatic tab selection on MARC subfield edit pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 193014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193014&action=edit Bug 41827: Update authority types pages to use grid layout for forms This patch updates authority types administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Administration -> Authority types - Administration -> Authority types -> Tags - Administration -> Authority types -> Subfields Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41839 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41839 [Bug 41839] Update MARC framework pages to use grid layout for forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 [Bug 41841] Update some patron admin templates to use grid layout for forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roman.dolny@jezuici.pl --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Not sure, but there is probably one mistake with "label for" and nearest "id" in auth_subfields_structure.tt, line ~144: <div class="fg-row"> <div class="fg-label"> <label for="tagsubfieldinput[% loo.row | html %]">Subfield code: </label> </div> <div class="fg-input"> <input type="text" name="tagsubfield" value="[% loo.tagsubfield | html %]" size="1" id="tagsubfield" maxlength="1" /> </div> </div> It is not introduced by this patch (is now in code) but maybe it's opportunity to fix it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193014|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 194548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194548&action=edit Bug 41827: Update authority types pages to use grid layout for forms This patch updates authority types administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Administration -> Authority types - Administration -> Authority types -> Tags - Administration -> Authority types -> Subfields Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 194549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194549&action=edit Bug 41827: (follow-up) Correct input label and id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194548|0 |1 is obsolete| | Attachment #194549|0 |1 is obsolete| | --- Comment #5 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 194553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194553&action=edit Bug 41827: Update authority types pages to use grid layout for forms This patch updates authority types administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Administration -> Authority types - Administration -> Authority types -> Tags - Administration -> Authority types -> Subfields Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 --- Comment #6 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 194554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194554&action=edit Bug 41827: (follow-up) Correct input label and id Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194553|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194554|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197805&action=edit Bug 41827: Update authority types pages to use grid layout for forms This patch updates authority types administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Administration -> Authority types - Administration -> Authority types -> Tags - Administration -> Authority types -> Subfields Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197806&action=edit Bug 41827: (follow-up) Correct input label and id Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 --- Comment #10 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41827 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Enhancement - not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org